PhpCsFixerOld::execute() - Code Metrics - uuf6429/elder-brother - Measure and Improve Code Quality continuously with Scrutinizer

PhpCsFixerOld::execute() B
last analyzed 2016-12-11 15:49 UTC

↳ Parent: PhpCsFixerOld

Complexity

Conditions	9
Paths	16

Size

Total Lines	57
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	57
rs	7.0745
c	0
b	0
f	0
cc	9
eloc	35
nc	16
nop	2

How to fix Long Method

<?php

namespace uuf6429\ElderBrother\Action;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Process\Process;
use uuf6429\ElderBrother\Change\FileList;

/**
 * @deprecated Use PhpCsFixer class instead
 */
class PhpCsFixerOld extends ActionAbstract
{
    /**
     * @var FileList
     */
    protected $files;

    /**
     * @var string|null
     */
    protected $binFile;

    /**
     * @var string|null
     */
    protected $configFile;

    /**
     * @var bool
     */
    protected $addAutomatically;

    /**
     * Runs all the provided files through PHP-CS-Fixer, fixing any code style issues.
     *
     * @param FileList    $files            The files to check
     * @param string|null $binFile          (Optional, default is from vendor) File path to PHP-CS-Fixer binary
     * @param string|null $configFile       (Optional, default is project root) File path to PHP-CS-Fixer config
     * @param bool        $addAutomatically (Optional, default is true) Whether to add modified files to commit or not
     */
    public function __construct(FileList $files, $binFile = null, $configFile = null, $addAutomatically = true)
    {
        $this->files = $files;
        $this->binFile = $binFile ?: $this->getBinFile();
        $this->configFile = $configFile;
        $this->addAutomatically = $addAutomatically;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'PHP Code Style Fixer (PhpCsFixerOld)';
    }

    /**
     * {@inheritdoc}
     */
    public function isSupported()
    {
        if (!file_exists($this->binFile)) {
            $this->logger->warning(
                sprintf(
                    'PHP-CS-Fixer could not be found in: %s',
                    $this->binFile
                )
            );

            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $files = $this->files->toArray();

        if (empty($files)) {
            return;
        }

        $progress = $this->createProgressBar($input, $output);
        $progress->start(count($files));

        $failed = [];

        foreach ($files as $file) {
            $progress->setMessage('Checking <info>' . $file . '</info>...');

            $process = new Process(
                sprintf(
                    'php -f %s -- fix %s %s',
                    escapeshellarg($this->binFile),
                    escapeshellarg($file),
                    $this->configFile ? ('--config-file=' . escapeshellarg($this->configFile)) : ''
                )
            );
            $process->run();

            switch ($process->getExitCode()) {
                case 0:

                    // file has been changed
                    if ($this->addAutomatically) {
                        exec('git add ' . escapeshellarg($file));
                    }
                    break;
                case 1:
                    // file not changed
                    break;
                default:
                    // some sort of error
                    $failed[$file] = explode("\n", str_replace(PHP_EOL, "\n", $process->getOutput()));
                    break;
            }

            $progress->advance();
        }

        if (count($failed)) {
            $message = 'PhpCsFixerOld failed for the following file(s):';
            foreach ($failed as $file => $result) {
                $message .= PHP_EOL . '- ' . $file . ':';
                $message .= PHP_EOL . ' - ' . implode(PHP_EOL . ' - ', $result);
            }
            throw new \RuntimeException($message);
        }

        $progress->setMessage('Finished.');
        $progress->finish();
    }

    /**
     * @return string
     */
    protected function getBinFile()
    {
        return PROJECT_ROOT . 'vendor'
            . DIRECTORY_SEPARATOR . 'friendsofphp'
            . DIRECTORY_SEPARATOR . 'php-cs-fixer'
            . DIRECTORY_SEPARATOR . 'php-cs-fixer';
    }
}


1			<?php
2
3			namespace uuf6429\ElderBrother\Action;
4
5			use Symfony\Component\Console\Input\InputInterface;
6			use Symfony\Component\Console\Output\OutputInterface;
7			use Symfony\Component\Process\Process;
8			use uuf6429\ElderBrother\Change\FileList;
9
10			/**
11			* @deprecated Use PhpCsFixer class instead
12			*/
13			class PhpCsFixerOld extends ActionAbstract
14			{
15			/**
16			* @var FileList
17			*/
18			protected $files;
19
20			/**
21			* @var string\|null
22			*/
23			protected $binFile;
24
25			/**
26			* @var string\|null
27			*/
28			protected $configFile;
29
30			/**
31			* @var bool
32			*/
33			protected $addAutomatically;
34
35			/**
36			* Runs all the provided files through PHP-CS-Fixer, fixing any code style issues.
37			*
38			* @param FileList $files The files to check
39			* @param string\|null $binFile (Optional, default is from vendor) File path to PHP-CS-Fixer binary
40			* @param string\|null $configFile (Optional, default is project root) File path to PHP-CS-Fixer config
41			* @param bool $addAutomatically (Optional, default is true) Whether to add modified files to commit or not
42			*/
43			public function __construct(FileList $files, $binFile = null, $configFile = null, $addAutomatically = true)
44			{
45			$this->files = $files;
46			$this->binFile = $binFile ?: $this->getBinFile();
47			$this->configFile = $configFile;
48			$this->addAutomatically = $addAutomatically;
49			}
50
51			/**
52			* {@inheritdoc}
53			*/
54			public function getName()
55			{
56			return 'PHP Code Style Fixer (PhpCsFixerOld)';
57			}
58
59			/**
60			* {@inheritdoc}
61			*/
62			public function isSupported()
63			{
64			if (!file_exists($this->binFile)) {
65			$this->logger->warning(
66			sprintf(
67			'PHP-CS-Fixer could not be found in: %s',
68			$this->binFile
69			)
70			);
71
72			return false;
73			}
74
75			return true;
76			}
77
78			/**
79			* {@inheritdoc}
80			*/
81			public function execute(InputInterface $input, OutputInterface $output)
82			{
83			$files = $this->files->toArray();
84
85			if (empty($files)) {
86			return;
87			}
88
89			$progress = $this->createProgressBar($input, $output);
90			$progress->start(count($files));
91
92			$failed = [];
93
94			foreach ($files as $file) {
95			$progress->setMessage('Checking <info>' . $file . '</info>...');
96
97			$process = new Process(
98			sprintf(
99			'php -f %s -- fix %s %s',
100			escapeshellarg($this->binFile),
101			escapeshellarg($file),
102			$this->configFile ? ('--config-file=' . escapeshellarg($this->configFile)) : ''
103			)
104			);
105			$process->run();
106
107			switch ($process->getExitCode()) {
108			case 0:
			0 ignored issues – show Bug introduced 2016-11-21 19:13 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$process->getExitCode()` of type `integer\|null` to `0`; this is ambiguous as not only `0 == 0` is true, but `null == 0` is true, too. Consider using a strict comparison `===`. Loading history...
109			// file has been changed
110			if ($this->addAutomatically) {
111			exec('git add ' . escapeshellarg($file));
112			}
113			break;
114			case 1:
115			// file not changed
116			break;
117			default:
118			// some sort of error
119			$failed[$file] = explode("\n", str_replace(PHP_EOL, "\n", $process->getOutput()));
120			break;
121			}
122
123			$progress->advance();
124			}
125
126			if (count($failed)) {
127			$message = 'PhpCsFixerOld failed for the following file(s):';
128			foreach ($failed as $file => $result) {
129			$message .= PHP_EOL . '- ' . $file . ':';
130			$message .= PHP_EOL . ' - ' . implode(PHP_EOL . ' - ', $result);
131			}
132			throw new \RuntimeException($message);
133			}
134
135			$progress->setMessage('Finished.');
136			$progress->finish();
137			}
138
139			/**
140			* @return string
141			*/
142			protected function getBinFile()
143			{
144			return PROJECT_ROOT . 'vendor'
145			. DIRECTORY_SEPARATOR . 'friendsofphp'
146			. DIRECTORY_SEPARATOR . 'php-cs-fixer'
147			. DIRECTORY_SEPARATOR . 'php-cs-fixer';
148			}
149			}
150

uuf6429 / elder-brother

PhpCsFixerOld::execute() B last analyzed 2016-12-11 15:49 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

PhpCsFixerOld::execute() B
last analyzed 2016-12-11 15:49 UTC