GetAlbumList2Method::__invoke() - Code Metrics - Inspection of "Add support for `getAlbumList2` method" - usox/hypersonic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( cff59a...745121 )

by Daniel

created 2022-08-27 09:42 UTC

GetAlbumList2Method::__invoke() B

↳ Parent: GetAlbumList2Method

Complexity

Conditions	8
Paths	16

Size

Total Lines	54
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	8

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	31
nc	16
nop	3
dl	0
loc	54
ccs	24
cts	24
cp	1
crap	8
rs	8.1795
c	1
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Usox\HyperSonic\FeatureSet\V1161\Method;

use DateTimeInterface;
use Generator;
use Traversable;
use Usox\HyperSonic\Exception\ErrorCodeEnum;
use Usox\HyperSonic\Exception\MethodCallFailedException;
use Usox\HyperSonic\FeatureSet\V1161\Contract\AlbumList2DataProviderInterface;
use Usox\HyperSonic\FeatureSet\V1161\Responder\ResponderFactoryInterface;
use Usox\HyperSonic\Response\ResponderInterface;

/**
 * Retrieve and transforms album data for the album list
 *
 * This class covers the `getAlbumList2.view` method
 *
 * @see http://www.subsonic.org/pages/api.jsp#getAlbumList2
 */
final class GetAlbumList2Method implements V1161MethodInterface
{
    // list of allowed types for ordering
    private const ORDER_TYPES = [
        'random',
        'newest',
        'frequent',
        'recent',
        'starred',
        'alphabeticalByName',
        'alphabeticalByArtist',
        'byYear',
        'byGenre',
    ];

    private const DEFAULT_LIMIT = 10;
    private const MAX_LIMIT = 500;

    public function __construct(
        private readonly ResponderFactoryInterface $responderFactory,
    ) {
    }

    /**
     * @param array<string, scalar> $queryParams
     * @param array<string, scalar> $args
     *
     * @throws MethodCallFailedException
     */
    public function __invoke(
        AlbumList2DataProviderInterface $albumList2DataProvider,
        array $queryParams,
        array $args,
    ): ResponderInterface {
        $type = $queryParams['type'] ?? '';
        $limit = min((int) ($queryParams['size'] ?? self::DEFAULT_LIMIT), self::MAX_LIMIT);
        $offset = (int) ($queryParams['offset'] ?? 0);
        $musicFolderId = $queryParams['musicFolderId'] ?? null;

        if ($musicFolderId !== null) {
            $musicFolderId = (string) $musicFolderId;
        }

        if (!in_array($type, self::ORDER_TYPES, true)) {
            throw new MethodCallFailedException(
                ErrorCodeEnum::MISSING_PARAMETER
            );
        }

        $orderParameter = [];

        if ($type === 'byYear') {
            $fromYear = $queryParams['fromYear'] ?? null;
            $toYear = $queryParams['toYear'] ?? null;

            if ($fromYear === null || $toYear === null) {
                throw new MethodCallFailedException(
                    ErrorCodeEnum::MISSING_PARAMETER
                );
            }
            $orderParameter = ['year' => ['from' => (int) $fromYear, 'to' => (int) $toYear]];
        }
        if ($type === 'byGenre') {
            $genre = $queryParams['genre'] ?? null;
            if ($genre === null) {
                throw new MethodCallFailedException(
                    ErrorCodeEnum::MISSING_PARAMETER
                );
            }

            $orderParameter = ['genre' => (string) $genre];
        }

        $albumList = $albumList2DataProvider->getAlbums(
            $type,
            /** @scrutinizer ignore-type */ $type,
            $limit,
            $offset,
            $orderParameter,
            $musicFolderId,
        );

        return $this->responderFactory->createAlbumList2Responder(
            $this->transformAlbums($albumList)
        );
    }

    /**
     * @param Traversable<array{
     *  id: string,
     *  name: string,
     *  coverArtId: string,
     *  songCount: int,
     *  createDate: DateTimeInterface,
     *  duration: int,
     *  artistName: string,
     *  artistId: string,
     * }> $albumList
     *
     * @return Generator<array{
     *  id: string,
     *  name: string,
     *  coverArt: string,
     *  songCount: int,
     *  created: string,
     *  duration: int,
     *  artist: string,
     *  artistId: string,
     * }>
     */
    private function transformAlbums(Traversable $albumList): Generator
    {
        foreach ($albumList as $album) {
            yield [
                'id' => $album['id'],
                'name' => $album['name'],
                'coverArt' => $album['coverArtId'],
                'songCount' => $album['songCount'],
                'created' => $album['createDate']->format(DATE_ATOM),
                'duration' => $album['duration'],
                'artist' => $album['artistName'],
                'artistId' => $album['artistId'],
            ];
        }
    }
}


usox / hypersonic

Push — main ( cff59a...745121 )

GetAlbumList2Method::__invoke() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like