Issues in AccessControlTrait.php (master) - Issues in master - usm4n/guardian - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Guardian/AccessControl/AccessControlTrait.php (2 issues)

Labels

Bug 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Usman\Guardian\AccessControl;

trait AccessControlTrait {

    /**
     * Defines a one to many relation with the roles table
     * 
     * @return Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function roles()
    {
        return $this->belongsToMany(config('guardian.roleModel'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    /**
     * Checks for a role
     * 
     * @param  string  $roleName
     * @return boolean
     */
    public function hasRole($roleName)
    {
        foreach($this->roles as $role)
class MyClass { }

$x = new MyClass();
$x->foo = true;
        {
            if(strtolower($role->role_name) == strtolower($roleName))
            {
                return true;
            }
        }
        return false;
    }

    /**
     * Checks for any role
     * 
     * @param  array   $roleNames
     * @return boolean
     */
    public function hasAnyRole(array $roleNames)
    {
        foreach($roleNames as $roleName)
        {
            if($this->hasRole($roleName)) return true;
        }
        return false;
    }

    /**
     * Checks for all roles
     * 
     * @param  array   $roleNames
     * @return boolean
     */
    public function hasAllRoles(array $roleNames)
    {
        foreach($roleNames as $roleName)
        {
            if( ! $this->hasRole($roleName)) return false;
        }
        return true;
    }

    /**
     * Checks if a user has a capability
     * 
     * @param  string  $capabilityName
     * @return boolean
     */
    public function hasCapability($capabilityName)
    {
        foreach($this->roles as $role)
        {
            foreach($role->capabilities as $capability)
            { 
                if(strtolower($capability->capability) == strtolower($capabilityName))
                {
                    return true;
                }
            }
        }
        return false;
    }

    /**
     * Checks if a user has any capability
     * 
     * @param  array   $capabilityNames
     * @return boolean
     */
    public function hasAnyCapability(array $capabilityNames)
    {
        foreach($capabilityNames as $capabilityName)
        {
            if($this->hasCapability($capabilityName)) return true;
        }
        return false;

    }

    /**
     * Checks if a user has all the capabilities
     * 
     * @param  array   $capabilityNames
     * @return boolean
     */
    public function hasAllCapabilities(array $capabilityNames)
    {
        foreach($capabilityNames as $capabilityName)
        {
            if( ! $this->hasCapability($capabilityName)) return false;
        }
        return true;
    }

}


1			<?php namespace Usman\Guardian\AccessControl;
2
3			trait AccessControlTrait {
4
5			/**
6			* Defines a one to many relation with the roles table
7			*
8			* @return Illuminate\Database\Eloquent\Relations\BelongsToMany
9			*/
10			public function roles()
11			{
12			return $this->belongsToMany(config('guardian.roleModel'));
			0 ignored issues – show Bug introduced 2017-05-27 03:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13			}
14
15			/**
16			* Checks for a role
17			*
18			* @param string $roleName
19			* @return boolean
20			*/
21			public function hasRole($roleName)
22			{
23			foreach($this->roles as $role)
			0 ignored issues – show Bug introduced 2017-05-27 03:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `roles` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			{
25			if(strtolower($role->role_name) == strtolower($roleName))
26			{
27			return true;
28			}
29			}
30			return false;
31			}
32
33			/**
34			* Checks for any role
35			*
36			* @param array $roleNames
37			* @return boolean
38			*/
39			public function hasAnyRole(array $roleNames)
40			{
41			foreach($roleNames as $roleName)
42			{
43			if($this->hasRole($roleName)) return true;
44			}
45			return false;
46			}
47
48			/**
49			* Checks for all roles
50			*
51			* @param array $roleNames
52			* @return boolean
53			*/
54			public function hasAllRoles(array $roleNames)
55			{
56			foreach($roleNames as $roleName)
57			{
58			if( ! $this->hasRole($roleName)) return false;
59			}
60			return true;
61			}
62
63			/**
64			* Checks if a user has a capability
65			*
66			* @param string $capabilityName
67			* @return boolean
68			*/
69			public function hasCapability($capabilityName)
70			{
71			foreach($this->roles as $role)
72			{
73			foreach($role->capabilities as $capability)
74			{
75			if(strtolower($capability->capability) == strtolower($capabilityName))
76			{
77			return true;
78			}
79			}
80			}
81			return false;
82			}
83
84			/**
85			* Checks if a user has any capability
86			*
87			* @param array $capabilityNames
88			* @return boolean
89			*/
90			public function hasAnyCapability(array $capabilityNames)
91			{
92			foreach($capabilityNames as $capabilityName)
93			{
94			if($this->hasCapability($capabilityName)) return true;
95			}
96			return false;
97
98			}
99
100			/**
101			* Checks if a user has all the capabilities
102			*
103			* @param array $capabilityNames
104			* @return boolean
105			*/
106			public function hasAllCapabilities(array $capabilityNames)
107			{
108			foreach($capabilityNames as $capabilityName)
109			{
110			if( ! $this->hasCapability($capabilityName)) return false;
111			}
112			return true;
113			}
114
115			}
116

usm4n / guardian

Issues (27)

Security Analysis not enabled

Guardian/AccessControl/AccessControlTrait.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like