ComposersServiceProvider::boot() - Code Metrics - usm4n/guardian - Measure and Improve Code Quality continuously with Scrutinizer

ComposersServiceProvider::boot() A
last analyzed 2017-05-27 03:26 UTC

↳ Parent: ComposersServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	11
nc	1
nop	0

<?php namespace Usman\Guardian\Composers;

use Illuminate\Support\ServiceProvider;

class ComposersServiceProvider extends ServiceProvider {

    /**
     * Registers the view composers after the application is booted.
     *
     * @return void
     */
    public function boot()
    {
        $this->app->view->composers([
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'Usman\Guardian\Composers\RoleOptionsComposer' => [
                'guardian::partials.user.add',
                'guardian::partials.user.edit',
                'guardian::partials.user.search-form',
                'guardian::partials.capability.add',
                'guardian::partials.capability.edit'
            ],
            'Usman\Guardian\Composers\CapabilityOptionsComposer' => [
                'guardian::partials.role.add',
                'guardian::partials.role.edit'
            ]
        ]);
    }

    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register()
    {
        //
    }

}


1			<?php namespace Usman\Guardian\Composers;
2
3			use Illuminate\Support\ServiceProvider;
4
5			class ComposersServiceProvider extends ServiceProvider {
6
7			/**
8			* Registers the view composers after the application is booted.
9			*
10			* @return void
11			*/
12			public function boot()
13			{
14			$this->app->view->composers([
			0 ignored issues – show Bug introduced 2017-05-27 03:26 UTC by Report Bug Copy Issue Report Accessing `view` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
15			'Usman\Guardian\Composers\RoleOptionsComposer' => [
16			'guardian::partials.user.add',
17			'guardian::partials.user.edit',
18			'guardian::partials.user.search-form',
19			'guardian::partials.capability.add',
20			'guardian::partials.capability.edit'
21			],
22			'Usman\Guardian\Composers\CapabilityOptionsComposer' => [
23			'guardian::partials.role.add',
24			'guardian::partials.role.edit'
25			]
26			]);
27			}
28
29			/**
30			* Register the service provider.
31			*
32			* @return void
33			*/
34			public function register()
35			{
36			//
37			}
38
39			}
40

usm4n / guardian

ComposersServiceProvider::boot() A last analyzed 2017-05-27 03:26 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ComposersServiceProvider::boot() A
last analyzed 2017-05-27 03:26 UTC