test_command_flag_on_off() - Code Metrics - Inspection of "Add testcases for CLI and logging" - useblocks/groundwork - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#21)

unknown

created 2018-03-08 13:14 UTC

test_command_flag_on_off() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	5
c	1
b	0
f	1
dl	0
loc	19
rs	8.5454

"""
For ideas how to test commands based on clicks, see http://click.pocoo.org/5/testing/#basic-testing
"""
import click

import pytest

from click import Argument, Option

from click.testing import CliRunner


from groundwork.patterns.gw_commands_pattern import CommandExistException


def test_command_plugin_activation(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    plugin = basicApp.plugins.get("CommandPlugin")
    assert plugin is not None
    assert plugin.active is True


# def test_command_cli_activation(basicApp):
#     test = basicApp.commands.start_cli(standalone_mode=True, args=[])
#     print(test)


def test_command_plugin_execution(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    runner = CliRunner()
    result = runner.invoke(basicApp.commands._commands["test"].click_command, ["--invalid"])
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
    assert "no such option" in result.output
    assert result.exit_code == 2

    result = runner.invoke(basicApp.commands._commands["test"].click_command, ["--arg", "12345"])
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
    assert "12345" in result.output
    assert result.exit_code == 0

    command = basicApp.commands.get("test")
    assert command is not None


def test_command_multi_registration(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(arg):
        print(arg)

    plugin = basicApp.plugins.get("CommandPlugin")
    with pytest.raises(CommandExistException):
        plugin.commands.register("test", "my test command", _test_command, params=[Option(("--arg", "-a"))])


    plugin.commands.unregister("test")
    plugin.commands.register("test", "my test command", _test_command, params=[Option(("--arg", "-a"))])

    assert len(basicApp.commands.get()) == 1

    plugin.commands.register("test2", "my test2 command", _test_command, params=[Option(("--arg", "-a"))])

    assert len(basicApp.commands.get()) == 2

    basicApp.plugins.deactivate(["CommandPlugin"])
    print(basicApp.commands.get().keys())
    assert len(basicApp.commands.get().keys()) == 0



def test_command_multi_plugin_registration(basicApp, EmptyCommandPlugin):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(arg):
        print(arg)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin2 = EmptyCommandPlugin(app=basicApp, name="CommandPlugin2")
    plugin2.activate()
    plugin2.commands.register("test2", "my test2 command", _test_command, params=[Option(("--arg", "-a"))])

    assert len(basicApp.commands.get()) == 2
    assert len(plugin.commands.get()) == 1
    assert len(plugin2.commands.get()) == 1

    basicApp.plugins.deactivate(["CommandPlugin2"])
    assert len(basicApp.commands.get()) == 1
    assert len(plugin.commands.get()) == 1
    assert len(plugin2.commands.get()) == 0



def test_command_mandatory_argument(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with a mandatory argument
    plugin.commands.register("test", "my test command", _test_command, params=[Argument(("man_arg",), required=True)])

    # call command with argument -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ["arg"])
    assert result.exit_code == 0

    # call command with no argument -> expect error
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, [])
    assert result.exit_code == 2


def test_command_optional_argument(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with an optional argument
    plugin.commands.register("test", "my test command", _test_command, params=[Argument(("opt_arg",), required=False)])

    # call command with argument -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ["arg"])
    assert result.exit_code == 0

    # call command with no argument -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, [])
    assert result.exit_code == 0


def test_command_mandatory_option(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with a mandatory option
    plugin.commands.register("test", "my test command", _test_command, params=[Option(["--man-opt"], required=True)])

    # call command with option --man-opt -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ["--man-opt", 123])
    assert result.exit_code == 0

    # call command with no option -> expect error
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, [])
    assert result.exit_code == 2


def test_command_optional_option(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with a mandatory option
    plugin.commands.register("test", "my test command", _test_command, params=[Option(["--opt-opt"], required=False)])

    # call command with option --opt-opt -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ["--opt-opt", 123])
    assert result.exit_code == 0

    # call command with no option -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, [])
    assert result.exit_code == 0


def test_command_path_argument(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with a path argument, that must exist
    plugin.commands.register("test", "my test command", _test_command, params=[Argument(("man_arg",),

                                                                                        type=click.Path(exists=True))])

    # call command with existing path as argument -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, [__file__])
    assert result.exit_code == 0

    # call command with non-existing path as argument -> expect error
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ['no such path'])
    assert result.exit_code == 2


def test_command_path_option(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with a path option, that must exist
    plugin.commands.register("test", "my test command", _test_command, params=[Option(["--path"],
                                                                                      type=click.Path(exists=True))])

    # call command with existing path as option -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ['--path', __file__])
    assert result.exit_code == 0

    # call command with non-existing path as option -> expect error
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ['--path', 'no such path'])

    assert result.exit_code == 2


def test_command_flag_on_off(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)
        if not kwargs['flag_on']:
            raise Exception

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with an on/off flag; command throws exception if flag is off
    plugin.commands.register("test", "my test command", _test_command, params=[Option(["--flag-on/--flag-off"])])


    # call command with --flag-on (True) -> expect ok
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ['--flag-on'])
    assert result.exit_code == 0

    # call command with --flag-off (False)  -> expect error
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ['--flag-off'])
    assert result.exit_code == -1


def test_command_flag_count(basicApp):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def _test_command(*args, **kwargs):
        print(args)
        print(kwargs)
        assert kwargs['flag'] == 3

    plugin = basicApp.plugins.get("CommandPlugin")
    plugin.commands.unregister("test")
    # register a command with a countable flag
    plugin.commands.register("test", "my test command", _test_command, params=[Option(["-f", "--flag"], count=True)])


    # call command with --fff -> count == 3 is asserted in the command handler
    result = CliRunner().invoke(basicApp.commands.get("test").click_command, ['-fff'])
    assert result.exit_code == 0


1			"""
2			For ideas how to test commands based on clicks, see http://click.pocoo.org/5/testing/#basic-testing
3			"""
4			import click
			0 ignored issues – show introduced 2018-03-08 10:36 UTC by Report Bug Copy Issue Report Unable to import 'click' Loading history...
5			import pytest
			0 ignored issues – show introduced 2018-03-08 10:36 UTC by Report Bug Copy Issue Report Unable to import 'pytest' Loading history...
6			from click import Argument, Option
			0 ignored issues – show introduced 2018-03-08 10:36 UTC by Report Bug Copy Issue Report Unable to import 'click' Loading history... introduced 2018-03-08 10:36 UTC by Report Bug Copy Issue Report Imports from package click are not grouped Loading history...
7			from click.testing import CliRunner
			0 ignored issues – show introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report Unable to import 'click.testing' Loading history...
8
9			from groundwork.patterns.gw_commands_pattern import CommandExistException
10
11
12			def test_command_plugin_activation(basicApp):
			0 ignored issues – show Coding Style Naming introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report The name `basicApp` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
13			plugin = basicApp.plugins.get("CommandPlugin")
14			assert plugin is not None
15			assert plugin.active is True
16
17
18			# def test_command_cli_activation(basicApp):
19			# test = basicApp.commands.start_cli(standalone_mode=True, args=[])
20			# print(test)
21
22
23			def test_command_plugin_execution(basicApp):
			0 ignored issues – show Coding Style Naming introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report The name `basicApp` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
24			runner = CliRunner()
25			result = runner.invoke(basicApp.commands._commands["test"].click_command, ["--invalid"])
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report It seems like `_commands` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
26			assert "no such option" in result.output
27			assert result.exit_code == 2
28
29			result = runner.invoke(basicApp.commands._commands["test"].click_command, ["--arg", "12345"])
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-19 14:07 UTC by Report Bug Copy Issue Report It seems like `_commands` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
30			assert "12345" in result.output
31			assert result.exit_code == 0
32

useblocks / groundwork

Pull Request — master (#21)

test_command_flag_on_off() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like