| Conditions | 2 |
| Total Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import os |
||
| 17 | def activate(self): |
||
| 18 | template_folder = os.path.join(os.path.abspath(os.path.dirname(__file__)), "templates") |
||
| 19 | static_folder = os.path.join(os.path.abspath(os.path.dirname(__file__)), "static") |
||
| 20 | self.web.contexts.register("webmanager", |
||
| 21 | template_folder=template_folder, |
||
| 22 | static_folder=static_folder, |
||
| 23 | url_prefix="/webmanager", |
||
| 24 | description="context for web manager urls") |
||
| 25 | |||
| 26 | # Pure groundwork objects |
||
| 27 | |||
| 28 | self.web.routes.register("/", ["GET"], self.__manager_view, context="webmanager", |
||
| 29 | name="manager_view", description="Entry-Page for the webmanager") |
||
| 30 | |||
| 31 | self.web.routes.register("/command", ["GET"], self.__command_view, context="webmanager", |
||
| 32 | name="command_list", description="Lists all registered commands") |
||
| 33 | |||
| 34 | self.web.routes.register("/plugin", ["GET"], self.__plugin_view, context="webmanager", |
||
| 35 | name="plugin_list", description="Lists all registered plugins") |
||
| 36 | |||
| 37 | self.web.routes.register("/plugin/class/<clazz>", ["GET", "POST"], self.__plugin_class_view, |
||
| 38 | context="webmanager", |
||
| 39 | name="plugin_class_details", description="Shows details of a plugin class") |
||
| 40 | |||
| 41 | self.web.routes.register("/plugin/instance/<plugin_name>", ["GET", "POST"], self.__plugin_detail_view, |
||
| 42 | context="webmanager", |
||
| 43 | name="plugin_details", description="Shows details of a plugin instance") |
||
| 44 | |||
| 45 | self.web.routes.register("/signal", ["GET"], self.__signal_view, context="webmanager", |
||
| 46 | name="signal_list", description="Lists all registered signals") |
||
| 47 | |||
| 48 | self.web.routes.register("/receiver", ["GET"], self.__receiver_view, context="webmanager", |
||
| 49 | name="receiver_list", description="Lists all registered receivers") |
||
| 50 | |||
| 51 | self.web.routes.register("/document", ["GET"], self.__document_view, context="webmanager", |
||
| 52 | name="document_list", description="Lists all registered documents") |
||
| 53 | |||
| 54 | # WEB objects |
||
| 55 | |||
| 56 | self.web.routes.register("/route", ["GET"], self.__route_view, context="webmanager", |
||
| 57 | name="route_list", description="Lists all registered routes") |
||
| 58 | |||
| 59 | self.web.routes.register("/menu", ["GET"], self.__menu_view, context="webmanager", |
||
| 60 | name="menu_list", description="Lists all registered menus") |
||
| 61 | |||
| 62 | self.web.routes.register("/context", ["GET"], self.__context_view, context="webmanager", |
||
| 63 | name="context_list", description="Lists all registered contexts") |
||
| 64 | |||
| 65 | self.web.routes.register("/server", ["GET"], self.__server_view, context="webmanager", |
||
| 66 | name="server_list", description="Lists all registered servers") |
||
| 67 | |||
| 68 | with self.app.web.flask.app_context(): |
||
| 69 | webmanager_menu = self.web.menus.register("WebManager", "/webmanager") |
||
| 70 | webmanager_menu.register("Overview", "/webmanager") |
||
| 71 | webmanager_menu.register("Commands", url_for("webmanager.__command_view")) |
||
| 72 | webmanager_menu.register("Signals", url_for("webmanager.__signal_view")) |
||
| 73 | webmanager_menu.register("Receivers", url_for("webmanager.__receiver_view")) |
||
| 74 | webmanager_menu.register("Plugins", url_for("webmanager.__plugin_view")) |
||
| 75 | webmanager_menu.register("Routes", url_for("webmanager.__route_view")) |
||
| 76 | webmanager_menu.register("Menu entries", url_for("webmanager.__menu_view")) |
||
| 77 | webmanager_menu.register("Contexts", url_for("webmanager.__context_view")) |
||
| 78 | webmanager_menu.register("Servers", url_for("webmanager.__server_view")) |
||
| 79 | webmanager_menu.register("Documents", url_for("webmanager.__document_view")) |
||
| 80 | |||
| 153 |