Usamamuneerchaudhary\Notifier\Services\NotificationRepository::findByToken()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function findByToken(string $token): ?Notification
    {
        $notificationId = Cache::get("notifier:tracking_token:{$token}");

        if ($notificationId) {
            return Notification::find($notificationId);

The expression return Usamamuneerchaudhary\Notifier\Models\Notification::find($notificationId) could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Usamamuneerchaudhary\Notifier\Models\Notification|null. Consider adding an additional type-check to rule them out.

        }

        $notifications = Notification::whereJsonContains('data->tracking_token', $token)->get();

        if ($notifications->count() > 0) {
            $notification = $notifications->first();
            Cache::put("notifier:tracking_token:{$token}", $notification->id, now()->addDays(30));
            return $notification;
        }

        return null;
    }