Multi::initRequest() - Code Metrics - Inspection of "fix: update scrutinizer config" - upyun/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bfc0cc...f0e226 )

by sabaku

created 2016-12-25 09:21 UTC

Multi::initRequest() B

↳ Parent: Multi

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	19
nc	1
nop	4
dl	0
loc	26
rs	8.8571
c	0
b	0
f	0

<?php
namespace Upyun\Api;

use GuzzleHttp\Psr7;
use GuzzleHttp\Client;
use Upyun\Config;
use Upyun\Signature;
use Upyun\Util;

class Multi {
    /**
     * @var Config
     */
    protected $config;

    protected $url;

    public function __construct(Config $config) {
        $this->config = $config;
        $this->url = ($this->config->useSsl ? 'https://' : 'http://') . Config::ED_FORM . '/'.
                     $this->config->bucketName;
    }

    /**
     * @param string $path 文件存储路径
     * @param Psr7\stream $stream 通过 `Psr7\stream_for` 方法格式化的流资源
     * @param string $fileHash 文件 md5 值
     * @param array $params 其他自定义参数
     *
     * @return Psr7\Response
     * @throws \Exception
     */
    public function upload($path, $stream, $fileHash, $params = []) {
        $path = '/' . ltrim($path, '/');
        $initInfo = $this->initRequest($path, $stream, $fileHash, $params);
        $blockStatus = $initInfo->status;

        $newBlockStatus = $blockStatus;

        for($blockId = 0; $blockId < $initInfo->blocks; $blockId++) {

            if($blockStatus[$blockId] === 0) {

                $return = $this->blockUpload($initInfo, $blockId, $stream);
                $newBlockStatus = $return->status;
            }
        }

        if(array_sum($newBlockStatus) === $initInfo->blocks) {

            return $this->endRequest($initInfo, $params);
        } else {
            throw new \Exception(sprintf("chunk upload failed! current every block status is : [%s]", implode(',', $newBlockStatus)));
        }
    }

    private function initRequest($path, Psr7\Stream $stream, $fileHash, $params) {
        $metaData = array(
            'expiration' => time() + $this->config->blockExpiration,
            'file_blocks' => ceil($stream->getSize() / $this->config->maxBlockSize),
            'file_hash' => $fileHash,
            'file_size' => $stream->getSize(),
            'path' => $path
        );

        $metaData = array_merge($metaData, $params);
        $policy = Util::base64Json($metaData);
        $signature = Signature::getSignature(
            $this->config,
            $metaData,
            Signature::SIGN_MULTIPART
        );
        $postData = compact('policy', 'signature');

        $client = new Client();
        $response = $client->request('POST', $this->url, [
            'form_params' => $postData,
        ]);

        $initInfo = json_decode($response->getBody()->getContents());
        return $initInfo;
    }

    private function blockUpload($blocksInfo, $blockId, Psr7\Stream $stream, $params = []) {
        $startPosition = $blockId * $this->config->maxBlockSize;
        $endPosition   = $blockId >= $blocksInfo->blocks - 1 ? $stream->getSize() : $startPosition + $this->config->maxBlockSize;

        $stream->seek($startPosition);

        $fileBlock = $stream->read($endPosition - $startPosition);

        $metaData = array(
            'save_token' => $blocksInfo->save_token,
            'expiration' => $blocksInfo->expired_at,
            'block_index' => $blockId,
            'block_hash' => md5($fileBlock),
        );
        $metaData = array_merge($metaData, $params);
        $postData['policy'] = Util::base64Json($metaData);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $postData['signature'] = Signature::getSignature(
            $this->config,
            $metaData,
            Signature::SIGN_MULTIPART,
            $blocksInfo->token_secret
        );

        $multipart = [];
        foreach($postData as $key => $value) {

           $multipart[] = ['name' => $key, 'contents' => $value];
        }
        $multipart[] = [
            'name' => 'file',
            'contents' => $fileBlock,
            'filename' => 'file',  //this value must be file
            'headers' => ['Content-Type' => 'application/octet-stream']
        ];
        $postData['file'] = $fileBlock;

        $client = new Client();
        $response = $client->request('POST', $this->url, [
            'multipart' => $multipart,
        ]);

        return json_decode($response->getBody()->getContents());
    }

    private function endRequest($initInfo, $data = array()) {
        $metaData['save_token'] = $initInfo->save_token;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $metaData['expiration'] = $initInfo->expired_at;

        $metaData = array_merge($metaData, $data);
        $policy = Util::base64Json($metaData);
        $signature = Signature::getSignature(
            $this->config,
            $metaData,
            Signature::SIGN_MULTIPART,
            $initInfo->token_secret
        );
        $postData = compact('policy', 'signature');

        $client = new Client();
        $response = $client->request('POST', $this->url, [
            'form_params' => $postData
        ]);
        return $response;
    }
}


1			<?php
2			namespace Upyun\Api;
3
4			use GuzzleHttp\Psr7;
5			use GuzzleHttp\Client;
6			use Upyun\Config;
7			use Upyun\Signature;
8			use Upyun\Util;
9
10			class Multi {
11			/**
12			* @var Config
13			*/
14			protected $config;
15
16			protected $url;
17
18			public function __construct(Config $config) {
19			$this->config = $config;
20			$this->url = ($this->config->useSsl ? 'https://' : 'http://') . Config::ED_FORM . '/'.
21			$this->config->bucketName;
22			}
23
24			/**
25			* @param string $path 文件存储路径
26			* @param Psr7\stream $stream 通过 `Psr7\stream_for` 方法格式化的流资源
27			* @param string $fileHash 文件 md5 值
28			* @param array $params 其他自定义参数
29			*
30			* @return Psr7\Response
31			* @throws \Exception
32			*/
33			public function upload($path, $stream, $fileHash, $params = []) {
34			$path = '/' . ltrim($path, '/');
35			$initInfo = $this->initRequest($path, $stream, $fileHash, $params);
36			$blockStatus = $initInfo->status;
37
38			$newBlockStatus = $blockStatus;
39
40			for($blockId = 0; $blockId < $initInfo->blocks; $blockId++) {
			0 ignored issues – show Coding Style introduced 2016-12-25 09:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOR keyword; 0 found Loading history...
41			if($blockStatus[$blockId] === 0) {
			0 ignored issues – show Coding Style introduced 2016-12-25 09:25 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
42			$return = $this->blockUpload($initInfo, $blockId, $stream);
43			$newBlockStatus = $return->status;
44			}
45			}
46
47			if(array_sum($newBlockStatus) === $initInfo->blocks) {
			0 ignored issues – show Coding Style introduced 2016-12-25 09:25 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
48			return $this->endRequest($initInfo, $params);
49			} else {
50			throw new \Exception(sprintf("chunk upload failed! current every block status is : [%s]", implode(',', $newBlockStatus)));
51			}
52			}
53
54			private function initRequest($path, Psr7\Stream $stream, $fileHash, $params) {
55			$metaData = array(
56			'expiration' => time() + $this->config->blockExpiration,
57			'file_blocks' => ceil($stream->getSize() / $this->config->maxBlockSize),
58			'file_hash' => $fileHash,
59			'file_size' => $stream->getSize(),
60			'path' => $path
61			);
62
63			$metaData = array_merge($metaData, $params);
64			$policy = Util::base64Json($metaData);
65			$signature = Signature::getSignature(
66			$this->config,
67			$metaData,
68			Signature::SIGN_MULTIPART
69			);
70			$postData = compact('policy', 'signature');
71
72			$client = new Client();
73			$response = $client->request('POST', $this->url, [
74			'form_params' => $postData,
75			]);
76
77			$initInfo = json_decode($response->getBody()->getContents());
78			return $initInfo;
79			}
80
81			private function blockUpload($blocksInfo, $blockId, Psr7\Stream $stream, $params = []) {
82			$startPosition = $blockId * $this->config->maxBlockSize;
83			$endPosition = $blockId >= $blocksInfo->blocks - 1 ? $stream->getSize() : $startPosition + $this->config->maxBlockSize;
84
85			$stream->seek($startPosition);
86
87			$fileBlock = $stream->read($endPosition - $startPosition);
88
89			$metaData = array(
90			'save_token' => $blocksInfo->save_token,
91			'expiration' => $blocksInfo->expired_at,
92			'block_index' => $blockId,
93			'block_hash' => md5($fileBlock),
94			);
95			$metaData = array_merge($metaData, $params);
96			$postData['policy'] = Util::base64Json($metaData);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-25 09:25 UTC by Report Bug Copy Issue Report `$postData` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$postData = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
97			$postData['signature'] = Signature::getSignature(
98			$this->config,
99			$metaData,
100			Signature::SIGN_MULTIPART,
101			$blocksInfo->token_secret
102			);
103
104			$multipart = [];
105			foreach($postData as $key => $value) {
			0 ignored issues – show Coding Style introduced 2016-12-25 09:25 UTC by Report Bug Copy Issue Report Expected 1 space after FOREACH keyword; 0 found Loading history...
106			$multipart[] = ['name' => $key, 'contents' => $value];
107			}
108			$multipart[] = [
109			'name' => 'file',
110			'contents' => $fileBlock,
111			'filename' => 'file', //this value must be file
112			'headers' => ['Content-Type' => 'application/octet-stream']
113			];
114			$postData['file'] = $fileBlock;
115
116			$client = new Client();
117			$response = $client->request('POST', $this->url, [
118			'multipart' => $multipart,
119			]);
120
121			return json_decode($response->getBody()->getContents());
122			}
123
124			private function endRequest($initInfo, $data = array()) {
125			$metaData['save_token'] = $initInfo->save_token;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-25 09:25 UTC by Report Bug Copy Issue Report `$metaData` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$metaData = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
126			$metaData['expiration'] = $initInfo->expired_at;
127
128			$metaData = array_merge($metaData, $data);
129			$policy = Util::base64Json($metaData);
130			$signature = Signature::getSignature(
131			$this->config,
132			$metaData,
133			Signature::SIGN_MULTIPART,
134			$initInfo->token_secret
135			);
136			$postData = compact('policy', 'signature');
137
138			$client = new Client();
139			$response = $client->request('POST', $this->url, [
140			'form_params' => $postData
141			]);
142			return $response;
143			}
144			}
145

upyun / php-sdk

Push — master ( bfc0cc...f0e226 )

Multi::initRequest() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like