Completed
Push — master ( 5733a1...525834 )
by Michał
02:54
created

Values   A

Complexity

Total Complexity 12

Size/Duplication

Total Lines 97
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 4

Importance

Changes 0
Metric Value
wmc 12
c 0
b 0
f 0
lcom 1
cbo 4
dl 0
loc 97
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A definitions() 0 4 1
A all() 0 13 3
A get() 0 8 2
A set() 0 14 3
A assertIsDefined() 0 9 2
1
<?php namespace nyx\console\input\parameter;
2
3
// External dependencies
4
use nyx\core;
5
6
// Internal dependencies
7
use nyx\console\input;
8
9
/**
10
 * Input Values
11
 *
12
 * Base class for Input Argument and Option value collections.
13
 *
14
 * Those collections are bound by their definitions and as such parameters that are not defined cannot be set.
15
 * They can also not escape their definition, eg. a definition may only be set during construction to avoid
16
 * mismatches between the master and the bag definitions referenced in Values collections.
17
 *
18
 * @version     0.1.0
19
 * @author      Michal Chojnacki <[email protected]>
20
 * @copyright   2012-2017 Nyx Dev Team
21
 * @link        https://github.com/unyx/nyx
22
 */
23
abstract class Values extends core\collections\Map
24
{
25
    /**
26
     * @var Definitions  The Definitions of the Parameters that can be present in this collection.
27
     */
28
    protected $definitions;
29
30
    /**
31
     * Constructs an Input Values instance.
32
     *
33
     * @param   Definitions $definition     The Definitions of the Parameters that can be present in this collection.
34
     */
35
    public function __construct(Definitions $definition)
36
    {
37
        $this->definitions = $definition;
38
    }
39
40
    /**
41
     * Returns the Definitions of the Parameters that can be present in this collection.
42
     *
43
     * @return  Definitions
44
     */
45
    public function definitions() : Definitions
46
    {
47
        return $this->definitions;
48
    }
49
50
    /**
51
     * {@inheritdoc}
52
     *
53
     * Overridden to populate the resulting array with default values for Parameters that are
54
     * not actually set.
55
     */
56
    public function all() : array
57
    {
58
        $return = $this->items;
59
60
        // Not doing a simple array merge to preserve the key mapping of the parameters.
61
        foreach ($this->definitions->getDefaultValues() as $name => $value) {
62
            if (!isset($return[$name])) {
63
                $return[$name] = $value;
64
            }
65
        }
66
67
        return $return;
68
    }
69
70
    /**
71
     * {@inheritdoc}
72
     *
73
     * Overridden to fall back to the default value defined for the given parameter if no value has been
74
     * set for it and no $default has been given either.
75
     */
76
    public function get($name, $default = null)
77
    {
78
        $parameter = $this->assertIsDefined($name);
79
80
        // If a value for the given Parameter has been set, return it. Otherwise the default value
81
        // passed to this method takes precedence over default values set in the Value's Definition, if any.
82
        return $this->items[$name] ?? ($default ?? (($value = $parameter->getValue()) ? $value->getDefault() : $default));
83
    }
84
85
    /**
86
     * {@inheritdoc}
87
     */
88
    public function set($name, $value) : core\collections\interfaces\Map
89
    {
90
        $parameter = $this->assertIsDefined($name);
91
92
        // When dealing with a multi-value parameter, push the value into an array instead of just setting it,
93
        // unless it's an array itself (in which case it will override the currently set array).
94
        if ($parameter->getValue() instanceof input\values\Multiple && !is_array($value)) {
95
            $this->items[$name][] = $value;
96
        } else {
97
            $this->items[$name] = $value;
98
        }
99
100
        return $this;
0 ignored issues
show
Bug Best Practice introduced by
The return type of return $this; (nyx\console\input\parameter\Values) is incompatible with the return type of the parent method nyx\core\collections\Map::set of type nyx\core\collections\traits\Map.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
101
    }
102
103
    /**
104
     * Asserts a Parameter with the given name is defined for this collection and returns it.
105
     *
106
     * @param   string  $name           The name of the Parameter.
107
     * @throws  \OutOfBoundsException   When no Parameter with the given name has been defined.
108
     * @return  input\Parameter
109
     */
110
    protected function assertIsDefined(string $name) : input\Parameter
111
    {
112
        /* @var input\Parameter $parameter */
113
        if (!$parameter = $this->definitions->get($name)) {
114
            throw new \OutOfBoundsException("The parameter [$name] is not defined.");
115
        }
116
117
        return $parameter;
118
    }
119
}
120