Mail::send() - Code Metrics - Inspection of "[Notify] Added a Notifiable Trait (currently depen..." - unyx/notify - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 03348d...edfc47 )

by Michał

created 2016-11-22 10:27 UTC

Mail::send() A

↳ Parent: Mail

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	2

<?php namespace nyx\notify\transports;

// External dependencies
use nyx\utils;

// Internal dependencies
use nyx\notify\interfaces;

/**
 * Mail Transport
 *
 * @package     Nyx\Notify
 * @version     0.1.0
 * @author      Michal Chojnacki <[email protected]>
 * @copyright   2012-2017 Nyx Dev Team
 * @link        https://github.com/unyx/nyx
 */
class Mail implements interfaces\Transport
{
    /**
     * @var mail\interfaces\Mailer  The Mailer in use for sending out Messages.
     */
    protected $mailer;

    /**
     * Creates a new Mail Transport instance.
     *
     * @param   mail\interfaces\Mailer  $mailer The Mailer to use for sending out Messages.
     */
    public function __construct(mail\interfaces\Mailer $mailer)
    {
        $this->mailer = $mailer;
    }

    /**
     * {@inheritDoc}
     */
    public function send(interfaces\Notifiable $notifiable, interfaces\Notification $notification)
    {
        /* @var mail\interfaces\Mailable $notification */
        if (!$this->supports($notification)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            throw new \InvalidArgumentException('The given Notification is not supported (did you forget to implement the Mailable Interface?).');
        }

        if (false === $notifiable->routeNotification('mail', $message = $notification->toMail($notifiable))) {
            return;
        }

        // The Notification might have built a subject during the toMail() call, but that's optional.
        // If no subject is available, we are going to use the humanized name of the Notification's class.
        if (empty($message->getSubject())) {
            $message->setSubject(utils\str\Cases::title(utils\str\Cases::delimit(class_basename($notification), ' ')));
        }

        // And finally - just send the message.
        $this->mailer->send($message);
    }

    /**
     * {@inheritDoc}
     */
    public function supports(interfaces\Notification $notification) : bool
    {
        return ($notification instanceof mail\interfaces\Mailable);
    }
}


1			<?php namespace nyx\notify\transports;
2
3			// External dependencies
4			use nyx\utils;
5
6			// Internal dependencies
7			use nyx\notify\interfaces;
8
9			/**
10			* Mail Transport
11			*
12			* @package Nyx\Notify
13			* @version 0.1.0
14			* @author Michal Chojnacki <[email protected]>
15			* @copyright 2012-2017 Nyx Dev Team
16			* @link https://github.com/unyx/nyx
17			*/
18			class Mail implements interfaces\Transport
19			{
20			/**
21			* @var mail\interfaces\Mailer The Mailer in use for sending out Messages.
22			*/
23			protected $mailer;
24
25			/**
26			* Creates a new Mail Transport instance.
27			*
28			* @param mail\interfaces\Mailer $mailer The Mailer to use for sending out Messages.
29			*/
30			public function __construct(mail\interfaces\Mailer $mailer)
31			{
32			$this->mailer = $mailer;
33			}
34
35			/**
36			* {@inheritDoc}
37			*/
38			public function send(interfaces\Notifiable $notifiable, interfaces\Notification $notification)
39			{
40			/* @var mail\interfaces\Mailable $notification */
41			if (!$this->supports($notification)) {
			0 ignored issues – show Documentation introduced 2016-11-22 10:35 UTC by Report Bug Copy Issue Report `$notification` is of type `object<nyx\notify\transp...il\interfaces\Mailable>`, but the function expects a `object<nyx\notify\interfaces\Notification>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			throw new \InvalidArgumentException('The given Notification is not supported (did you forget to implement the Mailable Interface?).');
43			}
44
45			if (false === $notifiable->routeNotification('mail', $message = $notification->toMail($notifiable))) {
46			return;
47			}
48
49			// The Notification might have built a subject during the toMail() call, but that's optional.
50			// If no subject is available, we are going to use the humanized name of the Notification's class.
51			if (empty($message->getSubject())) {
52			$message->setSubject(utils\str\Cases::title(utils\str\Cases::delimit(class_basename($notification), ' ')));
53			}
54
55			// And finally - just send the message.
56			$this->mailer->send($message);
57			}
58
59			/**
60			* {@inheritDoc}
61			*/
62			public function supports(interfaces\Notification $notification) : bool
63			{
64			return ($notification instanceof mail\interfaces\Mailable);
65			}
66			}
67

unyx / notify

Push — master ( 03348d...edfc47 )

Mail::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like