Argv::parse() - Code Metrics - Inspection of "[Console/Input] Moved interfaces\input\Tokens to i..." - unyx/console - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 69d052...8e3b2f )

by Michał

created 2017-02-07 18:00 UTC

Argv::parse() A

↳ Parent: Argv

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php namespace nyx\console\input\formats;

// Internal dependencies
use nyx\console;

/**
 * Argv Input
 *
 * Note: When passing an argv array yourself, ensure it does not contain the scriptname (when using $_SERVER['argv']
 * it will be present as the first element).
 *
 * @version     0.1.0
 * @author      Michal Chojnacki <[email protected]>
 * @copyright   2012-2017 Nyx Dev Team
 * @link        https://github.com/unyx/nyx
 */
class Argv extends console\Input
{
    /**
     * @var lexers\ArgvToCollections    The token parser to be used.
     */
    private $lexer;

    /**
     * Constructs a new Argv Input instance.
     *
     * @param   array                       $parameters An array of parameters (in the argv format).
     * @param   lexers\ArgvToCollections    $lexer      A Argv to Collections Lexer instance.
     */
    public function __construct(array $parameters = null, lexers\ArgvToCollections $lexer = null)
    {
        // If no arguments were passed, let's use the globals returned by the CLI SAPI.
        if (!isset($parameters)) {
            $parameters = $_SERVER['argv'];

            // Strip the script name from the arguments.
            array_shift($parameters);
        }

        $this->lexer = $lexer;
        $this->raw   = new tokens\Argv($parameters);
    }

    /**
     * {@inheritdoc}
     */
    protected function parse() : console\Input
    {
        // Instantiate a Lexer if none has been defined yet.
        if (!isset($this->lexer)) {
            $this->lexer = new lexers\ArgvToCollections;
        }

        // Fill our parameter value collections with the parsed input.
        $this->lexer->fill($this->arguments(), $this->options(), $this->raw);


        return $this;
    }
}


1			<?php namespace nyx\console\input\formats;
2
3			// Internal dependencies
4			use nyx\console;
5
6			/**
7			* Argv Input
8			*
9			* Note: When passing an argv array yourself, ensure it does not contain the scriptname (when using $_SERVER['argv']
10			* it will be present as the first element).
11			*
12			* @version 0.1.0
13			* @author Michal Chojnacki <[email protected]>
14			* @copyright 2012-2017 Nyx Dev Team
15			* @link https://github.com/unyx/nyx
16			*/
17			class Argv extends console\Input
18			{
19			/**
20			* @var lexers\ArgvToCollections The token parser to be used.
21			*/
22			private $lexer;
23
24			/**
25			* Constructs a new Argv Input instance.
26			*
27			* @param array $parameters An array of parameters (in the argv format).
28			* @param lexers\ArgvToCollections $lexer A Argv to Collections Lexer instance.
29			*/
30			public function __construct(array $parameters = null, lexers\ArgvToCollections $lexer = null)
31			{
32			// If no arguments were passed, let's use the globals returned by the CLI SAPI.
33			if (!isset($parameters)) {
34			$parameters = $_SERVER['argv'];
35
36			// Strip the script name from the arguments.
37			array_shift($parameters);
38			}
39
40			$this->lexer = $lexer;
41			$this->raw = new tokens\Argv($parameters);
42			}
43
44			/**
45			* {@inheritdoc}
46			*/
47			protected function parse() : console\Input
48			{
49			// Instantiate a Lexer if none has been defined yet.
50			if (!isset($this->lexer)) {
51			$this->lexer = new lexers\ArgvToCollections;
52			}
53
54			// Fill our parameter value collections with the parsed input.
55			$this->lexer->fill($this->arguments(), $this->options(), $this->raw);
			0 ignored issues – show Compatibility introduced 2017-02-07 18:02 UTC by Report Bug Copy Issue Report `$this->raw` of type `object<nyx\console\input...mats\interfaces\Tokens>` is not a sub-type of `object<nyx\console\input\formats\tokens\Argv>`. It seems like you assume a concrete implementation of the interface `nyx\console\input\formats\interfaces\Tokens` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
56
57			return $this;
58			}
59			}
60

unyx / console

Push — master ( 69d052...8e3b2f )

Argv::parse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like