HttpClientRequestHandler::get() - Code Metrics - Inspection of "Make the entire codebase async" - unreal4u/telegram-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#55)

by Rick

created 2017-07-27 19:45 UTC

HttpClientRequestHandler::get() A

↳ Parent: HttpClientRequestHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

declare(strict_types=1);

namespace unreal4u\TelegramAPI;

use React\EventLoop\LoopInterface;
use React\HttpClient\Client;
use React\HttpClient\Request;
use React\HttpClient\Response;
use React\Promise\Deferred;
use React\Promise\PromiseInterface;
use unreal4u\TelegramAPI\InternalFunctionality\TelegramResponse;

class HttpClientRequestHandler implements RequestHandlerInterface
{
    /**
     * @var Client
     */
    protected $client;

    /**
     * HttpClientRequestHandler constructor.
     * @param LoopInterface $loop
     */
    public function __construct(LoopInterface $loop)
    {
        $this->client = new Client($loop);
    }

    /**
     * @param string $uri
     * @return PromiseInterface
     */
    public function get(string $uri): PromiseInterface
    {
        $request = $this->client->request('GET', $uri);
        return $this->processRequest($request);
    }

    /**
     * @param string $uri
     * @param array $options
     * @return PromiseInterface
     */
    public function post(string $uri, array $options): PromiseInterface
    {
        $headers = !empty($options['headers']) ? $options['headers'] : [];
        $request = $this->client->request('POST', $uri, $headers);
        return $this->processRequest($request, (!empty($options['body']) ? $options['body'] : null));
    }

    /**
     * @param Request $request
     * @param mixed $data
     * @return PromiseInterface
     */
    public function processRequest(Request $request, $data = null)
    {
        $deferred = new Deferred();

        $receivedData = '';
        $request->on('response', function (Response $response) use ($deferred, &$receivedData) {
            $response->on('data', function ($chunk) use (&$receivedData) {
                $receivedData .= $chunk;
            });

            $response->on('end', function () use (&$receivedData, $deferred, $response) {
                $deferred->resolve(new TelegramResponse($receivedData, $response->getHeaders()));
            });
        });

        $request->on('error', function (\Exception $exception) use ($deferred, $receivedData) {
            // First check if the data we received thus far actually is valid.
            // Else, wipe it.
            if (!json_decode($receivedData)) {
                $receivedData = '';
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
            }

            $deferred->reject(new TelegramResponse($receivedData, [], $exception));
        });

        if (!empty($data)) {
            $request->write($data);
        }

        return $deferred->promise();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace unreal4u\TelegramAPI;
6
7			use React\EventLoop\LoopInterface;
8			use React\HttpClient\Client;
9			use React\HttpClient\Request;
10			use React\HttpClient\Response;
11			use React\Promise\Deferred;
12			use React\Promise\PromiseInterface;
13			use unreal4u\TelegramAPI\InternalFunctionality\TelegramResponse;
14
15			class HttpClientRequestHandler implements RequestHandlerInterface
16			{
17			/**
18			* @var Client
19			*/
20			protected $client;
21
22			/**
23			* HttpClientRequestHandler constructor.
24			* @param LoopInterface $loop
25			*/
26			public function __construct(LoopInterface $loop)
27			{
28			$this->client = new Client($loop);
29			}
30
31			/**
32			* @param string $uri
33			* @return PromiseInterface
34			*/
35			public function get(string $uri): PromiseInterface
36			{
37			$request = $this->client->request('GET', $uri);
38			return $this->processRequest($request);
39			}
40
41			/**
42			* @param string $uri
43			* @param array $options
44			* @return PromiseInterface
45			*/
46			public function post(string $uri, array $options): PromiseInterface
47			{
48			$headers = !empty($options['headers']) ? $options['headers'] : [];
49			$request = $this->client->request('POST', $uri, $headers);
50			return $this->processRequest($request, (!empty($options['body']) ? $options['body'] : null));
51			}
52
53			/**
54			* @param Request $request
55			* @param mixed $data
56			* @return PromiseInterface
57			*/
58			public function processRequest(Request $request, $data = null)
59			{
60			$deferred = new Deferred();
61
62			$receivedData = '';
63			$request->on('response', function (Response $response) use ($deferred, &$receivedData) {
64			$response->on('data', function ($chunk) use (&$receivedData) {
65			$receivedData .= $chunk;
66			});
67
68			$response->on('end', function () use (&$receivedData, $deferred, $response) {
69			$deferred->resolve(new TelegramResponse($receivedData, $response->getHeaders()));
70			});
71			});
72
73			$request->on('error', function (\Exception $exception) use ($deferred, $receivedData) {
74			// First check if the data we received thus far actually is valid.
75			// Else, wipe it.
76			if (!json_decode($receivedData)) {
77			$receivedData = '';
			0 ignored issues – show Bug introduced 2017-07-27 19:53 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$receivedData`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
78			}
79
80			$deferred->reject(new TelegramResponse($receivedData, [], $exception));
81			});
82
83			if (!empty($data)) {
84			$request->write($data);
85			}
86
87			return $deferred->promise();
88			}
89			}
90

unreal4u / telegram-api

Pull Request — master (#55)

HttpClientRequestHandler::get() A

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like