UnSubAck::performSpecialActions() - Code Metrics - Inspection of "Add prospects of further classes" - unreal4u/mqtt - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 56612a...1b3824 )

by Camilo

created 2018-01-11 15:20 UTC

UnSubAck::performSpecialActions() A

↳ Parent: UnSubAck

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php

declare(strict_types=1);

namespace unreal4u\MQTT\Protocol;

use unreal4u\MQTT\Internals\ClientInterface;
use unreal4u\MQTT\Internals\ProtocolBase;
use unreal4u\MQTT\Internals\ReadableContent;
use unreal4u\MQTT\Internals\ReadableContentInterface;
use unreal4u\MQTT\Internals\WritableContentInterface;

/**
 * Class SubAck
 * @package unreal4u\MQTT\Protocol
 */
final class UnSubAck extends ProtocolBase implements ReadableContentInterface
{
    use ReadableContent;

    const CONTROL_PACKET_VALUE = 11;

    /**
     * @var int
     */
    private $packetIdentifier = 0;

    public function fillObject(string $rawMQTTHeaders, ClientInterface $client): ReadableContentInterface
    {
        // Read the rest of the request out should only 1 byte have come in
        if (mb_strlen($rawMQTTHeaders) === 1) {
            $rawMQTTHeaders .= $client->readSocketData(3);
        }

        $this->packetIdentifier = $this->extractPacketIdentifier($rawMQTTHeaders);
        return $this;
    }

    /**
     * @inheritdoc
     * @throws \LogicException
     */
    public function performSpecialActions(ClientInterface $client, WritableContentInterface $originalRequest): bool
    {
        /** @var Subscribe $originalRequest */
        if ($this->packetIdentifier !== $originalRequest->getPacketIdentifier()) {
            throw new \LogicException('Packet identifiers do not match!');
        }

        $client
            ->updateLastCommunication()
            ->setBlocking(false)
        ;
        return true;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace unreal4u\MQTT\Protocol;
6
7			use unreal4u\MQTT\Internals\ClientInterface;
8			use unreal4u\MQTT\Internals\ProtocolBase;
9			use unreal4u\MQTT\Internals\ReadableContent;
10			use unreal4u\MQTT\Internals\ReadableContentInterface;
11			use unreal4u\MQTT\Internals\WritableContentInterface;
12
13			/**
14			* Class SubAck
15			* @package unreal4u\MQTT\Protocol
16			*/
17			final class UnSubAck extends ProtocolBase implements ReadableContentInterface
18			{
19			use ReadableContent;
20
21			const CONTROL_PACKET_VALUE = 11;
22
23			/**
24			* @var int
25			*/
26			private $packetIdentifier = 0;
27
28			public function fillObject(string $rawMQTTHeaders, ClientInterface $client): ReadableContentInterface
29			{
30			// Read the rest of the request out should only 1 byte have come in
31			if (mb_strlen($rawMQTTHeaders) === 1) {
32			$rawMQTTHeaders .= $client->readSocketData(3);
33			}
34
35			$this->packetIdentifier = $this->extractPacketIdentifier($rawMQTTHeaders);
36			return $this;
37			}
38
39			/**
40			* @inheritdoc
41			* @throws \LogicException
42			*/
43			public function performSpecialActions(ClientInterface $client, WritableContentInterface $originalRequest): bool
44			{
45			/** @var Subscribe $originalRequest */
46			if ($this->packetIdentifier !== $originalRequest->getPacketIdentifier()) {
47			throw new \LogicException('Packet identifiers do not match!');
48			}
49
50			$client
51			->updateLastCommunication()
52			->setBlocking(false)
53			;
54			return true;
55			}
56			}
57

unreal4u / mqtt

Push — master ( 56612a...1b3824 )

UnSubAck::performSpecialActions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like