unreal4u\MQTT\Internals\ProtocolBase

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Test Coverage

Coverage

80%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	initializeObject()	0	3	1
A	hasActivePacketIdentifier()	0	3	2

<?php

declare(strict_types=1);

namespace unreal4u\MQTT\Internals;

use Psr\Log\LoggerInterface;
use unreal4u\Dummy\Logger;

abstract class ProtocolBase
{
    /**
     * The actual logger object
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * Base constructor for all protocol stuff
     * @param LoggerInterface|null $logger
     */
    final public function __construct(?LoggerInterface $logger = null)
    {
        if ($logger === null) {
            $logger = new Logger();
        }

        // Insert name of class within the logger
        $this->logger = $logger->withName(str_replace('unreal4u\\MQTT\\', '', \get_class($this)));

The method withName() does not exist on Psr\Log\LoggerInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Psr\Log\AbstractLogger or Psr\Log\NullLogger. Are you sure you never get one of those?

        $this->initializeObject();
    }

    /**
     * Should any method have any abnormal default behaviour, we can overwrite this method
     */
    protected function initializeObject(): ProtocolBase
    {
        return $this;
    }

    /**
     * If the object in question uses Packet Identifier functionality, it should be added to the stack
     */
    final public function hasActivePacketIdentifier(): bool
    {
        return property_exists($this, 'packetIdentifier') && $this->packetIdentifier !== null;
    }
}