unreal4u\MQTT\DebugTools::convertToBinaryRepresentation()

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

0

<?php
    public static function convertToBinaryRepresentation(string $rawString): string
    {
        $out = null;
        $strLength = \strlen($rawString);
        for ($a = 0; $a < $strLength; $a++) {
            $dec = \ord($rawString[$a]); //determine symbol ASCII-code
            $bin = sprintf('%08d', base_convert($dec, 10, 2)); //convert to binary representation and add leading zeros
            $out .= $bin;
        }

        return $out;

The expression return $out could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }