DebugTools::convertBinaryToString() - Code Metrics - Inspection of "Refactor the Message to be a VO, add some more tes..." - unreal4u/mqtt - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d00047...c0d95e )

by Camilo

created 2018-03-22 23:52 UTC

DebugTools::convertBinaryToString() A

↳ Parent: DebugTools

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	4
nop	2
crap	3

<?php

declare(strict_types=1);

namespace unreal4u\MQTT;

final class DebugTools
{
    /**
     * Handy debugging function
     *
     * @param string $rawString
     * @return string
     */
    public static function convertToBinaryRepresentation(string $rawString): string
    {
        $out = null;
        $strLength = \strlen($rawString);
        for ($a = 0; $a < $strLength; $a++) {
            $dec = \ord($rawString[$a]); //determine symbol ASCII-code
            $bin = sprintf('%08d', base_convert($dec, 10, 2)); //convert to binary representation and add leading zeros
            $out .= $bin;
        }

        return $out;

    }

    /**
     * Handy debugging function
     *
     * @param string $binaryRepresentation
     * @param bool $applyBase64
     * @return string
     */
    public static function convertBinaryToString(string $binaryRepresentation, bool $applyBase64 = false): string
    {
        $output = '';
        $binaryStringLength = \strlen($binaryRepresentation);
        for ($i = 0; $i < $binaryStringLength; $i += 8) {
            $output .= \chr((int)base_convert(substr($binaryRepresentation, $i, 8), 2, 10));
        }

        if ($applyBase64 === true) {
            return base64_encode($output);
        }

        return $output;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace unreal4u\MQTT;
6
7		final class DebugTools
8		{
9		/**
10		* Handy debugging function
11		*
12		* @param string $rawString
13		* @return string
14		*/
15	1	public static function convertToBinaryRepresentation(string $rawString): string
16		{
17	1	$out = null;
18	1	$strLength = \strlen($rawString);
19	1	for ($a = 0; $a < $strLength; $a++) {
20	1	$dec = \ord($rawString[$a]); //determine symbol ASCII-code
21	1	$bin = sprintf('%08d', base_convert($dec, 10, 2)); //convert to binary representation and add leading zeros
22	1	$out .= $bin;
23		}
24
25	1	return $out;
		0 ignored issues – show Bug Best Practice introduced 2018-03-22 00:46 UTC by Report Bug Copy Issue Report The expression `return $out` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
26		}
27
28		/**
29		* Handy debugging function
30		*
31		* @param string $binaryRepresentation
32		* @param bool $applyBase64
33		* @return string
34		*/
35	2	public static function convertBinaryToString(string $binaryRepresentation, bool $applyBase64 = false): string
36		{
37	2	$output = '';
38	2	$binaryStringLength = \strlen($binaryRepresentation);
39	2	for ($i = 0; $i < $binaryStringLength; $i += 8) {
40	2	$output .= \chr((int)base_convert(substr($binaryRepresentation, $i, 8), 2, 10));
41		}
42
43	2	if ($applyBase64 === true) {
44	1	return base64_encode($output);
45		}
46
47	1	return $output;
48		}
49		}
50

unreal4u / mqtt

Push — master ( d00047...c0d95e )

DebugTools::convertBinaryToString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like