unreal4u\MQTT\DebugTools

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	convertToBinaryRepresentation()	0	11	2
A	convertBinaryToString()	0	13	3

<?php

declare(strict_types=1);

namespace unreal4u\MQTT;

final class DebugTools
{
    /**
     * Handy debugging function
     *
     * @param string $rawString
     * @return string
     */
    public static function convertToBinaryRepresentation(string $rawString): string
    {
        $out = null;
        $strLength = \strlen($rawString);
        for ($a = 0; $a < $strLength; $a++) {
            $dec = \ord($rawString[$a]); //determine symbol ASCII-code
            $bin = sprintf('%08d', base_convert($dec, 10, 2)); //convert to binary representation and add leading zeros
            $out .= $bin;
        }

        return $out;

The expression return $out could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * Handy debugging function
     *
     * @param string $binaryRepresentation
     * @param bool $applyBase64
     * @return string
     */
    public static function convertBinaryToString(string $binaryRepresentation, bool $applyBase64 = false): string
    {
        $output = '';
        $binaryStringLength = \strlen($binaryRepresentation);
        for ($i = 0; $i < $binaryStringLength; $i += 8) {
            $output .= \chr(base_convert(substr($binaryRepresentation, $i, 8), 2, 10));

base_convert(substr($binaryRepresentation, $i, 8), 2, 10) of type string is incompatible with the type integer expected by parameter $ascii of chr().

        }

        if ($applyBase64 === true) {
            return base64_encode($output);
        }

        return $output;
    }
}