HasCode::canUpdateCode() - Code Metrics - Inspection of "Refactor GitHub main action for better slack integ..." - unil-lettres/dilps-tiresias - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 03a6f5...40da0b )

by Luca

created 2020-12-04 14:59 UTC

HasCode::canUpdateCode() A

↳ Parent: HasCode

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes

Metric	Value
eloc	5
c	0
b	0
f	0
dl	0
loc	10
ccs	4
cts	5
cp	0.8
rs	10
cc	2
nc	2
nop	0
crap	2.032

<?php

declare(strict_types=1);

namespace Application\Traits;

use Application\Api\Exception;
use Application\Model\User;
use Doctrine\ORM\Mapping as ORM;

trait HasCode
{
    /**
     * @var null|string
     *
     * @ORM\Column(type="string", length=30, nullable=true)
     */
    private $code;

    /**
     * Set code
     */
    public function setCode(?string $code): void
    {
        if ($code === '') {
            $code = null;
        }

        if ($code !== $this->code && !$this->canUpdateCode()) {
            throw new Exception('Only majors and administrators are allowed to update card.code');
        }

        $this->code = $code;
    }

    /**
     * Get code
     */
    public function getCode(): ?string
    {
        return $this->code;
    }

    /**
     * Simple ACL check
     */
    private function canUpdateCode(): bool
    {
        $whitelist = [
            User::ROLE_MAJOR,
            User::ROLE_ADMINISTRATOR,
        ];

        $currentRole = User::getCurrent() ? User::getCurrent()->getRole() : User::ROLE_ANONYMOUS;

        return in_array($currentRole, $whitelist, true);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Application\Traits;
6
7		use Application\Api\Exception;
8		use Application\Model\User;
9		use Doctrine\ORM\Mapping as ORM;
10
11		trait HasCode
12		{
13		/**
14		* @var null\|string
15		*
16		* @ORM\Column(type="string", length=30, nullable=true)
17		*/
18		private $code;
19
20		/**
21		* Set code
22		*/
23	2	public function setCode(?string $code): void
24		{
25	2	if ($code === '') {
26		$code = null;
27		}
28
29	2	if ($code !== $this->code && !$this->canUpdateCode()) {
30		throw new Exception('Only majors and administrators are allowed to update card.code');
31		}
32
33	2	$this->code = $code;
34	2	}
35
36		/**
37		* Get code
38		*/
39	7	public function getCode(): ?string
40		{
41	7	return $this->code;
42		}
43
44		/**
45		* Simple ACL check
46		*/
47	5	private function canUpdateCode(): bool
48		{
49		$whitelist = [
50	5	User::ROLE_MAJOR,
51		User::ROLE_ADMINISTRATOR,
52		];
53
54	5	$currentRole = User::getCurrent() ? User::getCurrent()->getRole() : User::ROLE_ANONYMOUS;
55
56	5	return in_array($currentRole, $whitelist, true);
57		}
58		}
59

unil-lettres / dilps-tiresias

Push — master ( 03a6f5...40da0b )

HasCode::canUpdateCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like