Exporter::__construct() - Code Metrics - Inspection of "Upgrade Natural" - unil-lettres/dilps-tiresias - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 029e81...ce5fbf )

by Luca

created 2021-04-12 12:24 UTC

Exporter::__construct() A

↳ Parent: Exporter

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	8
c	1
b	0
f	0
dl	0
loc	18
ccs	9
cts	9
cp	1
rs	10
cc	1
nc	1
nop	8
crap	1

How to fix Many Parameters

<?php

declare(strict_types=1);

namespace Application\Service\Exporter;

use Application\DBAL\Types\ExportFormatType;
use Application\Model\Export;
use Application\Model\User;
use Application\Repository\CardRepository;
use Application\Repository\ExportRepository;
use Application\Service\MessageQueuer;
use Ecodev\Felix\Api\Exception;
use Ecodev\Felix\Service\Mailer;
use InvalidArgumentException;
use Throwable;

class Exporter
{
    private ExportRepository $exportRepository;

    private CardRepository $cardRepository;

    private MessageQueuer $messageQueuer;

    private Mailer $mailer;

    private Writer $zip;

    private Writer $pptx;

    private Writer $csv;

    private string $phpPath;

    public function __construct(
        ExportRepository $exportRepository,
        CardRepository $cardRepository,
        MessageQueuer $messageQueuer,
        Mailer $mailer,
        Writer $zip,
        Writer $pptx,
        Writer $csv,
        string $phpPath
    ) {
        $this->exportRepository = $exportRepository;
        $this->cardRepository = $cardRepository;
        $this->messageQueuer = $messageQueuer;
        $this->mailer = $mailer;
        $this->zip = $zip;
        $this->pptx = $pptx;
        $this->csv = $csv;
        $this->phpPath = $phpPath;
    }

    /**
     * Export asynchronously in a separate process.
     *
     * This should be the preferred way to do big export
     */
    public function exportAsync(Export $export): void
    {
        $args = [
            realpath('bin/export.php'),
            $export->getId(),
        ];

        $escapedArgs = array_map('escapeshellarg', $args);

        // Forward SERVER_NAME to CLI command
        $env = 'SERVER_NAME=' . escapeshellarg(getenv('SERVER_NAME'));

        $cmd = $env . ' ' . escapeshellcmd($this->phpPath) . ' ' . implode(' ', $escapedArgs) . ' > /dev/null 2>&1 &';
        exec($cmd);
    }

    /**
     * Export immediately and return the v $export object
     *
     * Because this method will indirectly clear the EntityManager any existing object
     * before calling this method will become invalid and must be re-fetched from DB.
     */
    public function export(Export $export): Export
    {
        $writer = $this->getWriter($export);
        $title = $export->getSite() . '-' . $export->getId();

        // Poor man's security by using hard-to-guess suffix
        $suffix = bin2hex(random_bytes(5));

        $filename = $title . '-' . $suffix . '.' . $writer->getExtension();

        $export->markAsInProgress($filename);
        _em()->flush();

        try {
            $writer->initialize($export, $title);
            $this->writeCards($writer, $export);
            $writer->finalize();

            $reloadExport = $this->reloadExport($export);
            $reloadExport->markAsDone();
        } catch (Throwable $throwable) {
            $reloadExport = $this->reloadExport($export);
            $reloadExport->markAsErrored($throwable);

            throw $throwable;
        } finally {
            _em()->flush();
        }

        return $reloadExport;
    }

    private function reloadExport(Export $export): Export
    {
        User::reloadCurrentUser();

        return $this->exportRepository->findOneById($export->getId());
        return $this->exportRepository->/** @scrutinizer ignore-call */ findOneById($export->getId());
    }

    /**
     * Export immediately and send an email to the export creator.
     *
     * This must only be used via CLI, because export might be very long (several minutes)
     * and the email is sent synchronously
     */
    public function exportAndSendMessage(int $id): void
    {
        /** @var null|Export $export */
        $export = $this->exportRepository->findOneById($id);
        if (!$export) {
            throw new InvalidArgumentException('Could not find export with ID: ' . $id);
        }

        $export = $this->export($export);

        $user = $export->getCreator();
        $message = $this->messageQueuer->queueExportDone($user, $export);
        $message = $this->messageQueuer->queueExportDone(/** @scrutinizer ignore-type */ $user, $export);

        $this->mailer->sendMessage($message);
    }

    private function getWriter(Export $export): Writer
    {
        switch ($export->getFormat()) {
            case ExportFormatType::ZIP:
                return $this->zip;
            case ExportFormatType::PPTX:
                return $this->pptx;
            case ExportFormatType::CSV:
                return $this->csv;
            default:
                throw new Exception('Invalid export format:' . $export->getFormat());
        }
    }

    /**
     * Write all cards in small batches to avoid exploding PHP memory
     */
    private function writeCards(Writer $writer, Export $export): void
    {
        $totalRecordsProcessed = 0;
        while (true) {
            $cards = $this->cardRepository->getExportCards($export, $totalRecordsProcessed);

            // If nothing to process anymore, stop the whole thing
            if (!$cards) {

                break;
            }

            foreach ($cards as $card) {
                $writer->write($card);

                ++$totalRecordsProcessed;
            }

            _em()->flush();
            _em()->clear();
        }
    }
}


unil-lettres / dilps-tiresias

Push — master ( 029e81...ce5fbf )

Exporter::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like