Application\Repository\DomainRepository::getByCards()

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2.0023

Importance

Changes

0

<?php
    public function getByCards(QueryBuilder $cardQb): array
    {
        $cardIds = array_map(fn ($card) => $card->getId(), $cardQb->getQuery()->getResult());

It seems like $cardQb->getQuery()->getResult() can also be of type integer; however, parameter $array of array_map() does only seem to accept array, maybe add an additional type check?

        if (count($cardIds) === 0) {
            return [];
        }

        $qb = $this
            ->createQueryBuilder('d')
            ->innerJoin(Card::class, 'c')
            ->innerJoin('c.domains', 'd2', 'WITH', 'd2.id = d.id')
            ->where('c.id in (' . implode(',', $cardIds) . ')')
            ->groupBy('d.id')
            ->orderBy('COUNT(c.id)', 'DESC');

        return $qb->getQuery()->getResult();

The expression return $qb->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }