Application\Repository\ArtistRepository::getOrCreateByNames()

Complexity

Conditions	4
Paths	5

Size

Total Lines	35
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	4.0023

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getOrCreateByNames(array $names, Site $site): array
    {
        if (!$names) {

The expression $names of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }

        // Dedup and trim whitespaces
        $names = array_unique(array_map(fn ($value) => trim($value), $names));

        $artists = $this->findBy([
            'name' => $names,
            'site' => $site->value,
        ]);

        $found = [];
        foreach ($artists as $artist) {
            // Names are not trimmed when saved from thesaurus interface, so we
            // have names with trailing whitespace in the database.
            // With the collation we use, MariaDB trims whitespaces when doing
            // comparison (affecting UNIQUE constraint and SELECT queries).
            // So we must be sure to handle whitespaces in the same way as
            // MariaDB when doing comparisons.
            $found[] = trim($artist->getName());
        }

        $notFound = array_diff($names, $found);
        foreach ($notFound as $name) {
            $artist = new Artist();
            $artist->setSite($site);
            $this->getEntityManager()->persist($artist);
            $artist->setName($name);
            $artists[] = $artist;
        }

        return $artists;
    }