SuggestUpdate::build() - Code Metrics - unil-lettres/dilps-tiresias - Measure and Improve Code Quality continuously with Scrutinizer

SuggestUpdate::build() A
last analyzed 2025-10-28 14:08 UTC

↳ Parent: SuggestUpdate

Complexity

Conditions	3
Paths	1

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	3.0011

Importance

Changes

Metric	Value
eloc	18
c	0
b	0
f	0
dl	0
loc	30
ccs	19
cts	20
cp	0.95
rs	9.6666
cc	3
nc	1
nop	0
crap	3.0011

<?php

declare(strict_types=1);

namespace Application\Api\Field\Mutation;

use Application\Api\Helper;
use Application\Enum\ChangeType;
use Application\Enum\Site;
use Application\Model\Card;
use Application\Model\Change;
use Application\Repository\ChangeRepository;
use Ecodev\Felix\Api\Exception;
use Ecodev\Felix\Api\Field\FieldInterface;
use GraphQL\Type\Definition\Type;

class SuggestUpdate implements FieldInterface
{
    public static function build(): iterable
    {
        yield 'suggestUpdate' => fn () => [
            'type' => Type::nonNull(_types()->getOutput(Change::class)),
            'description' => 'Suggest the update of an existing image',
            'args' => [
                'id' => Type::nonNull(_types()->getId(Card::class)),
                'request' => Type::nonNull(Type::string()),
            ],
            'resolve' => function ($root, array $args): Change {
                /** @var Site $site */
                $site = $root['site'];

                $suggestion = $args['id']->getEntity();
                $original = $suggestion->getOriginal();

                if (!$original) {
                    throw new Exception('An suggestion must have an original defined');
                }

                /** @var ChangeRepository $changeRepository */
                $changeRepository = _em()->getRepository(Change::class);
                $change = $changeRepository->getOrCreate(ChangeType::Update, $suggestion, $args['request'], $site);
                Helper::throwIfDenied($change, 'create');

                if (!$change->getId()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                    _em()->flush();
                }

                return $change;
            },
        ];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Application\Api\Field\Mutation;
6
7		use Application\Api\Helper;
8		use Application\Enum\ChangeType;
9		use Application\Enum\Site;
10		use Application\Model\Card;
11		use Application\Model\Change;
12		use Application\Repository\ChangeRepository;
13		use Ecodev\Felix\Api\Exception;
14		use Ecodev\Felix\Api\Field\FieldInterface;
15		use GraphQL\Type\Definition\Type;
16
17		class SuggestUpdate implements FieldInterface
18		{
19	1	public static function build(): iterable
20		{
21	1	yield 'suggestUpdate' => fn () => [
22	1	'type' => Type::nonNull(_types()->getOutput(Change::class)),
23	1	'description' => 'Suggest the update of an existing image',
24	1	'args' => [
25	1	'id' => Type::nonNull(_types()->getId(Card::class)),
26	1	'request' => Type::nonNull(Type::string()),
27	1	],
28	1	'resolve' => function ($root, array $args): Change {
29		/** @var Site $site */
30	1	$site = $root['site'];
31
32	1	$suggestion = $args['id']->getEntity();
33	1	$original = $suggestion->getOriginal();
34
35	1	if (!$original) {
36		throw new Exception('An suggestion must have an original defined');
37		}
38
39		/** @var ChangeRepository $changeRepository */
40	1	$changeRepository = _em()->getRepository(Change::class);
41	1	$change = $changeRepository->getOrCreate(ChangeType::Update, $suggestion, $args['request'], $site);
42	1	Helper::throwIfDenied($change, 'create');
43
44	1	if (!$change->getId()) {
		0 ignored issues – show Bug Best Practice introduced 2022-02-21 09:14 UTC by Report Bug Copy Issue Report The expression `$change->getId()` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
45	1	_em()->flush();
46		}
47
48	1	return $change;
49	1	},
50	1	];
51		}
52		}
53

unil-lettres / dilps-tiresias

SuggestUpdate::build() A last analyzed 2025-10-28 14:08 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SuggestUpdate::build() A
last analyzed 2025-10-28 14:08 UTC