ApiNode - Code Metrics - Inspection of "Merge pull request #35 from unikorp/refactor/renam..." - unikorp/kong-admin-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 861dcb...319287 )

by VEBER

created 2017-08-15 21:07 UTC

ApiNode A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	75
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	1
dl	75
loc	75
ccs	12
cts	12
cp	1
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	addApi()	4	4	1
A	retrieveApi()	4	4	1
A	listApis()	4	4	1
A	updateApi()	4	4	1
A	updateOrCreateApi()	4	4	1
A	deleteApi()	4	4	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the KongAdminApi package.
 *
 * (c) Unikorp <https://github.com/unikorp>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Unikorp\KongAdminApi\Node;

use Psr\Http\Message\ResponseInterface;
use Unikorp\KongAdminApi\AbstractNode;
use Unikorp\KongAdminApi\Document\ApiDocument as Document;

/**
 * api node
 *
 * @author VEBER Arnaud <https://github.com/VEBERArnaud>
 */
class ApiNode extends AbstractNode

{
    /**
     * add api
     *
     * @param \Unikorp\KongAdminApi\Document\ApiDocument $document
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function addApi(Document $document): ResponseInterface
    {
        return $this->post('/apis/', $document);
    }

    /**
     * retrieve api
     *
     * @param string $nameOrId
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function retrieveApi(string $nameOrId): ResponseInterface
    {
        return $this->get(sprintf('/apis/%1$s', $nameOrId));
    }

    /**
     * list apis
     *
     * @param \Unikorp\KongAdminApi\Document\ApiDocument $document
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function listApis(Document $document = null): ResponseInterface
    {
        return $this->get('/apis/', $document);
    }

    /**
     * update api
     *
     * @param string $nameOrId
     * @param \Unikorp\KongAdminApi\Document\ApiDocument $document
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function updateApi(string $nameOrId, Document $document): ResponseInterface
    {
        return $this->patch(sprintf('/apis/%1$s', $nameOrId), $document);
    }

    /**
     * update or create api
     *
     * @param \Unikorp\KongAdminApi\Document\ApiDocument $document
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function updateOrCreateApi(Document $document): ResponseInterface
    {
        return $this->put('/apis/', $document);
    }

    /**
     * delete api
     *
     * @param string $nameOrId
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function deleteApi(string $nameOrId): ResponseInterface
    {
        return $this->delete(sprintf('/apis/%1$s', $nameOrId));
    }
}


1			<?php
2
3			/*
4			* This file is part of the KongAdminApi package.
5			*
6			* (c) Unikorp <https://github.com/unikorp>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Unikorp\KongAdminApi\Node;
13
14			use Psr\Http\Message\ResponseInterface;
15			use Unikorp\KongAdminApi\AbstractNode;
16			use Unikorp\KongAdminApi\Document\ApiDocument as Document;
17
18			/**
19			* api node
20			*
21			* @author VEBER Arnaud <https://github.com/VEBERArnaud>
22			*/
23		View Code Duplication	class ApiNode extends AbstractNode
			0 ignored issues – show Duplication introduced 2017-01-28 19:53 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24			{
25			/**
26			* add api
27			*
28			* @param \Unikorp\KongAdminApi\Document\ApiDocument $document
29			*
30			* @return \Psr\Http\Message\ResponseInterface
31			*/
32	2		public function addApi(Document $document): ResponseInterface
33			{
34	2		return $this->post('/apis/', $document);
35			}
36
37			/**
38			* retrieve api
39			*
40			* @param string $nameOrId
41			*
42			* @return \Psr\Http\Message\ResponseInterface
43			*/
44	2		public function retrieveApi(string $nameOrId): ResponseInterface
45			{
46	2		return $this->get(sprintf('/apis/%1$s', $nameOrId));
47			}
48
49			/**
50			* list apis
51			*
52			* @param \Unikorp\KongAdminApi\Document\ApiDocument $document
53			*
54			* @return \Psr\Http\Message\ResponseInterface
55			*/
56	2		public function listApis(Document $document = null): ResponseInterface
57			{
58	2		return $this->get('/apis/', $document);
59			}
60
61			/**
62			* update api
63			*
64			* @param string $nameOrId
65			* @param \Unikorp\KongAdminApi\Document\ApiDocument $document
66			*
67			* @return \Psr\Http\Message\ResponseInterface
68			*/
69	2		public function updateApi(string $nameOrId, Document $document): ResponseInterface
70			{
71	2		return $this->patch(sprintf('/apis/%1$s', $nameOrId), $document);
72			}
73
74			/**
75			* update or create api
76			*
77			* @param \Unikorp\KongAdminApi\Document\ApiDocument $document
78			*
79			* @return \Psr\Http\Message\ResponseInterface
80			*/
81	2		public function updateOrCreateApi(Document $document): ResponseInterface
82			{
83	2		return $this->put('/apis/', $document);
84			}
85
86			/**
87			* delete api
88			*
89			* @param string $nameOrId
90			*
91			* @return \Psr\Http\Message\ResponseInterface
92			*/
93	2		public function deleteApi(string $nameOrId): ResponseInterface
94			{
95	2		return $this->delete(sprintf('/apis/%1$s', $nameOrId));
96			}
97			}
98

unikorp / kong-admin-api

GitHub Access Token became invalid

Push — master ( 861dcb...319287 )

ApiNode A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like