Client - Code Metrics - Inspection of "feat(client): create http client" - unikorp/kong-admin-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by VEBER

created 2017-01-25 23:05 UTC

Client A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	9
lcom	1
cbo	11
dl	0
loc	90
rs	10
c	1
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	9	2
B	api()	19	5
A	addPlugin()	4	1
A	getHttpClient()	7	1

<?php

/*
 * This file is part of the KongAdminApi package.
 *
 * (c) Unikorp <https://github.com/unikorp>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Unikorp\KongAdminApi;

use Http\Client\Common\HttpMethodsClient;
use Http\Client\Common\Plugin;
use Http\Client\Common\PluginClient;
use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\UriFactoryDiscovery;
use Http\Message\MessageFactory;

/**
 * client
 *
 * @author VEBER Arnaud <https://github.com/VEBERArnaud>
 */
class Client
{
    /**
     * http client
     * @var \Http\Client\HttpClient $httpClient
     */
    private $httpClient = null;

    /**
     * message factory
     * @var \Http\Message\MessageFactory $messageFactory
     */
    private $messageFactory = null;

    /**
     * plugins
     * @var array $plugins
     */
    private $plugins = [];

    /**
     * constructor
     *
     * @param string $baseUri
     * @param \Http\Client\HttpClient $httpClient
     */
    public function __construct($baseUri, HttpClient $httpClient = null)
    {
        $this->httpClient = $httpClient ?: HttpClientDiscovery::find();
        $this->messageFactory = MessageFactoryDiscovery::find();

        $this->addPlugin(
            new Plugin\AddHostPlugin(UriFactoryDiscovery::find()->createUri($baseUri))
        );
    }

    /**
     * api
     *
     * @param string $name
     *
     * @return \Unikorp\KongAdminApi\ApiInterface
     *
     * @throws \InvalidArgumentException
     */
    public function api($name)
    {
        switch ($name) {
            case 'api':
                return new Api\Api($this);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'cluster':
                return new Api\Cluster($this);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'consumer':
                return new Api\Consumer($this);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'information':
                return new Api\Information($this);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                throw new \InvalidArgumentException(sprintf('Undefined api instance called: %s', $name));
        }
    }

    /**
     * add plugin
     *
     * @param \Http\Client\Common\Plugin $plugin
     *
     * @return void
     */
    public function addPlugin(Plugin $plugin)
    {
        $this->plugins[] = $plugin;
    }

    /**
     * get http client
     *
     * @return \Http\Client\Common\HttpMethodsClient
     */
    public function getHttpClient()
    {
        return new HttpMethodsClient(
            new PluginClient($this->httpClient, $this->plugins),
            $this->messageFactory
        );
    }
}


1			<?php
2
3			/*
4			* This file is part of the KongAdminApi package.
5			*
6			* (c) Unikorp <https://github.com/unikorp>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Unikorp\KongAdminApi;
13
14			use Http\Client\Common\HttpMethodsClient;
15			use Http\Client\Common\Plugin;
16			use Http\Client\Common\PluginClient;
17			use Http\Client\HttpClient;
18			use Http\Discovery\HttpClientDiscovery;
19			use Http\Discovery\MessageFactoryDiscovery;
20			use Http\Discovery\UriFactoryDiscovery;
21			use Http\Message\MessageFactory;
22
23			/**
24			* client
25			*
26			* @author VEBER Arnaud <https://github.com/VEBERArnaud>
27			*/
28			class Client
29			{
30			/**
31			* http client
32			* @var \Http\Client\HttpClient $httpClient
33			*/
34			private $httpClient = null;
35
36			/**
37			* message factory
38			* @var \Http\Message\MessageFactory $messageFactory
39			*/
40			private $messageFactory = null;
41
42			/**
43			* plugins
44			* @var array $plugins
45			*/
46			private $plugins = [];
47
48			/**
49			* constructor
50			*
51			* @param string $baseUri
52			* @param \Http\Client\HttpClient $httpClient
53			*/
54			public function __construct($baseUri, HttpClient $httpClient = null)
55			{
56			$this->httpClient = $httpClient ?: HttpClientDiscovery::find();
57			$this->messageFactory = MessageFactoryDiscovery::find();
58
59			$this->addPlugin(
60			new Plugin\AddHostPlugin(UriFactoryDiscovery::find()->createUri($baseUri))
61			);
62			}
63
64			/**
65			* api
66			*
67			* @param string $name
68			*
69			* @return \Unikorp\KongAdminApi\ApiInterface
70			*
71			* @throws \InvalidArgumentException
72			*/
73			public function api($name)
74			{
75			switch ($name) {
76			case 'api':
77			return new Api\Api($this);
78			break;
			0 ignored issues – show Unused Code introduced 2017-01-25 22:21 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
79			case 'cluster':
80			return new Api\Cluster($this);
81			break;
			0 ignored issues – show Unused Code introduced 2017-01-25 22:21 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
82			case 'consumer':
83			return new Api\Consumer($this);
84			break;
			0 ignored issues – show Unused Code introduced 2017-01-25 22:21 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
85			case 'information':
86			return new Api\Information($this);
87			break;
			0 ignored issues – show Unused Code introduced 2017-01-25 22:21 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
88			default:
89			throw new \InvalidArgumentException(sprintf('Undefined api instance called: %s', $name));
90			}
91			}
92
93			/**
94			* add plugin
95			*
96			* @param \Http\Client\Common\Plugin $plugin
97			*
98			* @return void
99			*/
100			public function addPlugin(Plugin $plugin)
101			{
102			$this->plugins[] = $plugin;
103			}
104
105			/**
106			* get http client
107			*
108			* @return \Http\Client\Common\HttpMethodsClient
109			*/
110			public function getHttpClient()
111			{
112			return new HttpMethodsClient(
113			new PluginClient($this->httpClient, $this->plugins),
114			$this->messageFactory
115			);
116			}
117			}
118

unikorp / kong-admin-api

GitHub Access Token became invalid

Pull Request — master (#2)

Client A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like