Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
23 | View Code Duplication | class CertificateNode extends AbstractNode |
|
|
|||
24 | { |
||
25 | /** |
||
26 | * add certificate |
||
27 | * |
||
28 | * @param \Unikorp\KongAdminApi\Document\CertificateDocument $document |
||
29 | * |
||
30 | * @return \Psr\Http\Message\ResponseInterface |
||
31 | */ |
||
32 | 2 | public function addCertificate(Document $document): ResponseInterface |
|
36 | |||
37 | /** |
||
38 | * retrieve certificate |
||
39 | * |
||
40 | * @param string $sniOrId |
||
41 | * |
||
42 | * @return \Psr\Http\Message\ResponseInterface |
||
43 | */ |
||
44 | 2 | public function retrieveCertificate(string $sniOrId): ResponseInterface |
|
48 | |||
49 | /** |
||
50 | * list certificates |
||
51 | * |
||
52 | * @return \Psr\Http\Message\ResponseInterface |
||
53 | */ |
||
54 | 2 | public function listCertificates(): ResponseInterface |
|
58 | |||
59 | /** |
||
60 | * update certificate |
||
61 | * |
||
62 | * @param string $sniOrId |
||
63 | * @param \Unikorp\KongAdminApi\Document\CertificateDocument $document |
||
64 | * |
||
65 | * @return \Psr\Http\Message\ResponseInterface |
||
66 | */ |
||
67 | 2 | public function updateCertificate(string $sniOrId, Document $document): ResponseInterface |
|
71 | |||
72 | /** |
||
73 | * update or create certificate |
||
74 | * |
||
75 | * @param \Unikorp\KongAdminApi\Document\CertificateDocument $document |
||
76 | * |
||
77 | * @return \Psr\Http\Message\ResponseInterface |
||
78 | */ |
||
79 | 2 | public function updateOrCreateCertificate(Document $document): ResponseInterface |
|
83 | |||
84 | /** |
||
85 | * delete certificate |
||
86 | * |
||
87 | * @param string $sniOrId |
||
88 | * |
||
89 | * @return \Psr\Http\Message\ResponseInterface |
||
90 | */ |
||
91 | 2 | public function deleteCertificate(string $sniOrId): ResponseInterface |
|
95 | } |
||
96 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.