TransRef - Code Metrics - Inspection of "Merge pull request #7 from ugochimbo/ft-refactor-f..." - unicodeveloper/laravel-paystack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 26a60f...9314aa )

by PROSPER

created 2016-06-26 02:54 UTC

TransRef A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
wmc	12
c	4
b	0
f	1
lcom	0
cbo	0
dl	0
loc	78
rs	10

3 Methods

Rating	Name	Size	Complexity
C	getPool()	28	7
A	secureCrypt()	19	3
A	getHashedToken()	10	2

<?php

/*
 * This file is part of the Laravel Paystack package.
 *
 * (c) Prosper Otemuyiwa <[email protected]>
 *
 * Source http://stackoverflow.com/a/13733588/179104
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Unicodeveloper\Paystack;

class TransRef
{
    /**
     * Get the pool to use based on the type of prefix hash
     * @param  string $type
     * @return string
     */
    private static function getPool($type = 'alnum')
    {
        switch ($type) {
            case 'alnum':
                $pool = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
                break;
            case 'alpha':
                $pool = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
                break;
            case 'hexdec':
                $pool = '0123456789abcdef';
                break;
            case 'numeric':
                $pool = '0123456789';
                break;
            case 'nozero':
                $pool = '123456789';
                break;
            case 'distinct':
                $pool = '2345679ACDEFHJKLMNPRSTUVWXYZ';
                break;
            default:
                $pool = (string) $type;
                break;
        }

        return $pool;
    }

    /**
     * Generate a random secure crypt figure
     * @param  integer $min
     * @param  integer $max
     * @return integer
     */
    private static function secureCrypt($min, $max)
    {
        $range = $max - $min;

        if ($range < 0) {
            return $min; // not so random...
        }

        $log    = log($range, 2);
        $bytes  = (int) ($log / 8) + 1; // length in bytes
        $bits   = (int) $log + 1; // length in bits
        $filter = (int) (1 << $bits) - 1; // set all lower bits to 1
        do {
            $rnd = hexdec(bin2hex(openssl_random_pseudo_bytes($bytes)));
            $rnd = $rnd & $filter; // discard irrelevant bits
        } while ($rnd >= $range);

        return $min + $rnd;
    }

    /**
     * Finally, generate a hashed token
     * @param  integer $length
     * @return string
     */
    public static function getHashedToken($length = 25)
    {
        $token = "";
        $max   = strlen(static::getPool());
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        for ($i = 0; $i < $length; $i++) {
            $token .= static::getPool()[static::secureCrypt(0, $max)];
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        }

        return $token;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Laravel Paystack package.
5			*
6			* (c) Prosper Otemuyiwa <[email protected]>
7			*
8			* Source http://stackoverflow.com/a/13733588/179104
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Unicodeveloper\Paystack;
15
16			class TransRef
17			{
18			/**
19			* Get the pool to use based on the type of prefix hash
20			* @param string $type
21			* @return string
22			*/
23			private static function getPool($type = 'alnum')
24			{
25			switch ($type) {
26			case 'alnum':
27			$pool = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
28			break;
29			case 'alpha':
30			$pool = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
31			break;
32			case 'hexdec':
33			$pool = '0123456789abcdef';
34			break;
35			case 'numeric':
36			$pool = '0123456789';
37			break;
38			case 'nozero':
39			$pool = '123456789';
40			break;
41			case 'distinct':
42			$pool = '2345679ACDEFHJKLMNPRSTUVWXYZ';
43			break;
44			default:
45			$pool = (string) $type;
46			break;
47			}
48
49			return $pool;
50			}
51
52			/**
53			* Generate a random secure crypt figure
54			* @param integer $min
55			* @param integer $max
56			* @return integer
57			*/
58			private static function secureCrypt($min, $max)
59			{
60			$range = $max - $min;
61
62			if ($range < 0) {
63			return $min; // not so random...
64			}
65
66			$log = log($range, 2);
67			$bytes = (int) ($log / 8) + 1; // length in bytes
68			$bits = (int) $log + 1; // length in bits
69			$filter = (int) (1 << $bits) - 1; // set all lower bits to 1
70			do {
71			$rnd = hexdec(bin2hex(openssl_random_pseudo_bytes($bytes)));
72			$rnd = $rnd & $filter; // discard irrelevant bits
73			} while ($rnd >= $range);
74
75			return $min + $rnd;
76			}
77
78			/**
79			* Finally, generate a hashed token
80			* @param integer $length
81			* @return string
82			*/
83			public static function getHashedToken($length = 25)
84			{
85			$token = "";
86			$max = strlen(static::getPool());
			0 ignored issues – show Bug introduced 2016-02-01 06:56 UTC by Report Bug Copy Issue Report Since `getPool()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `getPool()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
87			for ($i = 0; $i < $length; $i++) {
88			$token .= static::getPool()[static::secureCrypt(0, $max)];
			0 ignored issues – show Bug introduced 2016-02-01 06:56 UTC by Report Bug Copy Issue Report Since `getPool()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `getPool()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history... Bug introduced 2016-06-25 10:37 UTC by Report Bug Copy Issue Report Since `secureCrypt()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `secureCrypt()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
89			}
90
91			return $token;
92			}
93			}
94

unicodeveloper / laravel-paystack

Push — master ( 26a60f...9314aa )

TransRef A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like