Conditions | 10 |
Paths | 30 |
Total Lines | 43 |
Code Lines | 31 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
46 | public function analyze($sequence) |
||
47 | { |
||
48 | $numberOfWrittenFiles = 0; |
||
49 | $numberOfDeletedFiles = 0; |
||
50 | $numberOfRenamedFiles = 0; |
||
51 | |||
52 | $sequenceClass = self::NO_WRITE_AND_DELETE; |
||
53 | |||
54 | foreach ($sequence as $fileOperation) { |
||
55 | switch ($fileOperation->getCommand()) { |
||
56 | case Monitor::WRITE: |
||
57 | $numberOfWrittenFiles++; |
||
58 | break; |
||
59 | case Monitor::READ: |
||
60 | break; |
||
61 | case Monitor::RENAME: |
||
62 | $numberOfRenamedFiles++; |
||
63 | break; |
||
64 | case Monitor::DELETE: |
||
65 | $numberOfDeletedFiles++; |
||
66 | break; |
||
67 | default: |
||
68 | break; |
||
69 | } |
||
70 | } |
||
71 | |||
72 | if ($numberOfWrittenFiles > 0) { |
||
73 | if ($numberOfDeletedFiles > 0) { |
||
74 | if ($numberOfWrittenFiles === $numberOfDeletedFiles) { |
||
75 | $sequenceClass = self::EQUAL_WRITE_AND_DELETE; |
||
76 | } else { |
||
77 | $sequenceClass = self::DIFF_WRITE_AND_DELETE; |
||
78 | } |
||
79 | } else { |
||
80 | $sequenceClass = self::ONLY_WRITE; |
||
81 | } |
||
82 | } else { |
||
83 | if ($numberOfDeletedFiles > 0) { |
||
84 | $sequenceClass = self::ONLY_DELETE; |
||
85 | } |
||
86 | } |
||
87 | |||
88 | return $sequenceClass; |
||
89 | } |
||
91 |