Completed
Pull Request — master (#22)
by Aivis
05:20 queued 27s
created
src/Understand/UnderstandLaravel5/UnderstandLaravel5ServiceProvider.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -218,8 +218,8 @@  discard block
 block discarded – undo
218 218
     /**
219 219
      * Detect Laravel version
220 220
      * 
221
-     * @param array $versions
222
-     * @return type
221
+     * @param string[] $versions
222
+     * @return boolean
223 223
      */
224 224
     protected function detectLaravelVersion(array $versions)
225 225
     {
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
     /**
341 341
      * Get the services provided by the provider.
342 342
      *
343
-     * @return array
343
+     * @return string[]
344 344
      */
345 345
     public function provides()
346 346
     {
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -237,8 +237,7 @@  discard block
 block discarded – undo
237 237
             {
238 238
                 $this->handleEvent($level, $message, $context);
239 239
             });
240
-        }
241
-        else
240
+        } else
242 241
         {
243 242
             // starting from L5.4 MessageLogged event class was introduced
244 243
             // https://github.com/laravel/framework/commit/57c82d095c356a0fe0f9381536afec768cdcc072
@@ -268,8 +267,7 @@  discard block
 block discarded – undo
268 267
                     'time' => $time,
269 268
                 ]);
270 269
             });
271
-        }
272
-        else
270
+        } else
273 271
         {
274 272
             // https://laravel.com/api/5.3/Illuminate/Database/Events/QueryExecuted.html
275 273
             $this->app['events']->listen('Illuminate\Database\Events\QueryExecuted', function($event)
Please login to merge, or discard this patch.
src/Understand/UnderstandLaravel5/ExceptionEncoder.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
     }
158 158
 
159 159
     /**
160
-     * @param $relativePath
160
+     * @param string|null $relativePath
161 161
      * @param $line
162 162
      * @param int $linesAround
163 163
      * @return array|void
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
      * Return stack trace file
218 218
      *
219 219
      * @param array $trace
220
-     * @return mixed
220
+     * @return string|null
221 221
      */
222 222
     protected function getStackTraceFile(array $trace)
223 223
     {
Please login to merge, or discard this patch.
Braces   +9 added lines, -18 removed lines patch added patch discarded remove patch
@@ -107,8 +107,7 @@  discard block
 block discarded – undo
107 107
             if (strpos($trace['file'], $this->projectRoot . 'vendor' . DIRECTORY_SEPARATOR) === 0)
108 108
             {
109 109
                 unset($stackTrace[$index]);
110
-            }
111
-            else
110
+            } else
112 111
             {
113 112
                 $vendorExcluded = true;
114 113
             }
@@ -194,8 +193,7 @@  discard block
 block discarded – undo
194 193
             }
195 194
 
196 195
             return $codeLines;
197
-        }
198
-        catch (\Exception $e)
196
+        } catch (\Exception $e)
199 197
         {}
200 198
     }
201 199
 
@@ -271,32 +269,25 @@  discard block
 block discarded – undo
271 269
             if (is_array($arg))
272 270
             {
273 271
                 $params[] = 'array(' . count($arg) . ')';
274
-            }
275
-            else if (is_object($arg))
272
+            } else if (is_object($arg))
276 273
             {
277 274
                 $params[] = get_class($arg);
278
-            }
279
-            else if (is_string($arg))
275
+            } else if (is_string($arg))
280 276
             {
281 277
                 $params[] = 'string(' . $arg . ')';
282
-            }
283
-            else if (is_int($arg))
278
+            } else if (is_int($arg))
284 279
             {
285 280
                 $params[] = 'int(' . $arg . ')';
286
-            }
287
-            else if (is_float($arg))
281
+            } else if (is_float($arg))
288 282
             {
289 283
                 $params[] = 'float(' . $arg . ')';
290
-            }
291
-            else if (is_bool($arg))
284
+            } else if (is_bool($arg))
292 285
             {
293 286
                 $params[] = 'bool(' . ($arg ? 'true' : 'false') . ')';
294
-            }
295
-            else if ($arg instanceof \__PHP_Incomplete_Class)
287
+            } else if ($arg instanceof \__PHP_Incomplete_Class)
296 288
             {
297 289
                 $params[] = 'object(__PHP_Incomplete_Class)'; 
298
-            }
299
-            else
290
+            } else
300 291
             {
301 292
                 $params[] = gettype($arg);
302 293
             }
Please login to merge, or discard this patch.
src/Understand/UnderstandLaravel5/FieldProvider.php 2 patches
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     protected $app;
88 88
 
89 89
     /**
90
-     * @return void
90
+     * @return Application
91 91
      */
92 92
     public function __construct()
93 93
     {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     /**
109 109
      * Set session store
110 110
      *
111
-     * @param type $service
111
+     * @param SessionStore $service
112 112
      */
113 113
     public function setSessionStore(SessionStore $service)
114 114
     {
@@ -157,7 +157,6 @@  discard block
 block discarded – undo
157 157
      * Register a custom HTML macro.
158 158
      *
159 159
      * @param string $name
160
-     * @param  mixed  $macro
161 160
      * @return void
162 161
      */
163 162
     public function extend($name, $provider)
@@ -168,7 +167,7 @@  discard block
 block discarded – undo
168 167
     /**
169 168
      * Set token provider
170 169
      *
171
-     * @param UniqueProcessIdentifier $tokenProvider
170
+     * @param TokenProvider $tokenProvider
172 171
      */
173 172
     public function setTokenProvider(TokenProvider $tokenProvider)
174 173
     {
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -423,8 +423,7 @@  discard block
 block discarded – undo
423 423
             {
424 424
                 return $userId;
425 425
             }
426
-        }
427
-        catch (\Exception $e)
426
+        } catch (\Exception $e)
428 427
         {}
429 428
 
430 429
         try
@@ -433,8 +432,7 @@  discard block
 block discarded – undo
433 432
             {
434 433
                 return $user->id;
435 434
             }
436
-        }
437
-        catch (\Exception $e)
435
+        } catch (\Exception $e)
438 436
         {}
439 437
 
440 438
         try
@@ -443,8 +441,7 @@  discard block
 block discarded – undo
443 441
             {
444 442
                 return $user->id;
445 443
             }
446
-        }
447
-        catch (\Exception $e)
444
+        } catch (\Exception $e)
448 445
         {}
449 446
     }
450 447
 
Please login to merge, or discard this patch.
src/Understand/UnderstandLaravel5/Logger.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@  discard block
 block discarded – undo
28 28
     /**
29 29
      * @param FieldProvider $fieldProvider
30 30
      * @param BaseHandler $handler
31
-     * @param bool $silent
32 31
      */
33 32
     public function __construct(FieldProvider $fieldProvider, BaseHandler $handler)
34 33
     {
@@ -144,7 +143,6 @@  discard block
 block discarded – undo
144 143
     /**
145 144
      * Send data to storage
146 145
      *
147
-     * @param array $requestData
148 146
      * @return mixed
149 147
      */
150 148
     protected function send(array $event)
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,8 +152,7 @@
 block discarded – undo
152 152
         try
153 153
         {
154 154
             return $this->handler->handle($event);
155
-        }
156
-        catch (\Exception $ex)
155
+        } catch (\Exception $ex)
157 156
         {
158 157
             return false;
159 158
         }
Please login to merge, or discard this patch.
src/Understand/UnderstandLaravel5/ExceptionLogger.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,8 +90,7 @@
 block discarded – undo
90 90
             ];
91 91
 
92 92
             $log = $this->encoder->setCurrentStackTrace($log);
93
-        }
94
-        else
93
+        } else
95 94
         {
96 95
             $log = (array)$message;
97 96
             $log = $this->encoder->setCurrentStackTrace($log);
Please login to merge, or discard this patch.
src/Understand/UnderstandLaravel5/EventLogger.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,8 +45,7 @@
 block discarded – undo
45 45
             $log = [
46 46
                 'message' => $message
47 47
             ];
48
-        }
49
-        else
48
+        } else
50 49
         {
51 50
             $log = (array)$message;
52 51
         }
Please login to merge, or discard this patch.