Controller - Code Metrics - Inspection of "Merge pull request #76 from undefinedio/feature/pa..." - undefinedio/stash - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 078d1e...95441f )

unknown

created 2017-02-09 15:50 UTC

Controller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	112
rs	10
c	1
b	0
f	1
wmc	15
lcom	1
cbo	2

8 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	Instance()	9	2
A	setPages()	4	1
A	setContext()	6	1
A	returnId()	8	2
B	page()	31	5
A	returnDefault()	6	1
A	getClass()	8	2

<?php
namespace Undefined\Stash;

use Timber\Timber;
use Timber\Post as TimberPost;

final class Controller
{
    /**
     * Controller constructor.
     *
     * Set context and fetch post id
     */
    function __construct()

    {
        $this->found = false;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * make singleton
     *
     * @return null|Controller
     */
    public static function Instance()
    {
        static $inst = null;
        if ($inst === null) {
            $inst = new Controller();
        }

        return $inst;
    }

    /**
     * Set all pages from within the functions.php->setControllers()
     *
     * @param $pages
     */
    public function setPages($pages)
    {
        $this->pages = $pages;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Set context for the page
     */
    private function setContext()
    {
        $this->postId = get_the_ID();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->context = Timber::get_context();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->context['post'] = new TimberPost();
    }

    private function returnId($key)
    {
        if (function_exists('pll_get_post')) {
            return pll_get_post($key);
        } else {
            return $key;
        }
    }

    public function page()
    {
        /**
         * Loop though set pages in functions.php->setControllers()
         */
        foreach ($this->pages as $key => $page) {

            if (get_the_ID() == $this->returnId($key)) {
                /**
                 * See if controller excists else fall back to default
                 */
                $file = get_template_directory() . '/controllers/' . $page . '.php';
                if (file_exists($file)) {
                    $this->found = $page;

                    $this->setContext();
                    /**
                     * Set context for included file
                     */
                    $context = $this->context;

                    include($file);
                }
            }
        }

        if (!$this->found) {
            $this->found = 'default';
            $this->returnDefault();
        }
    }

    /**
     * Fallback when no controller found or controller file isn't present
     */
    private function returnDefault()
    {
        $this->setContext();
        $context = $this->context;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        Timber::render(['page-' . $this->context['post']->post_name . '.twig', 'page.twig'], $this->context, Cache::getTimerTime());
    }

    /**
     * Return name of the body class
     *
     * @return bool|string
     */
    public function getClass()
    {
        if ($this->found) {
            return 'page-' . $this->found;
        } else {
            return false;
        }
    }
}

1			<?php
2			namespace Undefined\Stash;
3
4			use Timber\Timber;
5			use Timber\Post as TimberPost;
6
7			final class Controller
8			{
9			/**
10			* Controller constructor.
11			*
12			* Set context and fetch post id
13			*/
14			function __construct()
			0 ignored issues – show Best Practice introduced 2017-02-09 15:21 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
15			{
16			$this->found = false;
			0 ignored issues – show Bug introduced 2017-02-09 15:21 UTC by Report Bug Copy Issue Report The property `found` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17			}
18
19			/**
20			* make singleton
21			*
22			* @return null\|Controller
23			*/
24			public static function Instance()
25			{
26			static $inst = null;
27			if ($inst === null) {
28			$inst = new Controller();
29			}
30
31			return $inst;
32			}
33
34			/**
35			* Set all pages from within the functions.php->setControllers()
36			*
37			* @param $pages
38			*/
39			public function setPages($pages)
40			{
41			$this->pages = $pages;
			0 ignored issues – show Bug introduced 2017-02-09 15:21 UTC by Report Bug Copy Issue Report The property `pages` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42			}
43
44			/**
45			* Set context for the page
46			*/
47			private function setContext()
48			{
49			$this->postId = get_the_ID();
			0 ignored issues – show Bug introduced 2017-02-09 15:21 UTC by Report Bug Copy Issue Report The property `postId` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50			$this->context = Timber::get_context();
			0 ignored issues – show Bug introduced 2017-02-09 15:21 UTC by Report Bug Copy Issue Report The property `context` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51			$this->context['post'] = new TimberPost();
52			}
53
54			private function returnId($key)
55			{
56			if (function_exists('pll_get_post')) {
57			return pll_get_post($key);
58			} else {
59			return $key;
60			}
61			}
62
63			public function page()
64			{
65			/**
66			* Loop though set pages in functions.php->setControllers()
67			*/
68			foreach ($this->pages as $key => $page) {
69
70			if (get_the_ID() == $this->returnId($key)) {
71			/**
72			* See if controller excists else fall back to default
73			*/
74			$file = get_template_directory() . '/controllers/' . $page . '.php';
75			if (file_exists($file)) {
76			$this->found = $page;
77
78			$this->setContext();
79			/**
80			* Set context for included file
81			*/
82			$context = $this->context;
83
84			include($file);
85			}
86			}
87			}
88
89			if (!$this->found) {
90			$this->found = 'default';
91			$this->returnDefault();
92			}
93			}
94
95			/**
96			* Fallback when no controller found or controller file isn't present
97			*/
98			private function returnDefault()
99			{
100			$this->setContext();
101			$context = $this->context;
			0 ignored issues – show Unused Code introduced 2017-02-09 15:21 UTC by Report Bug Copy Issue Report `$context` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
102			Timber::render(['page-' . $this->context['post']->post_name . '.twig', 'page.twig'], $this->context, Cache::getTimerTime());
103			}
104
105			/**
106			* Return name of the body class
107			*
108			* @return bool\|string
109			*/
110			public function getClass()
111			{
112			if ($this->found) {
113			return 'page-' . $this->found;
114			} else {
115			return false;
116			}
117			}
118			}

undefinedio / stash

GitHub Access Token became invalid

Push — master ( 078d1e...95441f )

Controller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like