Undefined\Stash\Controller

Complexity

Total Complexity

20

Size/Duplication

Total Lines	157
Duplicated Lines	21.66 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	Instance()	0	9	2
A	setPages()	0	4	1
A	setContext()	0	6	1
A	returnId()	0	8	2
A	single()	17	17	2
A	fourOFour()	0	4	1
A	archive()	17	17	2
B	page()	0	30	5
A	returnDefault()	0	6	1
A	getClass()	0	8	2

<?php
namespace Undefined\Stash;

use Timber\Timber;
use Timber\Post as TimberPost;

final class Controller
{
    /**
     * Controller constructor.
     *
     * Set context and fetch post id
     */
    function __construct()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->found = false;

The property found does not exist. Did you maybe forget to declare it?

    }

    /**
     * make singleton
     *
     * @return null|Controller
     */
    public static function Instance()
    {
        static $inst = null;
        if ($inst === null) {
            $inst = new Controller();
        }

        return $inst;
    }

    /**
     * Set all pages from within the functions.php->setControllers()
     *
     * @param $pages
     */
    public function setPages($pages)
    {
        $this->pages = $pages;

The property pages does not exist. Did you maybe forget to declare it?

    }

    /**
     * Set context for the page
     */
    private function setContext()
    {
        $this->postId = get_the_ID();

The property postId does not exist. Did you maybe forget to declare it?

        $this->context = Timber::get_context();

The property context does not exist. Did you maybe forget to declare it?

        $this->context['post'] = new TimberPost();
    }

    private function returnId($key)
    {
        if (function_exists('pll_get_post')) {
            return pll_get_post($key);
        } else {
            return $key;
        }
    }

    /**
     * Find the correct controller for the single post object
     *
     * If none controller is found, fallback on teh default post
     */
    public function single()

This method seems to be duplicated in your project.

    {
        $this->setContext();

        $context = $this->context;

        $file = get_template_directory() . '/controllers/single/' . $this->context['post']->post_type . '.php';

        if (file_exists($file)) {
            /**
             * Set context for included file
             */
            include($file);
        } else {
            Timber::render(array('single-' . $context['post']->ID . '.twig', 'single-' . $context['post']->post_type . '.twig', 'single.twig'), $context, Cache::getTimerTime());
        }
    }

    public function fourOFour()
    {
        include(get_template_directory() . '/controllers/404.php');
    }

    public function archive()

This method seems to be duplicated in your project.

    {
        $this->setContext();

        $context = $this->context;

        $file = get_template_directory() . '/controllers/archive/' . $this->context['post']->post_type . '.php';

        if (file_exists($file)) {
            /**
             * Set context for included file
             */
            include($file);
        } else {
            Timber::render(array('single-' . $context['post']->ID . '.twig', 'single-' . $context['post']->post_type . '.twig', 'single.twig'), $context, Cache::getTimerTime());
        }
    }

    public function page()
    {
        /**
         * Loop though set pages in functions.php->setControllers()
         */
        foreach ($this->pages as $key => $page) {
            if (get_the_ID() == $this->returnId($key)) {
                /**
                 * See if controller excists else fall back to default
                 */
                $file = get_template_directory() . '/controllers/pages/' . $page . '.php';
                if (file_exists($file)) {
                    $this->found = $page;

                    $this->setContext();
                    /**
                     * Set context for included file
                     */
                    $context = $this->context;

                    include($file);
                }
            }
        }

        if (!$this->found) {
            $this->found = 'default';
            $this->returnDefault();
        }
    }

    /**
     * Fallback when no controller found or controller file isn't present
     */
    private function returnDefault()
    {
        $this->setContext();
        $context = $this->context;

$context is not used, you could remove the assignment.

        Timber::render(['page-' . $this->context['post']->post_name . '.twig', 'page.twig'], $this->context, Cache::getTimerTime());
    }

    /**
     * Return name of the body class
     *
     * @return bool|string
     */
    public function getClass()
    {
        if ($this->found) {
            return 'page-' . $this->found;
        } else {
            return false;
        }
    }
}