ACF::advanced_custom_search() - Code Metrics - undefinedio/stash - Measure and Improve Code Quality continuously with Scrutinizer

ACF::advanced_custom_search() B
last analyzed 2019-03-28 15:13 UTC

↳ Parent: ACF

Complexity

Conditions	7
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
nc	9
nop	2
dl	0
loc	68
rs	7.7648
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Undefined\Stash\ACF;

/**
 * Get paths for assets
 */
class ACF
{
    function __construct()

    {
        $this->list_searcheable_acf = array("title", "sub_title", "excerpt_short", "excerpt_long", "xyz", "myACF");
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (!class_exists('acf')) {
            add_filter('posts_search', [$this, 'advanced_custom_search'], 500, 2);
        }
    }

    /**
     * Make ACF fields searchable
     *
     * @param $where
     * @param $wp_query
     * @return string
     */
    public function advanced_custom_search($where, &$wp_query)
    {
        global $wpdb;

        if (empty($where)) {
            return $where;
        }

        // get search expression
        $terms = $wp_query->query_vars['s'];

        // explode search expression to get search terms
        $exploded = explode(' ', $terms);

        if ($exploded === false || count($exploded) == 0) {
            $exploded = array(0 => $terms);
        }

        // reset search in order to rebuilt it as we whish
        $where = '';

        // get searcheable_acf, a list of advanced custom fields you want to search content in
        $list_searcheable_acf = $this->list_searcheable_acf;

        foreach ($exploded as $tag) {
            $where .= "
          AND (
            (wp_posts.post_title LIKE '%$tag%')
            OR (wp_posts.post_content LIKE '%$tag%')
            OR EXISTS (
              SELECT * FROM wp_postmeta
	              WHERE post_id = wp_posts.ID
	                AND (";

            foreach ($list_searcheable_acf as $searcheable_acf) {
                if ($searcheable_acf == $list_searcheable_acf[0]) {
                    $where .= " (meta_key LIKE '%" . $searcheable_acf . "%' AND meta_value LIKE '%$tag%') ";
                } else {
                    $where .= " OR (meta_key LIKE '%" . $searcheable_acf . "%' AND meta_value LIKE '%$tag%') ";
                }

                $where .= ")
            )
            OR EXISTS (
              SELECT * FROM wp_comments
              WHERE comment_post_ID = wp_posts.ID
                AND comment_content LIKE '%$tag%'
            )
            OR EXISTS (
              SELECT * FROM wp_terms
              INNER JOIN wp_term_taxonomy
                ON wp_term_taxonomy.term_id = wp_terms.term_id
              INNER JOIN wp_term_relationships
                ON wp_term_relationships.term_taxonomy_id = wp_term_taxonomy.term_taxonomy_id
              WHERE (
          		taxonomy = 'post_tag'
            		OR taxonomy = 'category'
            		OR taxonomy = 'myCustomTax'
          		)
              	AND object_id = wp_posts.ID
              	AND wp_terms.name LIKE '%$tag%'
            )
        )";
            }

            return $where;
        }
    }
}

add_action('init', function () {
    $acf = new ACF();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
});

1			<?php
2
3			namespace Undefined\Stash\ACF;
4
5			/**
6			* Get paths for assets
7			*/
8			class ACF
9			{
10			function __construct()
			0 ignored issues – show Best Practice introduced 2016-09-16 13:34 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			{
12			$this->list_searcheable_acf = array("title", "sub_title", "excerpt_short", "excerpt_long", "xyz", "myACF");
			0 ignored issues – show Bug introduced 2016-09-16 13:34 UTC by Report Bug Copy Issue Report The property `list_searcheable_acf` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13
14			if (!class_exists('acf')) {
15			add_filter('posts_search', [$this, 'advanced_custom_search'], 500, 2);
16			}
17			}
18
19			/**
20			* Make ACF fields searchable
21			*
22			* @param $where
23			* @param $wp_query
24			* @return string
25			*/
26			public function advanced_custom_search($where, &$wp_query)
27			{
28			global $wpdb;
29
30			if (empty($where)) {
31			return $where;
32			}
33
34			// get search expression
35			$terms = $wp_query->query_vars['s'];
36
37			// explode search expression to get search terms
38			$exploded = explode(' ', $terms);
39
40			if ($exploded === false \|\| count($exploded) == 0) {
41			$exploded = array(0 => $terms);
42			}
43
44			// reset search in order to rebuilt it as we whish
45			$where = '';
46
47			// get searcheable_acf, a list of advanced custom fields you want to search content in
48			$list_searcheable_acf = $this->list_searcheable_acf;
49
50			foreach ($exploded as $tag) {
51			$where .= "
52			AND (
53			(wp_posts.post_title LIKE '%$tag%')
54			OR (wp_posts.post_content LIKE '%$tag%')
55			OR EXISTS (
56			SELECT * FROM wp_postmeta
57			WHERE post_id = wp_posts.ID
58			AND (";
59
60			foreach ($list_searcheable_acf as $searcheable_acf) {
61			if ($searcheable_acf == $list_searcheable_acf[0]) {
62			$where .= " (meta_key LIKE '%" . $searcheable_acf . "%' AND meta_value LIKE '%$tag%') ";
63			} else {
64			$where .= " OR (meta_key LIKE '%" . $searcheable_acf . "%' AND meta_value LIKE '%$tag%') ";
65			}
66
67			$where .= ")
68			)
69			OR EXISTS (
70			SELECT * FROM wp_comments
71			WHERE comment_post_ID = wp_posts.ID
72			AND comment_content LIKE '%$tag%'
73			)
74			OR EXISTS (
75			SELECT * FROM wp_terms
76			INNER JOIN wp_term_taxonomy
77			ON wp_term_taxonomy.term_id = wp_terms.term_id
78			INNER JOIN wp_term_relationships
79			ON wp_term_relationships.term_taxonomy_id = wp_term_taxonomy.term_taxonomy_id
80			WHERE (
81			taxonomy = 'post_tag'
82			OR taxonomy = 'category'
83			OR taxonomy = 'myCustomTax'
84			)
85			AND object_id = wp_posts.ID
86			AND wp_terms.name LIKE '%$tag%'
87			)
88			)";
89			}
90
91			return $where;
92			}
93			}
94			}
95
96			add_action('init', function () {
97			$acf = new ACF();
			0 ignored issues – show Unused Code introduced 2016-09-16 13:34 UTC by Report Bug Copy Issue Report `$acf` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98			});

undefinedio / stash

GitHub Access Token became invalid

ACF::advanced_custom_search() B last analyzed 2019-03-28 15:13 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ACF::advanced_custom_search() B
last analyzed 2019-03-28 15:13 UTC