QueryExtractor::current() - Code Metrics - Inspection of "Adding Doctrine examples" - umpirsky/Extraload - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

unknown

created 2018-04-21 22:16 UTC

QueryExtractor::current() A

↳ Parent: QueryExtractor

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Extraload\Extractor\Doctrine;

use Doctrine\DBAL\Connection;
use Extraload\Extractor\ExtractorInterface;

class QueryExtractor implements ExtractorInterface
{
    private $position = 0;

    private $data;

    public function __construct(Connection $conn, string $sql)
    {
        $this->position = 0;
        $this->data = $conn->query($sql)->fetchAll();
    }

    public function extract()

    {
        if ($this->position >= count($this->data)) {
            return;
        }

        $data = $this->current();

        $this->next();

        return $data;
    }

    public function current()
    {
        return $this->data[$this->position];
    }

    public function key()
    {
        return $this->position;
    }

    public function next()
    {
        $this->position += 1;
    }

    public function rewind()
    {
        $this->position = 0;
    }

    public function valid()
    {
        return isset($this->data[$this->position]);
    }
}


1		<?php
2
3		namespace Extraload\Extractor\Doctrine;
4
5		use Doctrine\DBAL\Connection;
6		use Extraload\Extractor\ExtractorInterface;
7
8		class QueryExtractor implements ExtractorInterface
9		{
10		private $position = 0;
11
12		private $data;
13
14		public function __construct(Connection $conn, string $sql)
15		{
16		$this->position = 0;
17		$this->data = $conn->query($sql)->fetchAll();
18		}
19
20	View Code Duplication	public function extract()
		0 ignored issues – show Duplication introduced 2018-04-21 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		if ($this->position >= count($this->data)) {
23		return;
24		}
25
26		$data = $this->current();
27
28		$this->next();
29
30		return $data;
31		}
32
33		public function current()
34		{
35		return $this->data[$this->position];
36		}
37
38		public function key()
39		{
40		return $this->position;
41		}
42
43		public function next()
44		{
45		$this->position += 1;
46		}
47
48		public function rewind()
49		{
50		$this->position = 0;
51		}
52
53		public function valid()
54		{
55		return isset($this->data[$this->position]);
56		}
57		}
58

umpirsky / Extraload

Pull Request — master (#17)

QueryExtractor::current() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like