Umbrellio\TableSync\Integration\Laravel\Publishers\EnsureConsistencyPublisher

Complexity

Total Complexity

6

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

92.31%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	publish()	0	7	3
A	isRecordExists()	0	13	2
A	__construct()	0	3	1

<?php

declare(strict_types=1);

namespace Umbrellio\TableSync\Integration\Laravel\Publishers;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\App;
use Umbrellio\TableSync\Messages\PublishMessage;
use Umbrellio\TableSync\Publisher;

final class EnsureConsistencyPublisher implements Publisher
{
    private $publisher;

    public function __construct(Publisher $publisher)
    {
        $this->publisher = $publisher;
    }

    public function publish(PublishMessage $message): void
    {
        if (!$this->isRecordExists($message) && !$message->isDestroyed()) {
            return;
        }

        $this->publisher->publish($message);
    }

    private function isRecordExists(PublishMessage $message): bool
    {
        /** @var Model $model */
        $model = App::make($message->className());

        if (!isset($message->attributes()[$model->getKeyName()])) {
            return false;
        }

        return $model

The expression return $model->newQuery()->where($model->getKeyName(), $message->attributes()[$model->getKeyName()])->exists() could return the type Illuminate\Database\Eloquent\Builder which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

            ->newQuery()
            ->where($model->getKeyName(), $message->attributes()[$model->getKeyName()])
            ->exists();
    }
}