Umbrellio\LTree\Traits\HasTreeRelationships

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	belongsToTree()	0	24	4

<?php

declare(strict_types=1);

namespace Umbrellio\LTree\Traits;

use Illuminate\Database\Eloquent\Concerns\HasRelationships;
use Illuminate\Database\Eloquent\Model;
use Umbrellio\LTree\Exceptions\InvalidTraitInjectionClass;
use Umbrellio\LTree\Interfaces\LTreeModelInterface;
use Umbrellio\LTree\Relations\BelongsToTree;

/**
 * @mixin HasRelationships
 * @mixin LTreeModelTrait
 * @mixin Model
 */
trait HasTreeRelationships
{
    /**
     * @param null $ownerKey

Are you sure the doc-type for parameter $ownerKey is correct as it would always require null to be passed?

     * @return BelongsToTree
     *
     * @throws InvalidTraitInjectionClass
     */
    protected function belongsToTree(
        string $related,
        string $throwRelation,
        ?string $foreignKey = null,
        $ownerKey = null
    ) {
        $instance = $this->newRelatedInstance($related);

It seems like newRelatedInstance() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!$instance instanceof LTreeModelInterface) {
            throw new InvalidTraitInjectionClass(sprintf(
                'A class using this trait must implement an interface %s',
                LTreeModelInterface::class
            ));
        }

        if ($foreignKey === null) {
            $foreignKey = $this
                ->{$throwRelation}()
                ->getForeignKeyName();
        }

        $ownerKey = $ownerKey ?: $instance->getKeyName();

$ownerKey is of type null, thus it always evaluated to false.

        return new BelongsToTree($instance->newQuery(), $this, $throwRelation, $foreignKey, $ownerKey);

The method newQuery() does not exist on Umbrellio\LTree\Interfaces\LTreeModelInterface.

$this of type Umbrellio\LTree\Traits\HasTreeRelationships is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $child of Umbrellio\LTree\Relations\BelongsToTree::__construct().

    }
}