Umbrellio\LTree\Services\LTreeService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	dropDescendants()	0	5	1
A	updatePath()	0	6	1
A	__construct()	0	3	1
A	createPath()	0	3	1

<?php

declare(strict_types=1);

namespace Umbrellio\LTree\Services;

use Illuminate\Database\Eloquent\Model;
use Umbrellio\LTree\Helpers\LTreeHelper;
use Umbrellio\LTree\Interfaces\LTreeModelInterface;
use Umbrellio\LTree\Interfaces\LTreeServiceInterface;

final class LTreeService implements LTreeServiceInterface
{
    private $helper;

    public function __construct(LTreeHelper $helper)
    {
        $this->helper = $helper;
    }

    public function createPath(LTreeModelInterface $model): void
    {
        $this->helper->buildPath($model);
    }

    /**
     * @param LTreeModelInterface|Model $model
     */
    public function updatePath(LTreeModelInterface $model): void
    {
        $columns = array_intersect_key($model->getAttributes(), array_flip($model->getLtreeProxyUpdateColumns()));

The method getAttributes() does not exist on Umbrellio\LTree\Interfaces\LTreeModelInterface.

        $this->helper->moveNode($model, $model->ltreeParent, $columns);

Accessing ltreeParent on the interface Umbrellio\LTree\Interfaces\LTreeModelInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->buildPath($model);
    }

    /**
     * @param LTreeModelInterface|Model $model
     */
    public function dropDescendants(LTreeModelInterface $model): void
    {
        $columns = array_intersect_key($model->getAttributes(), array_flip($model->getLtreeProxyDeleteColumns()));

        $this->helper->dropDescendants($model, $columns);
    }
}