UserController::update() - Code Metrics - Inspection of "Merge pull request #133 from uidaho/default_rates" - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6e8adf...c24137 )

unknown

created 2017-12-06 04:32 UTC

UserController::update() B

↳ Parent: UserController

Complexity

Conditions	4
Paths	6

Size

Total Lines	32
Code Lines	23

Duplication

Lines	5
Ratio	15.63 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	23
c	2
b	0
f	0
nc	6
nop	2
dl	5
loc	32
ccs	0
cts	22
cp	0
crap	20
rs	8.5806

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\DataTables\UsersDataTable;
use App\User;

class UserController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display index page and process dataTable ajax request.
     *
     * @param \App\DataTables\UsersDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(UsersDataTable $dataTable)
    {
        $trashed = User::onlyTrashed()->get();
        return $dataTable->render('user.index', compact('trashed'));

    }

    /**
     * Show create user page.
     *
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
filter:
    dependency_paths: ["lib/*"]
     */
    public function create()
    {
        return view('user.create');
    }

    /**
     * Store a new user.
     *
     * @param  Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request)
    {
        request()->validate([
            'name' => 'required|min:2|max:190|full_name',
            'email' => 'required|string|email|max:255|unique:users',
            'password' => 'required|string|min:8|confirmed',
            'role' => 'required|integer|max:3',
            'phone' => 'numeric|phone|nullable',
        ]);

        $user = new User;

        $user->name = $request->input('name');
        $user->email = $request->input('email');
        $user->password = bcrypt($request->input('password'));
        $user->password = bcrypt(/** @scrutinizer ignore-type */ $request->input('password'));
        $user->role = $request->input('role');
        $user->phone = $request->input('phone');

        $user->save();

        return redirect()->route('user.show', $user->id)
        return redirect()->route('user.show', /** @scrutinizer ignore-type */ $user->id)
            ->with('success', 'User created successfully');
    }

    /**
     * Show the given user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show(Request $request, $id)
    public function show(/** @scrutinizer ignore-unused */ Request $request, $id)
    {
        $user = User::findOrFail($id);
        $user->password = "";
        
        return view('user.show', [ 'user' => $user ]);
    }

    /**
     * Edit the given user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit(Request $request, $id)
    {
        $user = User::findOrFail($id);
        $user->password = "";

        return view('user.edit', [ 'user' => $user ]);
    }

    /**
     * Update the given user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, $id)
    {
        request()->validate([
            'name' => 'sometimes|nullable|min:2|max:190|full_name',
            'email' => 'sometimes|nullable|string|email|max:255|unique:users,email,'.$id,
            'password' => 'sometimes|nullable|min:8|confirmed',
            'role' => 'sometimes|nullable|integer|max:3',
            'phone' => 'numeric|phone|nullable',
            'preferred_device_id' => 'nullable|integer|digits_between:1,10|exists:devices,id',
        ]);
        
        $query = User::findOrFail($id);

        if ($request->input('name') != null)
        {
            $query->name = $request->input('name');
            $query->email = $request->input('email');
            $query->role = $request->input('role');
            $query->phone = $request->input('phone');
            if ($request->input('password') != '')
                $query->password = bcrypt($request->input('password'));
                $query->password = bcrypt(/** @scrutinizer ignore-type */ $request->input('password'));
        }
        else
            $query->preferred_device_id = $request->input('preferred_device_id');

        $query->save();
    
        if (\Request::ajax())

            return response()->json([ 'success' => 'Preferred device updated successfully' ]);

        else
            return redirect()->route('user.show', $id)
            return redirect()->route('user.show', /** @scrutinizer ignore-type */ $id)
                ->with('success', 'User updated successfully');
    }

    /**
     * Deletes a user.
     *
     * @param  string  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy($id)
    {
        $user = User::withTrashed()->findOrFail($id);

        if ($user->trashed()) {
            //If the user was already deleted then permanently delete it
            $user->forceDelete($user->id);
                   forceDelete($user->id);
        } else {
            //Soft delete the user the first time
            $user->delete();
        }

        return redirect()->route('user.index')
            ->with('success', 'User deleted successfully');
    }
    
    /**
     * Restores a user.
     *
     * @param  string  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function restore($id)
    {
        $user = User::onlyTrashed()->findOrFail($id);

        $user->restore();
        
        return redirect()->route('user.show', $user->id)
        return redirect()->route('user.show', /** @scrutinizer ignore-type */ $user->id)
            ->with('success', 'User restored successfully');
    }
}


uidaho / smartsettia

Push — master ( 6e8adf...c24137 )

UserController::update() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like