App\Http\Controllers\LocationController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	121
Duplicated Lines	28.93 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	6	1
A	create()	0	4	1
A	edit()	0	6	1
A	store()	16	16	2
A	destroy()	0	5	1
A	update()	17	17	2
A	index()	0	3	1

<?php

namespace App\Http\Controllers;

use App\DataTables\LocationDataTable;
use App\Location;
use App\Site;
use App\Http\Requests\EditLocation;

class LocationController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }
    
    /**
     * Display a listing of the resource.
     *
     * @param  LocationDataTable   $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(LocationDataTable $dataTable)
    {
        return $dataTable->render('location.index');

The expression return $dataTable->render('location.index') also could return the type callable which is incompatible with the documented return type Illuminate\Http\JsonResponse|Illuminate\View\View.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $sites = Site::orderBy('name', 'ASC')->get();
        return view('location.create', [ 'sites' => $sites ]);

The expression return view('location.create', array('sites' => $sites)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  EditLocation $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(EditLocation $request)
    {
        //Get the site id of the old or newly created site
        if (!empty($request->input('new_site_name')))
        {
            //Create a new site
            $site = Site::create([ 'name' => $request->input('new_site_name') ]);
            $site_id = $site->id;
        } else {
                    $site_id = $request->input('site');
        }
    
        $location = Location::create([ 'name' => $request->input('name'), 'site_id' => $site_id ]);
    
        return redirect()->route('location.show', $location->id)

$location->id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

            ->with('success', 'Location created successfully');
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $location = Location::findOrFail($id);
        $devices = $location->devices()->orderBy('name', 'ASC')->paginate(15);
    
        return view('location.show', [ 'location' => $location, 'devices' => $devices ]);

The expression return view('location.show', array('location' => $location, 'devices' => $devices)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $location = Location::findOrFail($id);
        $sites = Site::orderByRaw("id = ? DESC", $location->site_id)->orderBy('name', 'ASC')->get();
    
        return view('location.edit', [ 'location' => $location, 'sites' => $sites ]);

The expression return view('location.edit', array('location' => $location, 'sites' => $sites)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  EditLocation  $request
     * @param  int  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(EditLocation $request, $id)
    {
        //Get the site id of the old or newly created site
        if (!empty($request->input('new_site_name')))
        {
            //Create a new site
            $site = Site::create([ 'name' => $request->input('new_site_name') ]);
            $site_id = $site->id;
        } else {
                    $site_id = $request->input('site');
        }
        
        //Update the location with the supplied name and the site
        Location::findOrFail($id)->update([ 'name' => $request->input('name'), 'site_id' => $site_id ]);
        
        return redirect()->route('location.show', $id)

$id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

            ->with('success', 'Location updated successfully');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy($id)
    {
        Location::findOrFail($id)->delete();
        return redirect()->route('location.index')
            ->with('success', 'Location deleted successfully');
    }
}