Device::updateLocationID() - Code Metrics - Inspection of "Merge pull request #26 from uidaho/fix-device-inpu..." - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( efae37...460051 )

by Brandon

created 2017-09-17 18:21 UTC

Device::updateLocationID() A

↳ Parent: Device

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
ccs	0
cts	5
cp	0
rs	9.4285
cc	1
eloc	4
nc	1
nop	2
crap	2

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;
use Illuminate\Support\Facades\DB;

class Device extends Model
{
    use SoftDeletes;
    
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name', 'location_id'
    ];
    
    public $timestamps = false;
    
    /**
     * Get the location for the device
     */
    public function location()
    {
        return $this->belongsTo('App\Location', 'location_id');
    }
    
    /**
     * Get the site for the device
     */
    public function site()
    {
        return $this->belongsTo('App\Site');
    }
    
    /**
     * Update the device with the matching id with a new location id
     *
     * @param int $id
     * @param int $location_id
     */
    public function updateLocationID($id, $location_id)
    {
        
        $device = $this->findOrFail($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $device->location_id = $location_id;
        $device->save();
    }
    
    /**
     * Get all the devices with the supplied location id
     *
     * @param int $location_id
     * @return Illuminate\Database\Eloquent\Builder[]|\Illuminate\Database\Eloquent\Collection
     */
    public function getDevicesBasedOnLocation($location_id)
    {
        return self::where('location_id', $location_id)->get();
    }
    
    /**
     * Get the first device with the supplied location id
     *
     * @param int $location_id
     * @return Device|Illuminate\Database\Eloquent\Model
     */
    public function getFirstDeviceBasedOnLocation($location_id)
    {
        return self::where('location_id', $location_id)->first();
    }
}


1			<?php
2
3			namespace App;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Database\Eloquent\SoftDeletes;
7			use Illuminate\Support\Facades\DB;
8
9			class Device extends Model
10			{
11			use SoftDeletes;
12
13			/**
14			* The attributes that are mass assignable.
15			*
16			* @var array
17			*/
18			protected $fillable = [
19			'name', 'location_id'
20			];
21
22			public $timestamps = false;
23
24			/**
25			* Get the location for the device
26			*/
27			public function location()
28			{
29			return $this->belongsTo('App\Location', 'location_id');
30			}
31
32			/**
33			* Get the site for the device
34			*/
35			public function site()
36			{
37			return $this->belongsTo('App\Site');
38			}
39
40			/**
41			* Update the device with the matching id with a new location id
42			*
43			* @param int $id
44			* @param int $location_id
45			*/
46			public function updateLocationID($id, $location_id)
47			{
48
49			$device = $this->findOrFail($id);
			0 ignored issues – show Documentation Bug introduced 2017-09-17 06:13 UTC by Report Bug Copy Issue Report The method `findOrFail` does not exist on `object<App\Device>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
50			$device->location_id = $location_id;
51			$device->save();
52			}
53
54			/**
55			* Get all the devices with the supplied location id
56			*
57			* @param int $location_id
58			* @return Illuminate\Database\Eloquent\Builder[]\|\Illuminate\Database\Eloquent\Collection
59			*/
60			public function getDevicesBasedOnLocation($location_id)
61			{
62			return self::where('location_id', $location_id)->get();
63			}
64
65			/**
66			* Get the first device with the supplied location id
67			*
68			* @param int $location_id
69			* @return Device\|Illuminate\Database\Eloquent\Model
70			*/
71			public function getFirstDeviceBasedOnLocation($location_id)
72			{
73			return self::where('location_id', $location_id)->first();
74			}
75			}
76

uidaho / smartsettia

Push — master ( efae37...460051 )

Device::updateLocationID() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like