App\Site

Complexity

Total Complexity

4

Size/Duplication

Total Lines	58
Duplicated Lines	12.07 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	locations()	0	4	1
A	devices()	0	4	1
A	orderedSitesBy()	7	7	1
A	createSite()	0	8	1

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;

class Site extends Model
{
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name'
    ];
    
    public $timestamps = false;
    
    /**
     * Get the locations for the site.
     */
    public function locations()
    {
        return $this->hasMany('App\Location');
    }
    
    /**
     * Get the devices for the site.
     */
    public function devices()
    {
        return $this->hasManyThrough('App\Device', 'App\Location', 'device_id', 'location_id', 'id');
    }
    
    /**
     * Get all the sites starting with the site with the id supplied and the rest sorted by their id in descending order
     *
     * @param int $id
     * @return Illuminate\Database\Eloquent\Builder[]|\Illuminate\Database\Eloquent\Collection
     */
    public function orderedSitesBy($id)

This method seems to be duplicated in your project.

    {
        $sites = self::query()->select(['id', 'name'])

The method select() does not exist on Illuminate\Database\Eloquent\Builder. Did you maybe mean createSelectWithConstraint()?

                                ->orderByRaw(DB::raw("(id = " . $id . ") DESC"))
                                ->get();
        return $sites;
    }
    
    /**
     * Create a new site and return its id
     *
     * @param string $name
     * @return int $id
     */
    public function createSite($name)
    {
        $site = new Site;
        $site->name = $name;

The property name does not exist on object<App\Site>. Since you implemented __set, maybe consider adding a @property annotation.

        $site->save();
        
        return $site->id;

The property id does not exist on object<App\Site>. Since you implemented __get, maybe consider adding a @property annotation.

    }
}