App\Http\Controllers\DeviceController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	193
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	index()	0	4	1
A	create()	0	4	1
A	show()	0	6	1
A	edit()	0	11	2
B	update()	0	56	5
B	destroy()	0	24	2
A	remove()	0	6	1
A	removeUnusedSite()	0	10	3

<?php

namespace App\Http\Controllers;

use Validator;
use Illuminate\Http\Request;
use App\DataTables\DevicesDataTable;
use App\Device;
use App\Site;
use App\Location;

class DeviceController extends Controller
{
    /**
     * Create a new controller instance.
     *
     */
    public function __construct()
    {
        $this->middleware('auth');
        // TODO: Setup logging
        // $this->middleware('log')->only('index');

77% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * Display index page and process dataTable ajax request.
     *
     * @param \App\DataTables\DevicesDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(DevicesDataTable $dataTable)
    {
        return $dataTable->render('device.index');
    }

    /**
     * Show create device page.
     *
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create()
    {
        return view('device.create');
    }

    /**
     * Show the given device.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $device = Device::findOrFail($id);

        return view('device.show', ['device' => $device]);
    }

    /**
     * View the edit device page.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $device = Device::findOrFail($id);
        $location = Location::where('id', $device->location_id)->first();
        if ($location)
            $site = Site::where('id', $location->site_id)->first();
        else
            $site = null;

        return view('device.edit', ['device' => $device, 'location' => $location, 'site' => $site]);
    }

    /**
     * Update the given device.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return Response
     */
    public function update(Request $request, $id)
    {
        // TODO: Since HTML forms can't make PUT, PATCH, or DELETE requests, you will need
        // to add a hidden  _method field to spoof these HTTP verbs. The
        // method_field helper can create this field for you:
        // {{ method_field('PUT') }}

64% of this comment could be valid code. Did you maybe forget this after debugging?

        $device = Device::findOrFail($id);
        $oldLocationID = $device->location_id;
        $location = null;

$location is not used, you could remove the assignment.

        $site = null;

$site is not used, you could remove the assignment.

        $validator = Validator::make($request->all(), [
            'name' => 'required|string|max:255',
            'site' => 'string|max:255',
            'location' => 'string|max:255',
        ]);
        
        if ($validator->fails()) {
            return redirect('device/'.$id.'/edit')->withErrors($validator)->withInput();
        }
    
        //Check if the site entered by the user is already created
        $siteExist = Site::where('name', $request->input('site'))->first();
        if (!$siteExist)
        {
            //Create a new site
            $site = new Site;
            $site->name = $request->input('site');

The property name does not exist on object<App\Site>. Since you implemented __set, maybe consider adding a @property annotation.

            $site->save();
        }
    
        //Check if the location entered by the user is already created and connected to the same site
        $site = Site::where('name', $request->input('site'))->first();
        $locationExist = Location::where('name', $request->input('location'))->first();
        if (!$locationExist || !$siteExist)
        {
            //Create a new location
            $location = new Location;
            $location->name = $request->input('location');

The property name does not exist on object<App\Location>. Since you implemented __set, maybe consider adding a @property annotation.

            $location->site_id = $site->id;

The property site_id does not exist on object<App\Location>. Since you implemented __set, maybe consider adding a @property annotation.

            $location->save();
        }
        
        //Update the devices name and location_id
        $location = Location::where('name', $request->input('location'))
                                    ->where('site_id', $site->id)->first();
        $device->location_id = $location->id;
        $device->name = $request->input('name');
        $device->save();

        //If the old site isn't connected to a device then remove it
        $this->removeUnusedSite($oldLocationID);
        
        return redirect('device');
    }

    /**
     * Deletes a device.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return Response
     */
    public function destroy(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $device = Device::findOrFail($id);

        if ($device->trashed())
        {
            // if the user was already deleted then permananetly delete it
            Device::destroy($id);
        }
        else
        {
            //Remove the location from the device
            $oldLocation_id = $device->location_id;
            $device->location_id = null;
            $device->save();
            //Remove unused location and site if applicable
            $this->removeUnusedSite($oldLocation_id);
            
            // soft delete the user the first time
            $device->delete();
        }

        return redirect('device');
    }
    
    /**
     * Confirms deletion of a device.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return Response
     */
    public function remove(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $device = Device::findOrFail($id);
        
        return view('device.remove', ['device' => $device]);
    }
    
    /**
     * If a site is not connected to a device then delete the site
     *
     * @param  int $oldLocationID
     */
    private function removeUnusedSite($oldLocationID)
    {
        //Cleanup left over sites and locations
        $deviceExist = Device::where('location_id', $oldLocationID)->first();
        if (!$deviceExist && $oldLocationID != null)
        {
            $oldLocation = Location::where('id', $oldLocationID)->firstOrFail()->site_id;
            Site::where('id', $oldLocation)->delete();
        }
    }
}