uidaho / smartsettia

app/Http/Controllers/DashboardController.php

Doc Comments +1 added lines, -1 removed lines

@@ -176,7 +176,7 @@
      *
      * @param  Request  $request
      * @param Device $device
-     * @return \Illuminate\Database\Eloquent\Builder[]|\Illuminate\Database\Eloquent\Collection
+     * @return \Illuminate\Http\JsonResponse
      */
     public function updateCommand(Request $request, Device $device)
     {

Braces +21 added lines, -17 removed lines

@@ -34,8 +34,7 @@ 
             //Todo use the users preferred device
             //Get the first device that doesn't have a null location_id
             $device = Device::publicDashData()->where('location_id', '!=', 'null')->orderBy('id', 'ASC')->first();
-        }
-        catch(ModelNotFoundException $e)
+        } catch(ModelNotFoundException $e)
         {
             //If no device is found then redirect the user to the home page and display a message about registering a device
             return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -85,14 +84,15 @@ 
         //Get the given device if it is still at the same location
         $device = Device::publicDashData()->where('location_id', '=', $request->location_id)->find($request->device_id);
         
-        if (empty($site))                 //Check if the site still exists
+        if (empty($site)) {
+            //Check if the site still exists
         {
             try
             {
                 //Get the first site and if no sites exist throw an error
                 $site = Site::select('id', 'name')->firstOrFail();
-            }
-            catch(ModelNotFoundException $e)
+        }
+            } catch(ModelNotFoundException $e)
             {
                 //If no device is found then redirect the user to the home page and display a message about registering a device
                 return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -102,19 +102,21 @@ 
             $location = $site->locations()->select('id', 'name', 'site_id')->firstOrFail();
             //Get the first device from the location
             $device = $location->devices()->publicDashData()->firstOrFail();
-        }
-        else if (empty($location))        //Check if the location still exists
+        } else if (empty($location)) {
+            //Check if the location still exists
         {
             //Get the first location from the given site
             $location = $site->locations()->select('id', 'name', 'site_id')->firstOrFail();
+        }
             //Get the first device from the location
             $device = $location->devices()->publicDashData()->firstOrFail();
-        }
-        else if (empty($device))        //Check if the device still exists at the given location
+        } else if (empty($device)) {
+            //Check if the device still exists at the given location
         {
             //Get the first device from the location
             $device = $location->devices()->publicDashData()->firstOrFail();
         }
+        }
         
         $data = $this->dashData($site, $location, $device);
         
@@ -199,8 +201,9 @@ 
         ])->validate();
         
         //Check that device isn't currently in use or has an error
-        if ($device->cover_status === 'opening' || $device->cover_status === 'closing' || $device->cover_status === 'error')
-            return response()->json("Device is currently in use.", 403);
+        if ($device->cover_status === 'opening' || $device->cover_status === 'closing' || $device->cover_status === 'error') {
+                    return response()->json("Device is currently in use.", 403);
+        }
         
         //1 = open, 2 = close, 3 = lock
         switch($request->command)
@@ -238,13 +241,14 @@ 
             $time_now = Carbon::now(Auth::user()->timezone);
             
             //Check if the current time is during the open schedule or not
-            if (($time_now > $open_time) && ($time_now < $close_time))
-                $command =  'open';
-            else
-                $command =  'close';
+            if (($time_now > $open_time) && ($time_now < $close_time)) {
+                            $command =  'open';
+            } else {
+                            $command =  'close';
+            }
+        } else {
+                    $command =  'lock';
         }
-        else
-            $command =  'lock';
         
         return $command;
     }

app/Device.php

Braces +10 added lines, -8 removed lines

@@ -75,8 +75,9 @@ 
         $time = new Carbon($value, 'UTC');
         
         //If the user is logged in then use there preferred timezone
-        if (Auth::check())
-            $time = $time->setTimezone(Auth::user()->timezone);
+        if (Auth::check()) {
+                    $time = $time->setTimezone(Auth::user()->timezone);
+        }
 
         return $time->format('H:i');
     }
@@ -94,8 +95,9 @@ 
         $time = new Carbon($value, 'UTC');
     
         //If the user is logged in then use there preferred timezone
-        if (Auth::check())
-            $time = $time->setTimezone(Auth::user()->timezone);
+        if (Auth::check()) {
+                    $time = $time->setTimezone(Auth::user()->timezone);
+        }
         
         return $time->format('H:i');
     }
@@ -115,9 +117,9 @@ 
         {
             $time = new Carbon($value, Auth::user()->timezone);
             $time = $time->setTimezone('UTC');
+        } else {
+                    $time = new Carbon($value, 'UTC');
         }
-        else
-            $time = new Carbon($value, 'UTC');
         
         $this->attributes['open_time'] = $time;
     }
@@ -137,9 +139,9 @@ 
         {
             $time = new Carbon($value, Auth::user()->timezone);
             $time = $time->setTimezone('UTC');
+        } else {
+                    $time = new Carbon($value, 'UTC');
         }
-        else
-            $time = new Carbon($value, 'UTC');
         
         $this->attributes['close_time'] = $time;
     }

app/Http/Controllers/ActivityLogController.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     /**
      * Display index page and process dataTable ajax request.
      *
-     * @param \App\DataTables\UsersDataTable $dataTable
+     * @param ActivityLogDataTable $dataTable
      * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
      */
     public function index(ActivityLogDataTable $dataTable)

app/Http/Controllers/DeviceController.php

Doc Comments +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
      * Return null if the site does not have any locations
      *
      * @param  int $site_id
-     * @return Illuminate\Database\Eloquent\Builder[]|\Illuminate\Database\Eloquent\Collection
+     * @return \Illuminate\Http\JsonResponse
      */
     public function locations($site_id)
     {
@@ -121,7 +121,7 @@ 
      * Return 404 error if the device is not found
      *
      * @param  int $id
-     * @return Illuminate\Database\Eloquent\Builder[]|\Illuminate\Database\Eloquent\Collection
+     * @return \Illuminate\Http\JsonResponse
      */
     public function details($id)
     {

Braces +17 added lines, -18 removed lines

@@ -84,8 +84,7 @@ 
             $sites->prepend($location->site);
             //Add the current location to the front of the collection of locations
             $locations->prepend($location);
-        }
-        else
+        } else
         {
             //Set locations to null since there is no site or location attached to the selected device
             $locations = null;
@@ -93,10 +92,11 @@ 
             $sites = Site::all();
         }
         
-        if (\Request::ajax())
-            return response()->json([ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
-        else
-            return view('device.edit', [ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
+        if (\Request::ajax()) {
+                    return response()->json([ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
+        } else {
+                    return view('device.edit', [ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
+        }
     }
     
     /**
@@ -110,8 +110,9 @@ 
     {
         $locations = Location::bySite($site_id)->select('id', 'name', 'site_id')->get();
         
-        if ($locations->isEmpty())
-            $locations = null;
+        if ($locations->isEmpty()) {
+                    $locations = null;
+        }
     
         return response()->json($locations);
     }
@@ -151,8 +152,7 @@ 
             //Create a new site
             $siteName = $request->input('new_site_name');
             $site_id = Site::createSite($siteName)->id;
-        }
-        else
+        } else
         {
             $site_id = $request->input('site');
         }
@@ -166,8 +166,7 @@ 
             //Create a new location
             $locationName = $request->input('new_location_name');
             $location_id = Location::createLocation($locationName, $site_id)->id;
-        }
-        else
+        } else
         {
             $location_id = $request->input('location');
         }
@@ -188,10 +187,11 @@ 
         //Remove any unused sites or locations
         $this->RemoveUnusedSiteLoc();
     
-        if (\Request::ajax())
-            return response()->json("Success");
-        else
-            return redirect('device');
+        if (\Request::ajax()) {
+                    return response()->json("Success");
+        } else {
+                    return redirect('device');
+        }
     }
 
     /**
@@ -208,8 +208,7 @@ 
         {
             //If the device was already deleted then permanently delete it
             Device::destroy($id);
-        }
-        else
+        } else
         {
             //Remove the location from the device
             $device->location_id = null;

app/DataTables/SensorDataDataTable.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
     /**
      * Get columns.
      *
-     * @return array
+     * @return string[]
      */
     protected function getColumns()
     {

app/Http/Controllers/ApiController.php

Doc Comments +6 added lines, -6 removed lines

@@ -17,7 +17,7 @@ 
     /**
      * Creates a json response for all the devices.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */    
     public function index()
     {
@@ -28,7 +28,7 @@ 
      * Creates a json response for a specifc device.
      *
      * @param  Device  $device
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */    
     public function show(Device $device)
     {
@@ -39,7 +39,7 @@ 
      * Updates the status of a device.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(Request $request)
     {
@@ -107,7 +107,7 @@ 
      * Updates the sensors of a device.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function sensor(Request $request)
     {
@@ -170,7 +170,7 @@ 
      * Registers a new device.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function register(Request $request)
     {
@@ -228,7 +228,7 @@ 
      * Updates the image for a device.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function image(Request $request) {
         // Validate the request.

app/DataTables/DevicesDataTable.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
     /**
      * Get columns.
      *
-     * @return array
+     * @return string[]
      */
     protected function getColumns()
     {