DashboardController::ajaxRefreshAll() - Code Metrics - Inspection of "Change cover_status, cover_command, open_time, and..." - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#63)

by Brandon
created 2017-10-09 03:37 UTC
DashboardController::ajaxRefreshAll() B

↳ Parent: Project
Complexity

Conditions	4
Paths	4
Size

Total Lines	44
Code Lines	20
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	20
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
c	1
b	0
f	0
dl	0
loc	44
ccs	0
cts	18
cp	0
rs	8.5806
cc	4
eloc	20
nc	4
nop	1
crap	20
<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use Illuminate\Http\Request;
use Validator;
use App\Device;
use App\Site;
use App\Location;
use Carbon\Carbon;

class DashboardController extends Controller
{
    /**
     * Create a new controller instance.
     *
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Show the application dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()

    {
        //Todo use the users preferred device
        //Get the very first device
        $device = Device::publicDashData()->first();

        //Get the devices location
        $location = $device->location()->select('id', 'name', 'site_id')->firstOrFail();
        //Get the devices site
        $site = $location->site()->select('id', 'name')->firstOrFail();
    
        $data = $this->dashData($site, $location, $device);
        
        return view('dashboard.index', [ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
    }
    
    /**
     * Show the development layouts for dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function dev_layout()
    {
        return view('dashboard.dev_layout');
    }
    
    /**
     * Refresh all the data on the dashboard except the image and sensor graphs
     *
     * @param  Request  $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajaxRefreshAll(Request $request)
    {
        Validator::make($request->all(), [
            'site_id' => 'required|int|max:255',
            'location_id' => 'required|int|max:255',
            'device_id' => 'required|int|max:255',
        ])->validate();
        
        //Todo limit the amount of queries based on if there is changes
        //Check for changes in database since last update
    
        //Get the given site
        $site = Site::select('id', 'name')->find($request->site_id);
        //Get the given location
        $location = Location::select('id', 'name', 'site_id')->find($request->location_id);
        //Get the given device if it is still at the same location
        $device = Device::publicDashData()->where('location_id', '=', $request->location_id)->find($request->device_id);

        
        if (empty($site))                 //Check if the site still exists
        {
            //Get the first site and if no sites exist throw an error
            $site = Site::select('id', 'name')->firstOrFail();
            //Get the first location from the site
            $location = $site->locations()->select('id', 'name', 'site_id')->firstOrFail();
            //Get the first device from the location
            $device = $location->devices()->publicDashData()->firstOrFail();
        }
        else if (empty($location))        //Check if the location still exists
        {
            //Get the first location from the given site
            $location = $site->locations()->select('id', 'name', 'site_id')->firstOrFail();
            //Get the first device from the location
            $device = $location->devices()->publicDashData()->firstOrFail();
        }
        else if (empty($device))        //Check if the device still exists at the given location
        {
            //Get the first device from the location
            $device = $location->devices()->publicDashData()->firstOrFail();
        }
        
        $data = $this->dashData($site, $location, $device);
        
        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
    }
    
    /**
     * Return database data about devices, sites, and locations
     *
     * @param int $site_id
     * @return \Illuminate\Http\JsonResponse
     */
    public function siteChange($site_id)
    {
        //Get the given site
        $site = Site::select('id', 'name')->findOrFail($site_id);
        //Get the given location
        $location = Location::select('id', 'name', 'site_id')->where('site_id', '=', $site->id)->firstOrFail();
        //Get the given device if it is still at the same location
        $device = Device::publicDashData()->where('location_id', '=', $location->id)->firstOrFail();

        
        $data = $this->dashData($site, $location, $device);
        
        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
    }
    
    /**
     * Return database data about devices, sites, and locations
     *
     * @param int $location_id
     * @return \Illuminate\Http\JsonResponse
     */
    public function locationChange($location_id)

    {
        //Get the given location
        $location = Location::select('id', 'name', 'site_id')->findOrFail($location_id);
        //Get the given site
        $site = $location->site()->select('id', 'name')->firstOrFail();
        //Get the given device if it is still at the same location
        $device = Device::publicDashData()->where('location_id', '=', $location_id)->firstOrFail();

        
        $data = $this->dashData($site, $location, $device);
        
        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
    }
    
    /**
     * Return database data about devices, sites, and locations
     *
     * @param \Illuminate\Database\Eloquent\Model $site
     * @param \Illuminate\Database\Eloquent\Model $location
     * @param \Illuminate\Database\Eloquent\Model $device
     * @return \Illuminate\Database\Eloquent\Collection
     */
    public function dashData($site, $location, $device)
    {
        //Get all the sites except for the current site ordered by name
        $sites = Site::select('id', 'name')->orderBy('name', 'ASC')->get()->except($site->id);
        
        //Get all the locations for the given site except for the new current location ordered by name
        $locations = $site->locations()->select('id', 'name', 'site_id')->orderBy('name', 'ASC')->get()->except($location->id);
        
        //Get all the devices that belong to the given location ordered by name
        $devices = $location->devices()->publicDashData()->orderBy('name', 'ASC')->get();
        
        $active_device = collect([$device, $location, $site]);
        
        return collect([$active_device, $devices, $locations, $sites]);
    }
    
    /**
     * Open or close the given device
     *
     * @param  Request  $request
     * @param Device $device
     * @return \Illuminate\Database\Eloquent\Builder[]|\Illuminate\Database\Eloquent\Collection
     */
    public function updateCommand(Request $request, Device $device)
    {
        Validator::make($request->all(), [
            'command' => 'required|string|max:1',
        ])->validate();
        
        //Check that device isn't currently in use or has an error
        if ($device->cover_status === 'opening' || $device->cover_status === 'closing' || $device->cover_status === 'error')
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return response()->json("Device is currently in use.", 403);
        
        //1 = open, 2 = close, 3 = lock
        switch($request->command)
        {
            case 1:
                $device->cover_command = 'open';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                break;
            case 2:
                $device->cover_command = 'close';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                break;
            case 3:
                $device->cover_command = $this->disableCommand($device);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                break;
        }
        
        $device->save();
        
        return response()->json("Success");
    }
    
    /**
     * Get the devices command based on the device being locked or unlocked
     *
     * @param Device $device
     * @return string
     */
    public function disableCommand(Device $device)
    {
        //Check if the device is already locked or not
        if ($device->cover_command === 'lock')
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        {
            //Get the open, close, and current time in the users timezone
            $open_time = new Carbon($device->open_time, Auth::user()->timezone);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $close_time = new Carbon($device->close_time, Auth::user()->timezone);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $time_now = Carbon::now(Auth::user()->timezone);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            
            //Check if the current time is during the open schedule or not
            if (($time_now > $open_time) && ($time_now < $close_time))
                $command =  'open';
            else
                $command =  'close';
        }
        else
            $command =  'lock';
        
        return $command;
    }
}

Pull Request — master (#63)

DashboardController::ajaxRefreshAll() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

uidaho / smartsettia

Pull Request — master (#63)

DashboardController::ajaxRefreshAll() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
