Completed
Pull Request — master (#107)
by
unknown
02:22
created
app/DataTables/UsersDataTable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     {
17 17
         return datatables($query)
18 18
             ->editColumn('name', function(User $user) {
19
-                return '<a href="' . route('user.show', $user->id) . '">'. $user->name . '</a>';
19
+                return '<a href="'.route('user.show', $user->id).'">'.$user->name.'</a>';
20 20
             })
21 21
 
22 22
             ->editColumn('role', function(User $user) {
Please login to merge, or discard this patch.
app/DataTables/DevicesDataTable.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,19 +16,19 @@
 block discarded – undo
16 16
     public function dataTable($query)
17 17
     {
18 18
         return datatables($query)
19
-            ->editColumn('name', function ($device) {
20
-                return '<a href="' . route('device.show', $device->id) . '">' . $device->name . '</a>';
19
+            ->editColumn('name', function($device) {
20
+                return '<a href="'.route('device.show', $device->id).'">'.$device->name.'</a>';
21 21
             })
22
-            ->addColumn('location', function ($device) {
22
+            ->addColumn('location', function($device) {
23 23
                 return ($device->location->name ?? 'null');
24 24
             })
25
-            ->addColumn('site', function ($device) {
25
+            ->addColumn('site', function($device) {
26 26
                 return ($device->location->site->name ?? 'null');
27 27
             })
28
-            ->addColumn('rates', function ($device) {
29
-                return $device->update_rate . '/' . $device->image_rate .'/' . $device->sensor_rate;
28
+            ->addColumn('rates', function($device) {
29
+                return $device->update_rate.'/'.$device->image_rate.'/'.$device->sensor_rate;
30 30
             })
31
-            ->editColumn('updated_at', function ($device) {
31
+            ->editColumn('updated_at', function($device) {
32 32
                 return (is_object($device->updated_at) ? $device->updated_at->diffForHumans() : 'never');
33 33
             })
34 34
             ->blacklist([ 'location', 'site', 'rates' ])
Please login to merge, or discard this patch.
app/Http/Controllers/UserController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         }
155 155
 
156 156
         return redirect()->route('user.index')
157
-            ->with('success','User deleted successfully');
157
+            ->with('success', 'User deleted successfully');
158 158
     }
159 159
     
160 160
     /**
@@ -170,6 +170,6 @@  discard block
 block discarded – undo
170 170
         $user->restore();
171 171
         
172 172
         return redirect()->route('user.show', $user->id)
173
-            ->with('success','User restored successfully');
173
+            ->with('success', 'User restored successfully');
174 174
     }
175 175
 }
Please login to merge, or discard this patch.
app/DataTables/LocationDataTable.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -15,15 +15,15 @@
 block discarded – undo
15 15
     public function dataTable($query)
16 16
     {
17 17
         return datatables($query)
18
-            ->editColumn('name', function ($location) {
19
-                return '<a href="' . route('location.show', $location->id) . '">'. $location->name . '</a>';
18
+            ->editColumn('name', function($location) {
19
+                return '<a href="'.route('location.show', $location->id).'">'.$location->name.'</a>';
20 20
             })
21
-            ->editColumn('site_id', function ($location) {
22
-                return '<a href="' . route('site.show', $location->site_id) . '">'. ($location->site->name ?? '') . '</a>';
21
+            ->editColumn('site_id', function($location) {
22
+                return '<a href="'.route('site.show', $location->site_id).'">'.($location->site->name ?? '').'</a>';
23 23
             })
24 24
             ->addColumn('action', 'location.action')
25 25
             ->blacklist([ 'action' ])
26
-            ->rawColumns(['site_id', 'name', 'action']);
26
+            ->rawColumns([ 'site_id', 'name', 'action' ]);
27 27
     }
28 28
     
29 29
     /**
Please login to merge, or discard this patch.
app/DataTables/SiteDataTable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -15,12 +15,12 @@
 block discarded – undo
15 15
     public function dataTable($query)
16 16
     {
17 17
         return datatables($query)
18
-            ->editColumn('name', function ($site) {
19
-                return '<a href="' . route('site.show', $site->id) . '">'. $site->name . '</a>';
18
+            ->editColumn('name', function($site) {
19
+                return '<a href="'.route('site.show', $site->id).'">'.$site->name.'</a>';
20 20
             })
21 21
             ->addColumn('action', 'site.action')
22 22
             ->blacklist([ 'action' ])
23
-            ->rawColumns(['name', 'action']);
23
+            ->rawColumns([ 'name', 'action' ]);
24 24
     }
25 25
     
26 26
     /**
Please login to merge, or discard this patch.
app/Http/Controllers/LocationController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -52,13 +52,13 @@  discard block
 block discarded – undo
52 52
         if (!empty($request->input('new_site_name')))
53 53
         {
54 54
             //Create a new site
55
-            $site = Site::create(['name' => $request->input('new_site_name')]);
55
+            $site = Site::create([ 'name' => $request->input('new_site_name') ]);
56 56
             $site_id = $site->id;
57 57
         }
58 58
         else
59 59
             $site_id = $request->input('site');
60 60
     
61
-        $location = Location::create(['name' => $request->input('name'), 'site_id' => $site_id]);
61
+        $location = Location::create([ 'name' => $request->input('name'), 'site_id' => $site_id ]);
62 62
     
63 63
         return redirect()->route('location.show', $location->id)
64 64
             ->with('success', 'Location created successfully');
@@ -105,14 +105,14 @@  discard block
 block discarded – undo
105 105
         if (!empty($request->input('new_site_name')))
106 106
         {
107 107
             //Create a new site
108
-            $site = Site::create(['name' => $request->input('new_site_name')]);
108
+            $site = Site::create([ 'name' => $request->input('new_site_name') ]);
109 109
             $site_id = $site->id;
110 110
         }
111 111
         else
112 112
             $site_id = $request->input('site');
113 113
         
114 114
         //Update the location with the supplied name and the site
115
-        Location::findOrFail($id)->update(['name' => $request->input('name'), 'site_id' => $site_id]);
115
+        Location::findOrFail($id)->update([ 'name' => $request->input('name'), 'site_id' => $site_id ]);
116 116
         
117 117
         return redirect()->route('location.show', $id)
118 118
             ->with('success', 'Location updated successfully');
@@ -128,6 +128,6 @@  discard block
 block discarded – undo
128 128
     {
129 129
         Location::findOrFail($id)->delete();
130 130
         return redirect()->route('location.index')
131
-            ->with('success','Location deleted successfully');
131
+            ->with('success', 'Location deleted successfully');
132 132
     }
133 133
 }
Please login to merge, or discard this patch.
app/Sensor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      */
70 70
     public function getLatestDataAttribute()
71 71
     {
72
-        return $this->hasOne('App\SensorData')->latest()->first() ?? (object)[];
72
+        return $this->hasOne('App\SensorData')->latest()->first() ?? (object) [ ];
73 73
     }
74 74
     
75 75
     /**
Please login to merge, or discard this patch.
app/User.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
     public function roleString()
144 144
     {
145 145
         $role_en = array(0 => "Registered", 1 => "User", 2 => "Manager", 3 => "Admin");
146
-        return $role_en[ $this->role ] . ' (' . $this->role . ')';
146
+        return $role_en[ $this->role ].' ('.$this->role.')';
147 147
     }
148 148
     
149 149
     /**
Please login to merge, or discard this patch.
app/Http/Controllers/DashboardController.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             
45 45
             //If the location exists then set the pagination page to be where the device is located
46 46
             if ($location != null)
47
-                $request->merge(['page' => $device->dashPageNum(4)]);
47
+                $request->merge([ 'page' => $device->dashPageNum(4) ]);
48 48
             $site_id = $location->site_id ?? 0;
49 49
             $location_id = $location->id ?? 0;
50 50
             $device_id = $device->id ?? 0;
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
             ->get();
65 65
         //Get all locations for the selected site with the selected location first
66 66
         $locations = Location::select('id', 'name', 'site_id')
67
-            ->where('site_id', '=', $sites[0]->id ?? 0)
67
+            ->where('site_id', '=', $sites[ 0 ]->id ?? 0)
68 68
             ->orderByRaw("id = ? DESC", $location_id)
69 69
             ->orderBy('name', 'ASC')
70 70
             ->get();
71 71
         //Get all devices for the selected location
72 72
         $devices = Device::publicDashData()
73 73
             ->leftJoin('deviceimages as image', 'devices.id', '=', 'image.device_id')
74
-            ->where('location_id', '=', $locations[0]->id ?? 0)
74
+            ->where('location_id', '=', $locations[ 0 ]->id ?? 0)
75 75
             ->orderBy('name', 'ASC')
76 76
             ->paginate(4);
77 77
     
@@ -84,33 +84,33 @@  discard block
 block discarded – undo
84 84
             //If the original device with the given device id was not found
85 85
             //Then assign the the first device in the device list as the active device
86 86
             if ($active_device == null)
87
-                $active_device = $devices[0];
87
+                $active_device = $devices[ 0 ];
88 88
         
89 89
             //Add an attribute to each device defining if it is stale
90
-            $devices->transform(function ($item)
90
+            $devices->transform(function($item)
91 91
             {
92 92
                 //Mark the device as stale if the device has missed three updates plus a minute
93 93
                 $deviceStaleMins = ceil(($item->update_rate * 3) / 60) + 1;
94
-                $item['isDeviceStale'] = ($item->last_network_update_at <= Carbon::now()->subMinute($deviceStaleMins)) ? true : false;
94
+                $item[ 'isDeviceStale' ] = ($item->last_network_update_at <= Carbon::now()->subMinute($deviceStaleMins)) ? true : false;
95 95
     
96 96
                 //Mark the device image as stale if the device has missed three image updates plus a minute
97 97
                 if ($item->image_updated_at != null)
98 98
                 {
99 99
                     $imageStaleMins = ceil(($item->image_rate * 3) / 60) + 1;
100
-                    $item['isImageStale'] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
100
+                    $item[ 'isImageStale' ] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
101 101
                 }
102 102
                 else
103
-                    $item['isImageStale'] = false;
103
+                    $item[ 'isImageStale' ] = false;
104 104
                 
105 105
                 return $item;
106 106
             });
107 107
         }
108 108
     
109 109
         //Store the active site, location, and device in a collection
110
-        $active_data = collect(['device' => $active_device, 'location' => $locations[0] ?? null, 'site' => $sites[0] ?? null]);
110
+        $active_data = collect([ 'device' => $active_device, 'location' => $locations[ 0 ] ?? null, 'site' => $sites[ 0 ] ?? null ]);
111 111
     
112 112
         //Use the device_list.blade.php to generate the device table html
113
-        $html_device_table = view('dashboard.device_list', ['devices' => $devices, 'active_data' => $active_data])->render();
113
+        $html_device_table = view('dashboard.device_list', [ 'devices' => $devices, 'active_data' => $active_data ])->render();
114 114
         
115 115
         if (\Request::ajax())
116 116
             return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,
Please login to merge, or discard this patch.