Completed
Pull Request — master (#119)
by
unknown
17:56
created
app/Http/Controllers/SensorController.php 1 patch
Indentation   +41 added lines, -41 removed lines patch added patch discarded remove patch
@@ -10,42 +10,42 @@  discard block
 block discarded – undo
10 10
 class SensorController extends Controller 
11 11
 {
12 12
     /**
13
-    * Create a new controller instance.
14
-    *
15
-    * @return void
16
-    */
13
+     * Create a new controller instance.
14
+     *
15
+     * @return void
16
+     */
17 17
     public function __construct()
18 18
     {
19 19
         $this->middleware('auth');
20 20
     }
21 21
 
22 22
     /**
23
-    * Display a listing of the resource.
24
-    *
25
-    * @param  SensorDataTable   $dataTable
26
-    * @return Response
27
-    */
23
+     * Display a listing of the resource.
24
+     *
25
+     * @param  SensorDataTable   $dataTable
26
+     * @return Response
27
+     */
28 28
     public function index(SensorDataTable $dataTable)
29 29
     {
30 30
         return $dataTable->render('sensor.index');
31 31
     }
32 32
 
33 33
     /**
34
-    * Show the form for creating a new resource.
35
-    *
36
-    * @return Response
37
-    */
34
+     * Show the form for creating a new resource.
35
+     *
36
+     * @return Response
37
+     */
38 38
     public function create()
39 39
     {
40 40
         return view('sensor.create');
41 41
     }
42 42
 
43 43
     /**
44
-    * Store a newly created resource in storage.
45
-    *
46
-    * @param Request $request
47
-    * @return Response
48
-    */
44
+     * Store a newly created resource in storage.
45
+     *
46
+     * @param Request $request
47
+     * @return Response
48
+     */
49 49
     public function store(Request $request)
50 50
     {
51 51
         request()->validate([
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
     }
62 62
 
63 63
     /**
64
-    * Display the specified resource.
65
-    *
66
-    * @param  Request  $request
67
-    * @param  int  $id
68
-    * @return Response
69
-    */
64
+     * Display the specified resource.
65
+     *
66
+     * @param  Request  $request
67
+     * @param  int  $id
68
+     * @return Response
69
+     */
70 70
     public function show(Request $request, $id)
71 71
     {
72 72
         $sensor = Sensor::findOrFail($id);
@@ -75,12 +75,12 @@  discard block
 block discarded – undo
75 75
     }
76 76
 
77 77
     /**
78
-    * Show the form for editing the specified resource.
79
-    *
80
-    * @param  Request  $request
81
-    * @param  int  $id
82
-    * @return Response
83
-    */
78
+     * Show the form for editing the specified resource.
79
+     *
80
+     * @param  Request  $request
81
+     * @param  int  $id
82
+     * @return Response
83
+     */
84 84
     public function edit(Request $request, $id)
85 85
     {
86 86
         $sensor = Sensor::findOrFail($id);
@@ -89,12 +89,12 @@  discard block
 block discarded – undo
89 89
     }
90 90
 
91 91
     /**
92
-    * Update the specified resource in storage.
93
-    *
94
-    * @param  Request  $request
95
-    * @param  int  $id
96
-    * @return Response
97
-    */
92
+     * Update the specified resource in storage.
93
+     *
94
+     * @param  Request  $request
95
+     * @param  int  $id
96
+     * @return Response
97
+     */
98 98
     public function update(Request $request, $id)
99 99
     {
100 100
         request()->validate([
@@ -108,11 +108,11 @@  discard block
 block discarded – undo
108 108
     }
109 109
 
110 110
     /**
111
-    * Remove the specified resource from storage.
112
-    *
113
-    * @param  int  $id
114
-    * @return Response
115
-    */
111
+     * Remove the specified resource from storage.
112
+     *
113
+     * @param  int  $id
114
+     * @return Response
115
+     */
116 116
     public function destroy($id)
117 117
     {
118 118
         Sensor::findOrFail($id)->delete();
Please login to merge, or discard this patch.
app/Http/Controllers/SensorDataController.php 1 patch
Indentation   +39 added lines, -39 removed lines patch added patch discarded remove patch
@@ -9,42 +9,42 @@  discard block
 block discarded – undo
9 9
 class SensorDataController extends Controller 
10 10
 {
11 11
     /**
12
-    * Create a new controller instance.
13
-    *
14
-    * @return void
15
-    */
12
+     * Create a new controller instance.
13
+     *
14
+     * @return void
15
+     */
16 16
     public function __construct()
17 17
     {
18 18
         $this->middleware('auth');
19 19
     }
20 20
 
21 21
     /**
22
-    * Display a listing of the resource.
23
-    *
24
-    * @param SensorDataDataTable $dataTable
25
-    * @return Response
26
-    */
22
+     * Display a listing of the resource.
23
+     *
24
+     * @param SensorDataDataTable $dataTable
25
+     * @return Response
26
+     */
27 27
     public function index(SensorDataDataTable $dataTable)
28 28
     {
29 29
         return $dataTable->render('sensordata.index');
30 30
     }
31 31
 
32 32
     /**
33
-    * Show the form for creating a new resource.
34
-    *
35
-    * @return Response
36
-    */
33
+     * Show the form for creating a new resource.
34
+     *
35
+     * @return Response
36
+     */
37 37
     public function create()
38 38
     {
39 39
         return view('sensordata.create');
40 40
     }
41 41
 
42 42
     /**
43
-    * Store a newly created resource in storage.
44
-    *
45
-    * @param Request $request
46
-    * @return Response
47
-    */
43
+     * Store a newly created resource in storage.
44
+     *
45
+     * @param Request $request
46
+     * @return Response
47
+     */
48 48
     public function store(Request $request)
49 49
     {
50 50
         request()->validate([
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
59 59
     }
60 60
 
61 61
     /**
62
-    * Display the specified resource.
63
-    *
64
-    * @param  Request  $request
65
-    * @param  int  $id
66
-    * @return Response
67
-    */
62
+     * Display the specified resource.
63
+     *
64
+     * @param  Request  $request
65
+     * @param  int  $id
66
+     * @return Response
67
+     */
68 68
     public function show(Request $request, $id)
69 69
     {
70 70
         $sensordata = SensorData::findOrFail($id);
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
     }
74 74
 
75 75
     /**
76
-    * Show the form for editing the specified resource.
77
-    *
78
-    * @param  int  $id
79
-    * @return Response
80
-    */
76
+     * Show the form for editing the specified resource.
77
+     *
78
+     * @param  int  $id
79
+     * @return Response
80
+     */
81 81
     public function edit(Request $request, $id)
82 82
     {
83 83
         $sensordata = SensorData::findOrFail($id);
@@ -86,11 +86,11 @@  discard block
 block discarded – undo
86 86
     }
87 87
 
88 88
     /**
89
-    * Update the specified resource in storage.
90
-    *
91
-    * @param  int  $id
92
-    * @return Response
93
-    */
89
+     * Update the specified resource in storage.
90
+     *
91
+     * @param  int  $id
92
+     * @return Response
93
+     */
94 94
     public function update($id)
95 95
     {
96 96
         request()->validate([
@@ -103,11 +103,11 @@  discard block
 block discarded – undo
103 103
     }
104 104
 
105 105
     /**
106
-    * Remove the specified resource from storage.
107
-    *
108
-    * @param  int  $id
109
-    * @return Response
110
-    */
106
+     * Remove the specified resource from storage.
107
+     *
108
+     * @param  int  $id
109
+     * @return Response
110
+     */
111 111
     public function destroy($id)
112 112
     {
113 113
         SensorData::find($id)->delete();
Please login to merge, or discard this patch.
app/Http/Controllers/LocationController.php 1 patch
Braces   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -54,9 +54,9 @@  discard block
 block discarded – undo
54 54
             //Create a new site
55 55
             $site = Site::create(['name' => $request->input('new_site_name')]);
56 56
             $site_id = $site->id;
57
+        } else {
58
+                    $site_id = $request->input('site');
57 59
         }
58
-        else
59
-            $site_id = $request->input('site');
60 60
     
61 61
         $location = Location::create(['name' => $request->input('name'), 'site_id' => $site_id]);
62 62
     
@@ -107,9 +107,9 @@  discard block
 block discarded – undo
107 107
             //Create a new site
108 108
             $site = Site::create(['name' => $request->input('new_site_name')]);
109 109
             $site_id = $site->id;
110
+        } else {
111
+                    $site_id = $request->input('site');
110 112
         }
111
-        else
112
-            $site_id = $request->input('site');
113 113
         
114 114
         //Update the location with the supplied name and the site
115 115
         Location::findOrFail($id)->update(['name' => $request->input('name'), 'site_id' => $site_id]);
Please login to merge, or discard this patch.
app/Http/Controllers/SiteController.php 1 patch
Braces   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -66,10 +66,11 @@
 block discarded – undo
66 66
         $site = Site::findOrFail($id);
67 67
         $locations = $site->locations()->orderBy('name', 'ASC')->paginate(15);
68 68
     
69
-        if (\Request::ajax())
70
-            return response()->json(['site' => $site, 'locations' => $locations]);
71
-        else
72
-            return view('site.show', [ 'site' => $site, 'locations' => $locations ]);
69
+        if (\Request::ajax()) {
70
+                    return response()->json(['site' => $site, 'locations' => $locations]);
71
+        } else {
72
+                    return view('site.show', [ 'site' => $site, 'locations' => $locations ]);
73
+        }
73 74
     }
74 75
     
75 76
     /**
Please login to merge, or discard this patch.
app/Http/Controllers/DashboardController.php 1 patch
Braces   +14 added lines, -12 removed lines patch added patch discarded remove patch
@@ -43,13 +43,13 @@  discard block
 block discarded – undo
43 43
             $location = $device->location ?? null;
44 44
             
45 45
             //If the location exists then set the pagination page to be where the device is located
46
-            if ($location != null)
47
-                $request->merge(['page' => $device->dashPageNum(4)]);
46
+            if ($location != null) {
47
+                            $request->merge(['page' => $device->dashPageNum(4)]);
48
+            }
48 49
             $site_id = $location->site_id ?? 0;
49 50
             $location_id = $location->id ?? 0;
50 51
             $device_id = $device->id ?? 0;
51
-        }
52
-        else
52
+        } else
53 53
         {
54 54
             //Get the active site, location, and device ids
55 55
             $site_id = $request->site_id ?? 0;
@@ -83,8 +83,9 @@  discard block
 block discarded – undo
83 83
         {
84 84
             //If the original device with the given device id was not found
85 85
             //Then assign the the first device in the device list as the active device
86
-            if ($active_device == null)
87
-                $active_device = $devices[0];
86
+            if ($active_device == null) {
87
+                            $active_device = $devices[0];
88
+            }
88 89
         
89 90
             //Add an attribute to each device defining if it is stale
90 91
             $devices->transform(function ($item)
@@ -98,9 +99,9 @@  discard block
 block discarded – undo
98 99
                 {
99 100
                     $imageStaleMins = ceil(($item->image_rate * 3) / 60) + 1;
100 101
                     $item['isImageStale'] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
102
+                } else {
103
+                                    $item['isImageStale'] = false;
101 104
                 }
102
-                else
103
-                    $item['isImageStale'] = false;
104 105
                 
105 106
                 return $item;
106 107
             });
@@ -112,12 +113,13 @@  discard block
 block discarded – undo
112 113
         //Use the device_list.blade.php to generate the device table html
113 114
         $html_device_table = view('dashboard.device_list', ['devices' => $devices, 'active_data' => $active_data])->render();
114 115
         
115
-        if (\Request::ajax())
116
-            return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,
116
+        if (\Request::ajax()) {
117
+                    return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,
117 118
                 'sites' => $sites, 'html_device_table' => $html_device_table ]);
118
-        else
119
-            return view('dashboard.index', [ 'active_data' => $active_data, 'devices' => $devices,
119
+        } else {
120
+                    return view('dashboard.index', [ 'active_data' => $active_data, 'devices' => $devices,
120 121
                 'locations' => $locations, 'sites' => $sites ]);
122
+        }
121 123
     }
122 124
     
123 125
     /**
Please login to merge, or discard this patch.
app/Http/Controllers/DeviceController.php 1 patch
Braces   +38 added lines, -28 removed lines patch added patch discarded remove patch
@@ -116,8 +116,9 @@  discard block
 block discarded – undo
116 116
                 //Create a new site
117 117
                 $site = Site::create(['name' => $request->input('new_site_name')]);
118 118
                 $site_id = $site->id;
119
-            } else
120
-                $site_id = $request->input('site_id');
119
+            } else {
120
+                            $site_id = $request->input('site_id');
121
+            }
121 122
     
122 123
             //Get the location id of the old or newly created location
123 124
             if (!empty($request->input('new_location_name')))
@@ -125,53 +126,63 @@  discard block
 block discarded – undo
125 126
                 //Create a new location
126 127
                 $location = Location::create(['name' => $request->input('new_location_name'), 'site_id' => $site_id]);
127 128
                 $location_id = $location->id;
128
-            } else
129
-                $location_id = $request->input('location_id');
129
+            } else {
130
+                            $location_id = $request->input('location_id');
131
+            }
130 132
     
131 133
             //Update the device
132 134
             $device->location_id = $location_id;
133 135
         }
134 136
         
135 137
         //Update the device
136
-        if ($request->input('name') != null)
137
-            $device->name = $request->input('name');
138
-        if ($request->input('open_time') != null)
139
-            $device->open_time = $request->input('open_time');
140
-        if ($request->input('close_time') != null)
141
-            $device->close_time = $request->input('close_time');
142
-        if ($request->input('update_rate') != null)
143
-            $device->update_rate = $request->input('update_rate');
144
-        if ($request->input('image_rate') != null)
145
-            $device->image_rate = $request->input('image_rate');
146
-        if ($request->input('sensor_rate') != null)
147
-            $device->sensor_rate = $request->input('sensor_rate');
138
+        if ($request->input('name') != null) {
139
+                    $device->name = $request->input('name');
140
+        }
141
+        if ($request->input('open_time') != null) {
142
+                    $device->open_time = $request->input('open_time');
143
+        }
144
+        if ($request->input('close_time') != null) {
145
+                    $device->close_time = $request->input('close_time');
146
+        }
147
+        if ($request->input('update_rate') != null) {
148
+                    $device->update_rate = $request->input('update_rate');
149
+        }
150
+        if ($request->input('image_rate') != null) {
151
+                    $device->image_rate = $request->input('image_rate');
152
+        }
153
+        if ($request->input('sensor_rate') != null) {
154
+                    $device->sensor_rate = $request->input('sensor_rate');
155
+        }
148 156
         //Check if the cover_command needs to be updated
149 157
         if ($request->input('command') != null)
150 158
         {
151 159
             //If device is currently opening, closing or in an error state don't update command
152
-            if (!$device->isReadyForCommand())
153
-                return response()->json("Device is currently in use.", 403);
160
+            if (!$device->isReadyForCommand()) {
161
+                            return response()->json("Device is currently in use.", 403);
162
+            }
154 163
     
155 164
             $command = $request->input('command');
156 165
             
157 166
             //If command is to unlock the device then check if the device should be open or closed based on the schedule
158 167
             if ($request->command === 'unlock')
159 168
             {
160
-                if ($device->isDuringScheduleOpen())
161
-                    $command =  'open';
162
-                else
163
-                    $command =  'close';
169
+                if ($device->isDuringScheduleOpen()) {
170
+                                    $command =  'open';
171
+                } else {
172
+                                    $command =  'close';
173
+                }
164 174
             }
165 175
             $device->cover_command = $command;
166 176
         }
167 177
         
168 178
         $device->save();
169 179
     
170
-        if (\Request::ajax())
171
-            return response()->json(['success' => 'Device updated successfully']);
172
-        else
173
-            return redirect()->route('device.show', $id)
180
+        if (\Request::ajax()) {
181
+                    return response()->json(['success' => 'Device updated successfully']);
182
+        } else {
183
+                    return redirect()->route('device.show', $id)
174 184
                 ->with('success', 'Device updated successfully');
185
+        }
175 186
     }
176 187
 
177 188
     /**
@@ -188,8 +199,7 @@  discard block
 block discarded – undo
188 199
         {
189 200
             //If the device was already deleted then permanently delete it
190 201
             $device->forceDelete($device->id);
191
-        }
192
-        else
202
+        } else
193 203
         {
194 204
             //Remove the location from the device
195 205
             $device->location_id = null;
Please login to merge, or discard this patch.
app/Http/Controllers/ApiController.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,8 +68,9 @@
 block discarded – undo
68 68
         $device->mac_address = $request->input('mac_address');
69 69
         $device->time = $request->input('time');
70 70
         $device->cover_status = $request->input('cover_status');
71
-        if ($request->input('cover_command') != null)
72
-            $device->cover_command = $request->input('cover_command');
71
+        if ($request->input('cover_command') != null) {
72
+                    $device->cover_command = $request->input('cover_command');
73
+        }
73 74
         $device->error_msg = $request->input('error_msg');
74 75
         $device->last_network_update_at = Carbon::now();
75 76
         
Please login to merge, or discard this patch.
app/Location.php 1 patch
Braces   +10 added lines, -8 removed lines patch added patch discarded remove patch
@@ -89,10 +89,11 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function getUpdatedAtHumanAttribute()
91 91
     {
92
-        if ($this->updated_at->diffInDays() > 0)
93
-            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
94
-        else
95
-            return $this->updated_at->diffForHumans();
92
+        if ($this->updated_at->diffInDays() > 0) {
93
+                    return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
94
+        } else {
95
+                    return $this->updated_at->diffForHumans();
96
+        }
96 97
     }
97 98
     
98 99
     /**
@@ -107,9 +108,10 @@  discard block
 block discarded – undo
107 108
      */
108 109
     public function getCreatedAtHumanAttribute()
109 110
     {
110
-        if ($this->created_at->diffInDays() > 0)
111
-            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
112
-        else
113
-            return $this->created_at->diffForHumans();
111
+        if ($this->created_at->diffInDays() > 0) {
112
+                    return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
113
+        } else {
114
+                    return $this->created_at->diffForHumans();
115
+        }
114 116
     }
115 117
 }
Please login to merge, or discard this patch.
app/Sensor.php 1 patch
Braces   +10 added lines, -8 removed lines patch added patch discarded remove patch
@@ -145,10 +145,11 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function getUpdatedAtHumanAttribute()
147 147
     {
148
-        if ($this->updated_at->diffInDays() > 0)
149
-            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
150
-        else
151
-            return $this->updated_at->diffForHumans();
148
+        if ($this->updated_at->diffInDays() > 0) {
149
+                    return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
150
+        } else {
151
+                    return $this->updated_at->diffForHumans();
152
+        }
152 153
     }
153 154
     
154 155
     /**
@@ -163,9 +164,10 @@  discard block
 block discarded – undo
163 164
      */
164 165
     public function getCreatedAtHumanAttribute()
165 166
     {
166
-        if ($this->created_at->diffInDays() > 0)
167
-            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
168
-        else
169
-            return $this->created_at->diffForHumans();
167
+        if ($this->created_at->diffInDays() > 0) {
168
+                    return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
169
+        } else {
170
+                    return $this->created_at->diffForHumans();
171
+        }
170 172
     }
171 173
 }
172 174
\ No newline at end of file
Please login to merge, or discard this patch.