Completed
Pull Request — master (#119)
by
unknown
17:56
created
app/DataTables/LocationDataTable.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -15,15 +15,15 @@
 block discarded – undo
15 15
     public function dataTable($query)
16 16
     {
17 17
         return datatables($query)
18
-            ->editColumn('name', function ($location) {
19
-                return '<a href="' . route('location.show', $location->id) . '">'. $location->name . '</a>';
18
+            ->editColumn('name', function($location) {
19
+                return '<a href="'.route('location.show', $location->id).'">'.$location->name.'</a>';
20 20
             })
21
-            ->editColumn('site_id', function ($location) {
22
-                return '<a href="' . route('site.show', $location->site_id) . '">'. ($location->site->name ?? '') . '</a>';
21
+            ->editColumn('site_id', function($location) {
22
+                return '<a href="'.route('site.show', $location->site_id).'">'.($location->site->name ?? '').'</a>';
23 23
             })
24 24
             ->addColumn('action', 'location.action')
25 25
             ->blacklist([ 'action' ])
26
-            ->rawColumns(['site_id', 'name', 'action']);
26
+            ->rawColumns([ 'site_id', 'name', 'action' ]);
27 27
     }
28 28
     
29 29
     /**
Please login to merge, or discard this patch.
app/DataTables/SiteDataTable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -15,12 +15,12 @@
 block discarded – undo
15 15
     public function dataTable($query)
16 16
     {
17 17
         return datatables($query)
18
-            ->editColumn('name', function ($site) {
19
-                return '<a href="' . route('site.show', $site->id) . '">'. $site->name . '</a>';
18
+            ->editColumn('name', function($site) {
19
+                return '<a href="'.route('site.show', $site->id).'">'.$site->name.'</a>';
20 20
             })
21 21
             ->addColumn('action', 'site.action')
22 22
             ->blacklist([ 'action' ])
23
-            ->rawColumns(['name', 'action']);
23
+            ->rawColumns([ 'name', 'action' ]);
24 24
     }
25 25
     
26 26
     /**
Please login to merge, or discard this patch.
app/Http/Controllers/LocationController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -52,13 +52,13 @@  discard block
 block discarded – undo
52 52
         if (!empty($request->input('new_site_name')))
53 53
         {
54 54
             //Create a new site
55
-            $site = Site::create(['name' => $request->input('new_site_name')]);
55
+            $site = Site::create([ 'name' => $request->input('new_site_name') ]);
56 56
             $site_id = $site->id;
57 57
         }
58 58
         else
59 59
             $site_id = $request->input('site');
60 60
     
61
-        $location = Location::create(['name' => $request->input('name'), 'site_id' => $site_id]);
61
+        $location = Location::create([ 'name' => $request->input('name'), 'site_id' => $site_id ]);
62 62
     
63 63
         return redirect()->route('location.show', $location->id)
64 64
             ->with('success', 'Location created successfully');
@@ -105,14 +105,14 @@  discard block
 block discarded – undo
105 105
         if (!empty($request->input('new_site_name')))
106 106
         {
107 107
             //Create a new site
108
-            $site = Site::create(['name' => $request->input('new_site_name')]);
108
+            $site = Site::create([ 'name' => $request->input('new_site_name') ]);
109 109
             $site_id = $site->id;
110 110
         }
111 111
         else
112 112
             $site_id = $request->input('site');
113 113
         
114 114
         //Update the location with the supplied name and the site
115
-        Location::findOrFail($id)->update(['name' => $request->input('name'), 'site_id' => $site_id]);
115
+        Location::findOrFail($id)->update([ 'name' => $request->input('name'), 'site_id' => $site_id ]);
116 116
         
117 117
         return redirect()->route('location.show', $id)
118 118
             ->with('success', 'Location updated successfully');
@@ -128,6 +128,6 @@  discard block
 block discarded – undo
128 128
     {
129 129
         Location::findOrFail($id)->delete();
130 130
         return redirect()->route('location.index')
131
-            ->with('success','Location deleted successfully');
131
+            ->with('success', 'Location deleted successfully');
132 132
     }
133 133
 }
Please login to merge, or discard this patch.
app/User.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
     public function roleString()
144 144
     {
145 145
         $role_en = array(0 => "Registered", 1 => "User", 2 => "Manager", 3 => "Admin");
146
-        return $role_en[ $this->role ] . ' (' . $this->role . ')';
146
+        return $role_en[ $this->role ].' ('.$this->role.')';
147 147
     }
148 148
     
149 149
     /**
Please login to merge, or discard this patch.
app/Http/Controllers/DashboardController.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             
45 45
             //If the location exists then set the pagination page to be where the device is located
46 46
             if ($location != null)
47
-                $request->merge(['page' => $device->dashPageNum(4)]);
47
+                $request->merge([ 'page' => $device->dashPageNum(4) ]);
48 48
             $site_id = $location->site_id ?? 0;
49 49
             $location_id = $location->id ?? 0;
50 50
             $device_id = $device->id ?? 0;
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
             ->get();
65 65
         //Get all locations for the selected site with the selected location first
66 66
         $locations = Location::select('id', 'name', 'site_id')
67
-            ->where('site_id', '=', $sites[0]->id ?? 0)
67
+            ->where('site_id', '=', $sites[ 0 ]->id ?? 0)
68 68
             ->orderByRaw("id = ? DESC", $location_id)
69 69
             ->orderBy('name', 'ASC')
70 70
             ->get();
71 71
         //Get all devices for the selected location
72 72
         $devices = Device::publicDashData()
73 73
             ->leftJoin('deviceimages as image', 'devices.id', '=', 'image.device_id')
74
-            ->where('location_id', '=', $locations[0]->id ?? 0)
74
+            ->where('location_id', '=', $locations[ 0 ]->id ?? 0)
75 75
             ->orderBy('name', 'ASC')
76 76
             ->paginate(4);
77 77
     
@@ -84,33 +84,33 @@  discard block
 block discarded – undo
84 84
             //If the original device with the given device id was not found
85 85
             //Then assign the the first device in the device list as the active device
86 86
             if ($active_device == null)
87
-                $active_device = $devices[0];
87
+                $active_device = $devices[ 0 ];
88 88
         
89 89
             //Add an attribute to each device defining if it is stale
90
-            $devices->transform(function ($item)
90
+            $devices->transform(function($item)
91 91
             {
92 92
                 //Mark the device as stale if the device has missed three updates plus a minute
93 93
                 $deviceStaleMins = ceil(($item->update_rate * 3) / 60) + 1;
94
-                $item['isDeviceStale'] = ($item->last_network_update_at <= Carbon::now()->subMinute($deviceStaleMins)) ? true : false;
94
+                $item[ 'isDeviceStale' ] = ($item->last_network_update_at <= Carbon::now()->subMinute($deviceStaleMins)) ? true : false;
95 95
     
96 96
                 //Mark the device image as stale if the device has missed three image updates plus a minute
97 97
                 if ($item->image_updated_at != null)
98 98
                 {
99 99
                     $imageStaleMins = ceil(($item->image_rate * 3) / 60) + 1;
100
-                    $item['isImageStale'] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
100
+                    $item[ 'isImageStale' ] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
101 101
                 }
102 102
                 else
103
-                    $item['isImageStale'] = false;
103
+                    $item[ 'isImageStale' ] = false;
104 104
                 
105 105
                 return $item;
106 106
             });
107 107
         }
108 108
     
109 109
         //Store the active site, location, and device in a collection
110
-        $active_data = collect(['device' => $active_device, 'location' => $locations[0] ?? null, 'site' => $sites[0] ?? null]);
110
+        $active_data = collect([ 'device' => $active_device, 'location' => $locations[ 0 ] ?? null, 'site' => $sites[ 0 ] ?? null ]);
111 111
     
112 112
         //Use the device_list.blade.php to generate the device table html
113
-        $html_device_table = view('dashboard.device_list', ['devices' => $devices, 'active_data' => $active_data])->render();
113
+        $html_device_table = view('dashboard.device_list', [ 'devices' => $devices, 'active_data' => $active_data ])->render();
114 114
         
115 115
         if (\Request::ajax())
116 116
             return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,
Please login to merge, or discard this patch.
app/Http/Controllers/DeviceController.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
     {
56 56
         $device = Device::findOrFail($id);
57 57
         
58
-        $charts = [];
58
+        $charts = [ ];
59 59
         foreach ($device->sensors as $sensor) {
60 60
             $data = $sensor->last_month_daily_avg_data;
61
-            $charts[$sensor->id] = Charts::create('line', 'highcharts')
61
+            $charts[ $sensor->id ] = Charts::create('line', 'highcharts')
62 62
                 ->title($sensor->name)
63 63
                 ->elementLabel($sensor->type)
64 64
                 ->labels($data->pluck('date'))
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $sites = Site::select('id', 'name')->orderByRaw("id = ? DESC", $site_id)
91 91
             ->orderBy('name', 'ASC')->get();
92 92
         //Get all locations for the selected site with the selected location first
93
-        $locations = Location::select('id', 'name')->where('site_id', '=', $sites[0]->id ?? 0)
93
+        $locations = Location::select('id', 'name')->where('site_id', '=', $sites[ 0 ]->id ?? 0)
94 94
             ->orderByRaw("id = ? DESC", $location_id)->orderBy('name', 'ASC')->get();
95 95
         
96 96
         return view('device.edit', [ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             if (!empty($request->input('new_site_name')))
117 117
             {
118 118
                 //Create a new site
119
-                $site = Site::create(['name' => $request->input('new_site_name')]);
119
+                $site = Site::create([ 'name' => $request->input('new_site_name') ]);
120 120
                 $site_id = $site->id;
121 121
             } else
122 122
                 $site_id = $request->input('site_id');
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             if (!empty($request->input('new_location_name')))
126 126
             {
127 127
                 //Create a new location
128
-                $location = Location::create(['name' => $request->input('new_location_name'), 'site_id' => $site_id]);
128
+                $location = Location::create([ 'name' => $request->input('new_location_name'), 'site_id' => $site_id ]);
129 129
                 $location_id = $location->id;
130 130
             } else
131 131
                 $location_id = $request->input('location_id');
@@ -159,9 +159,9 @@  discard block
 block discarded – undo
159 159
             if ($request->command === 'unlock')
160 160
             {
161 161
                 if ($device->isDuringScheduleOpen())
162
-                    $command =  'open';
162
+                    $command = 'open';
163 163
                 else
164
-                    $command =  'close';
164
+                    $command = 'close';
165 165
             }
166 166
             $device->cover_command = $command;
167 167
         }
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
         $device->save();
170 170
     
171 171
         if (\Request::ajax())
172
-            return response()->json(['success' => 'Device updated successfully']);
172
+            return response()->json([ 'success' => 'Device updated successfully' ]);
173 173
         else
174 174
             return redirect()->route('device.show', $id)
175 175
                 ->with('success', 'Device updated successfully');
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         }
202 202
 
203 203
         return redirect()->route('device.index')
204
-            ->with('success','Device deleted successfully');
204
+            ->with('success', 'Device deleted successfully');
205 205
     }
206 206
     
207 207
     /**
@@ -217,6 +217,6 @@  discard block
 block discarded – undo
217 217
         $device->restore();
218 218
         
219 219
         return redirect()->route('device.show', $device->id)
220
-            ->with('success','Device restored successfully');
220
+            ->with('success', 'Device restored successfully');
221 221
     }
222 222
 }
Please login to merge, or discard this patch.
app/Sensor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
     {
70 70
         return SensorData::whereRaw('id = (SELECT MAX(id)
71 71
                                                     FROM sensor_data
72
-                                                    WHERE sensor_id = ?)', [$this->id])->first() ?? (object)[];
72
+                                                    WHERE sensor_id = ?)', [ $this->id ])->first() ?? (object) [ ];
73 73
     }
74 74
     
75 75
     /**
Please login to merge, or discard this patch.
app/Device.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      *
30 30
      * @var array
31 31
      */
32
-    protected $hidden = ['token'];
32
+    protected $hidden = [ 'token' ];
33 33
     
34 34
     /**
35 35
      * The attributes that are mass assignable.
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      *
49 49
      * @var array
50 50
      */
51
-    protected static $ignoreChangedAttributes = ['updated_at', 'last_network_update_at'];
51
+    protected static $ignoreChangedAttributes = [ 'updated_at', 'last_network_update_at' ];
52 52
     
53 53
     /**
54 54
      * The attributes to log in the Activity Log
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
      */
90 90
     public function getSiteAttribute()
91 91
     {
92
-        return $this->location->site ?? (object)[];
92
+        return $this->location->site ?? (object) [ ];
93 93
     }
94 94
     
95 95
     /**
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      */
120 120
     public function getOpenTimeHumanAttribute()
121 121
     {
122
-        $time = new Carbon($this->attributes['open_time'], 'UTC');
122
+        $time = new Carbon($this->attributes[ 'open_time' ], 'UTC');
123 123
         $time = $time->setTimezone(Auth::user()->timezone);
124 124
         
125 125
         return $time->format('h:i a');
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
      */
153 153
     public function getCloseTimeHumanAttribute()
154 154
     {
155
-        $time = new Carbon($this->attributes['close_time'], 'UTC');
155
+        $time = new Carbon($this->attributes[ 'close_time' ], 'UTC');
156 156
         $time = $time->setTimezone(Auth::user()->timezone);
157 157
         
158 158
         return $time->format('h:i a');
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         else
178 178
             $time = new Carbon($value, 'UTC');
179 179
         
180
-        $this->attributes['open_time'] = $time->format('H:i:s');
180
+        $this->attributes[ 'open_time' ] = $time->format('H:i:s');
181 181
     }
182 182
     
183 183
     /**
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
         else
200 200
             $time = new Carbon($value, 'UTC');
201 201
         
202
-        $this->attributes['close_time'] = $time->format('H:i:s');
202
+        $this->attributes[ 'close_time' ] = $time->format('H:i:s');
203 203
     }
204 204
     
205 205
     /**
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
         $isClosed = $this->cover_status === 'closed';
372 372
         $isLocked = $this->cover_status === 'locked';
373 373
             
374
-        switch ($this['cover_command'])
374
+        switch ($this[ 'cover_command' ])
375 375
         {
376 376
             case 'open':
377 377
                 if ($isOpen)
Please login to merge, or discard this patch.
app/Http/Requests/EditLocation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,11 +38,11 @@
 block discarded – undo
38 38
     {
39 39
         $validator = parent::getValidatorInstance();
40 40
         
41
-        $validator->sometimes('site', 'integer|digits_between:1,10|exists:sites,id', function ($input) {
41
+        $validator->sometimes('site', 'integer|digits_between:1,10|exists:sites,id', function($input) {
42 42
             return !$input->new_site_name && $input->site;
43 43
         });
44 44
         
45
-        $validator->sometimes('new_site_name', 'bail|min:2|max:190|name|unique:sites,name', function ($input) {
45
+        $validator->sometimes('new_site_name', 'bail|min:2|max:190|name|unique:sites,name', function($input) {
46 46
             return !$input->site;
47 47
         });
48 48
         
Please login to merge, or discard this patch.