App\Http\Controllers\SensorDataController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	107
Duplicated Lines	11.21 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	3	1
A	edit()	0	5	1
A	store()	11	11	1
A	__construct()	0	3	1
A	show()	0	5	1
A	create()	0	3	1
A	update()	0	9	1
A	destroy()	0	5	1

<?php 

namespace App\Http\Controllers;

use App\SensorData;
use App\DataTables\SensorDataDataTable;
use Illuminate\Http\Request;

class SensorDataController extends Controller 
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @param SensorDataDataTable $dataTable
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(SensorDataDataTable $dataTable)
    {
        return $dataTable->render('sensordata.index');

The expression return $dataTable->render('sensordata.index') also could return the type Illuminate\View\View|callable which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return Response
     */
    public function create()
    {
        return view('sensordata.create');

The expression return view('sensordata.create') returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     * @return Response
     */
    public function store(Request $request)
    {
        request()->validate([
            'sensor_id' => 'required|integer|digits_between:1,10|exists:sensors,id',
            'value' => 'required|max:190|value_string'
        ]);

        $query = SensorData::create($request->all());

        return redirect()->route('sensordata.show', $query->id)

$query->id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

The expression return redirect()->route('sensordata.show', $query->id)->with('success', 'SensorData created successfully') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

            ->with('success', 'SensorData created successfully');
    }

    /**
     * Display the specified resource.
     *
     * @param  Request  $request
     * @param  int  $id
     * @return Response
     */
    public function show(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $sensordata = SensorData::findOrFail($id);

        return view('sensordata.show', [ 'sensordata' => $sensordata ]);

The expression return view('sensordata.show', array('sensordata' => $sensordata)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return Response
     */
    public function edit(Request $request, $id)
    {
        $sensordata = SensorData::findOrFail($id);
        
        return view('sensordata.edit', [ 'sensordata' => $sensordata ]);

The expression return view('sensordata.edit', array('sensordata' => $sensordata)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  int  $id
     * @return Response
     */
    public function update($id)
    {
        request()->validate([
            'sensor_id' => 'required|integer|digits_between:1,10|exists:sensors,id',
            'value' => 'required|max:190|value_string'
        ]);
        $query = SensorData::findOrFail($id)->update($request->all());

The variable $request seems to be never defined.

The assignment to $query is dead and can be removed.

        return redirect()->route('sensordata.show', $id)

The expression return redirect()->route('sensordata.show', $id)->with('success', 'SensorData updated successfully') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

$id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

            ->with('success', 'SensorData updated successfully');    
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return Response
     */
    public function destroy($id)
    {
        SensorData::find($id)->delete();
        return redirect()->route('sensordata.index')

The expression return redirect()->route('sensordata.index')->with('success', 'SensorData deleted successfully') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

            ->with('success', 'SensorData deleted successfully');
    }

}