ActivityLogDataTable::getRouteFromType() - Code Metrics - Inspection of "Activity Log: Support links for all causer and sub..." - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#120)

by Brandon

created 2017-11-21 03:02 UTC

ActivityLogDataTable::getRouteFromType() B

↳ Parent: ActivityLogDataTable

Complexity

Conditions	8
Paths	8

Size

Total Lines	20
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
ccs	0
cts	16
cp	0
rs	7.7777
cc	8
eloc	18
nc	8
nop	1
crap	72

<?php

namespace App\DataTables;

use App\User;
use Illuminate\Support\Facades\Auth;
use Yajra\DataTables\Services\DataTable;
use Spatie\Activitylog\Models\Activity;

class ActivityLogDataTable extends DataTable
{
    /**
     * Build DataTable class.
     *
     * @return \Yajra\DataTables\DataTableAbstract
     */
    public function dataTable($query)
    {
        return datatables($query)
            ->editColumn('causer_id', function ($activity) {
                if ($activity->causer_id) {
                    return '<a href="' . route($this->getRouteFromType($activity->causer_type), $activity->causer_id) . '">' . $activity->causer->name ?? '' . '</a>';
                } else {
                    return '';
                }
            })
            ->editColumn('subject_id', function ($activity) {
                if ($activity->subject_id) {
                    return '<a href="' . route($this->getRouteFromType($activity->subject_type), $activity->subject_id) . '">' . $activity->subject->name ?? '' . '</a>';
                } else {
                    return '';
                }
            })
            ->editColumn('properties', function ($activity) {
                return $activity->properties;
            })
            ->editColumn('created_at', function ($activity) {
                if ($activity->created_at->diffInDays() > 0)
                    return $activity->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                else
                    return $activity->created_at->diffForHumans();
            })
            ->rawColumns(['causer_id', 'subject_id', 'properties']);
    }
    
    public function getRouteFromType($type) {
        switch ($type) {
            case "App\Device":
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return 'device.show';
            case "App\Deviceimage":
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return 'image.device';
            case "App\Location":
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return 'location.show';
            case "App\Sensor":
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return 'sensor.show';
            case "App\SensorData":
                return 'sensordata.show';
            case "App\Site":
                return 'site.show';
            case "App\User":
                return 'user.show';
            default:
                return 'logs';
        }
    }

    /**
     * Get query source of dataTable.
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $query = Activity::query();
        return $this->applyScopes($query);

    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\DataTables\Html\Builder
     */
    public function html()
    {
        return $this->builder()
            ->columns($this->getColumns())
            ->minifiedAjax()
            ->parameters($this->getBuilderParameters());
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns()
    {
        return [
            'created_at',
            [ 'name' => 'causer_id', 'data' => 'causer_id', 'title' => 'Actor', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'description', 'data' => 'description', 'title' => 'Action', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'subject_id', 'data' => 'subject_id', 'title' => 'Subject', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'properties', 'data' => 'properties', 'title' => 'Changes', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ]
        ];
    }
    
    /**
     * Get builder parameters.
     *
     * @return array
     */
    protected function getBuilderParameters()
    {
        return [
            'dom'     => 'Bfrtip',
            'order'   => [ [ 0, 'desc' ] ],
            'buttons' => [
                [ 'extend' => 'collection', 'text' => '<i class="fa fa-file-excel-o"></i> Export', 'buttons' => [ 
                    [ 'extend' => 'csv', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
                    [ 'extend' => 'excel', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
                ] ],
                [ 'extend' => 'print', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
                'reset',
                'reload',
            ],
            'paging' => true,
            'searching' => true,
            'info' => true,
            'searchDelay' => 500,
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'activitylog_' . time();
    }
}


1		<?php
2
3		namespace App\DataTables;
4
5		use App\User;
6		use Illuminate\Support\Facades\Auth;
7		use Yajra\DataTables\Services\DataTable;
8		use Spatie\Activitylog\Models\Activity;
9
10		class ActivityLogDataTable extends DataTable
11		{
12		/**
13		* Build DataTable class.
14		*
15		* @return \Yajra\DataTables\DataTableAbstract
16		*/
17		public function dataTable($query)
18		{
19		return datatables($query)
20		->editColumn('causer_id', function ($activity) {
21		if ($activity->causer_id) {
22		return '<a href="' . route($this->getRouteFromType($activity->causer_type), $activity->causer_id) . '">' . $activity->causer->name ?? '' . '</a>';
23		} else {
24		return '';
25		}
26		})
27		->editColumn('subject_id', function ($activity) {
28		if ($activity->subject_id) {
29		return '<a href="' . route($this->getRouteFromType($activity->subject_type), $activity->subject_id) . '">' . $activity->subject->name ?? '' . '</a>';
30		} else {
31		return '';
32		}
33		})
34		->editColumn('properties', function ($activity) {
35		return $activity->properties;
36		})
37		->editColumn('created_at', function ($activity) {
38		if ($activity->created_at->diffInDays() > 0)
39		return $activity->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
		0 ignored issues – show Bug introduced 2017-11-11 00:31 UTC by Report Bug Copy Issue Report Accessing `timezone` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
40		else
41		return $activity->created_at->diffForHumans();
42		})
43		->rawColumns(['causer_id', 'subject_id', 'properties']);
44		}
45
46		public function getRouteFromType($type) {
47		switch ($type) {
48		case "App\Device":
		0 ignored issues – show Coding Style introduced 2017-11-21 03:04 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
49		return 'device.show';
50		case "App\Deviceimage":
		0 ignored issues – show Coding Style introduced 2017-11-21 03:04 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
51		return 'image.device';
52		case "App\Location":
		0 ignored issues – show Coding Style introduced 2017-11-21 03:04 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
53		return 'location.show';
54		case "App\Sensor":
		0 ignored issues – show Coding Style introduced 2017-11-21 03:04 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
55		return 'sensor.show';
56		case "App\SensorData":
57		return 'sensordata.show';
58		case "App\Site":
59		return 'site.show';
60		case "App\User":
61		return 'user.show';
62		default:
63		return 'logs';
64		}
65		}
66
67		/**
68		* Get query source of dataTable.
69		*
70		* @return \Illuminate\Database\Eloquent\Builder
71		*/
72		public function query()
73		{
74		$query = Activity::query();
75		return $this->applyScopes($query);
		0 ignored issues – show Bug Compatibility introduced 2017-10-09 09:31 UTC by Report Bug Copy Issue Report The expression `$this->applyScopes($query);` of type `Illuminate\Database\Quer...tabase\Eloquent\Builder` adds the type `Illuminate\Database\Query\Builder` to the return on line 75 which is incompatible with the return type documented by `App\DataTables\ActivityLogDataTable::query` of type `Illuminate\Database\Eloquent\Builder`. Loading history...
76		}
77
78		/**
79		* Optional method if you want to use html builder.
80		*
81		* @return \Yajra\DataTables\Html\Builder
82		*/
83		public function html()
84		{
85		return $this->builder()
86		->columns($this->getColumns())
87		->minifiedAjax()
88		->parameters($this->getBuilderParameters());
89		}
90
91		/**
92		* Get columns.
93		*
94		* @return array
95		*/
96		protected function getColumns()
97		{
98		return [
99		'created_at',
100		[ 'name' => 'causer_id', 'data' => 'causer_id', 'title' => 'Actor', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
101		[ 'name' => 'description', 'data' => 'description', 'title' => 'Action', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
102		[ 'name' => 'subject_id', 'data' => 'subject_id', 'title' => 'Subject', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
103		[ 'name' => 'properties', 'data' => 'properties', 'title' => 'Changes', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ]
104		];
105		}
106
107		/**
108		* Get builder parameters.
109		*
110		* @return array
111		*/
112	View Code Duplication	protected function getBuilderParameters()
113		{
114		return [
115		'dom' => 'Bfrtip',
116		'order' => [ [ 0, 'desc' ] ],
117		'buttons' => [
118		[ 'extend' => 'collection', 'text' => '<i class="fa fa-file-excel-o"></i> Export', 'buttons' => [
119		[ 'extend' => 'csv', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
120		[ 'extend' => 'excel', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
121		] ],
122		[ 'extend' => 'print', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
123		'reset',
124		'reload',
125		],
126		'paging' => true,
127		'searching' => true,
128		'info' => true,
129		'searchDelay' => 500,
130		];
131		}
132
133		/**
134		* Get filename for export.
135		*
136		* @return string
137		*/
138		protected function filename()
139		{
140		return 'activitylog_' . time();
141		}
142		}
143

uidaho / smartsettia

Pull Request — master (#120)

ActivityLogDataTable::getRouteFromType() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like