Completed
Pull Request — master (#78)
by Brandon
02:00
created
app/Http/Controllers/ImageController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         if (Storage::disk('private')->exists('deviceimage/'.$device_id)) {
31 31
             $image = Image::make(Storage::disk('private')->get('deviceimage/'.$device_id));
32 32
         } else {
33
-            $image = Image::make(public_path() . '/img/video_not_found.jpg');
33
+            $image = Image::make(public_path().'/img/video_not_found.jpg');
34 34
         }
35 35
         
36 36
         return $image->response();
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public function store($device_id, $binaryData)
47 47
     {
48
-        $storagePath = storage_path('app/private/deviceimage/') . $device_id;
48
+        $storagePath = storage_path('app/private/deviceimage/').$device_id;
49 49
         $image = Image::make($binaryData);
50 50
         $image->save($storagePath, 75);
51 51
     }
Please login to merge, or discard this patch.
app/Http/Controllers/ApiController.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
      */    
19 19
     public function index()
20 20
     {
21
-        return response()->json(['data' => 'SmartSettia API - Bad request type.'], 400);
21
+        return response()->json([ 'data' => 'SmartSettia API - Bad request type.' ], 400);
22 22
     }
23 23
 
24 24
     /**
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         
63 63
         // If validation fails, send the validation error back with status 400.
64 64
         if ($validator->fails()) {
65
-            return response()->json(['data' => $validator->errors()], 400);
65
+            return response()->json([ 'data' => $validator->errors() ], 400);
66 66
         }
67 67
         
68 68
         // Get the device record.
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         
71 71
         // If token doesnt match then send 401 unauthorized.
72 72
         if ($request->input('token') != $device->token) {
73
-            return response()->json(['data' => 'Bad token.'], 401);
73
+            return response()->json([ 'data' => 'Bad token.' ], 401);
74 74
         }
75 75
         
76 76
         // Update the device.
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         //event(new Registered(true));
101 101
         
102 102
         // Return the new device info including the token.
103
-        return response()->json(['data' => $device->toArray()], 201);
103
+        return response()->json([ 'data' => $device->toArray() ], 201);
104 104
     }
105 105
     
106 106
     /**
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         
120 120
         // If validation fails, send the validation error back with status 400.
121 121
         if ($validator->fails()) {
122
-            return response()->json(['data' => $validator->errors()], 400);
122
+            return response()->json([ 'data' => $validator->errors() ], 400);
123 123
         }
124 124
         
125 125
         // If challenge string doesnt match then send 401 unauthorized.
126 126
         if ($request->input('challenge') != env('API_CHALLENGE', 'temppass')) {
127
-            return response()->json(['data' => 'Bad challenge.'], 401);
127
+            return response()->json([ 'data' => 'Bad challenge.' ], 401);
128 128
         }
129 129
         
130 130
         // If the uuid already exists then just send them the record.
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
                 'uuid' => $device->uuid,
135 135
                 'id' => $device->id,
136 136
                 'token' => $device->token,
137
-            ]], 200);
137
+            ] ], 200);
138 138
         }
139 139
         
140 140
         // Create the new device.
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
             'uuid' => $device->uuid,
158 158
             'id' => $device->id,
159 159
             'token' => $device->token,
160
-        ]], 201);
160
+        ] ], 201);
161 161
     }
162 162
     
163 163
     /**
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         
177 177
         // If validation fails, send the validation error back with status 400.
178 178
         if ($validator->fails()) {
179
-            return response()->json(['data' => $validator->errors()], 400);
179
+            return response()->json([ 'data' => $validator->errors() ], 400);
180 180
         }
181 181
         
182 182
         // Get the device record.
@@ -184,25 +184,25 @@  discard block
 block discarded – undo
184 184
         
185 185
         // If token doesnt match then send 401 unauthorized.
186 186
         if ($request->input('token') != $device->token) {
187
-            return response()->json(['data' => 'Bad token.'], 401);
187
+            return response()->json([ 'data' => 'Bad token.' ], 401);
188 188
         }
189 189
         
190 190
         // Save the image to disk.
191
-        $path = $request->file('image')->storeAs('deviceimage', $device['id'], 'private');
191
+        $path = $request->file('image')->storeAs('deviceimage', $device[ 'id' ], 'private');
192 192
         
193 193
         // Update the url for the image.
194 194
         $deviceimage = Deviceimage::updateOrCreate(
195
-            ['device_id' => $device['id']],
196
-            ['url' => $path]
195
+            [ 'device_id' => $device[ 'id' ] ],
196
+            [ 'url' => $path ]
197 197
         );
198 198
         
199 199
         // Force the updated_at timestamp to update as the url may not change.
200 200
         $deviceimage->touch();
201 201
         
202 202
         return response()->json([ 'data' => [ 
203
-            'id' => $deviceimage['id'],
203
+            'id' => $deviceimage[ 'id' ],
204 204
             'url' => $path,
205
-        ]], 201);
205
+        ] ], 201);
206 206
     }
207 207
 }
208 208
 
Please login to merge, or discard this patch.
app/Site.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      *
25 25
      * @var array
26 26
      */
27
-    protected static $ignoreChangedAttributes = ['updated_at'];
27
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
28 28
     
29 29
     /**
30 30
      * The attributes to log in the Activity Log
Please login to merge, or discard this patch.
app/DataTables/DevicesDataTable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     {
18 18
         return datatables($query)
19 19
             ->addColumn('action', 'device.action')
20
-            ->blacklist([ 'action'])
20
+            ->blacklist([ 'action' ])
21 21
             ->setRowClass(function($device) {
22 22
                 return $device->trashed() ? 'alert-danger' : "";
23 23
             });
Please login to merge, or discard this patch.
app/Device.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      *
30 30
      * @var array
31 31
      */
32
-    protected $hidden = ['token'];
32
+    protected $hidden = [ 'token' ];
33 33
     
34 34
     /**
35 35
      * The attributes that are mass assignable.
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      *
49 49
      * @var array
50 50
      */
51
-    protected static $ignoreChangedAttributes = ['updated_at'];
51
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
52 52
     
53 53
     /**
54 54
      * The attributes to log in the Activity Log
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
         else
150 150
             $time = new Carbon($value, 'UTC');
151 151
         
152
-        $this->attributes['open_time'] = $time;
152
+        $this->attributes[ 'open_time' ] = $time;
153 153
     }
154 154
     
155 155
     /**
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         else
172 172
             $time = new Carbon($value, 'UTC');
173 173
         
174
-        $this->attributes['close_time'] = $time;
174
+        $this->attributes[ 'close_time' ] = $time;
175 175
     }
176 176
     
177 177
     /**
Please login to merge, or discard this patch.
app/Location.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      *
25 25
      * @var array
26 26
      */
27
-    protected static $ignoreChangedAttributes = ['updated_at'];
27
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
28 28
     
29 29
     /**
30 30
      * The attributes to log in the Activity Log
Please login to merge, or discard this patch.
app/Deviceimage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      *
25 25
      * @var array
26 26
      */
27
-    protected static $ignoreChangedAttributes = ['updated_at'];
27
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
28 28
     
29 29
     /**
30 30
      * The attributes to log in the Activity Log
Please login to merge, or discard this patch.
app/Http/Controllers/DashboardController.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
             //Get the first device that doesn't have a null location_id
36 36
             $device = Device::publicDashData()->where('location_id', '!=', 'null')->orderBy('id', 'ASC')->first();
37 37
         }
38
-        catch(ModelNotFoundException $e)
38
+        catch (ModelNotFoundException $e)
39 39
         {
40 40
             //If no device is found then redirect the user to the home page and display a message about registering a device
41 41
             return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     
49 49
         $data = $this->dashData($site, $location, $device);
50 50
         
51
-        return view('dashboard.index', [ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
51
+        return view('dashboard.index', [ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
52 52
     }
53 53
     
54 54
     /**
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
                 //Get the first site and if no sites exist throw an error
93 93
                 $site = Site::select('id', 'name')->firstOrFail();
94 94
             }
95
-            catch(ModelNotFoundException $e)
95
+            catch (ModelNotFoundException $e)
96 96
             {
97 97
                 //If no device is found then redirect the user to the home page and display a message about registering a device
98 98
                 return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         
119 119
         $data = $this->dashData($site, $location, $device);
120 120
         
121
-        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
121
+        return response()->json([ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
122 122
     }
123 123
     
124 124
     /**
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         
139 139
         $data = $this->dashData($site, $location, $device);
140 140
         
141
-        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
141
+        return response()->json([ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
142 142
     }
143 143
     
144 144
     /**
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         
159 159
         $data = $this->dashData($site, $location, $device);
160 160
         
161
-        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
161
+        return response()->json([ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
162 162
     }
163 163
     
164 164
     /**
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
         //Get all the devices that belong to the given location ordered by name
181 181
         $devices = $location->devices()->publicDashData()->orderBy('name', 'ASC')->get();
182 182
         
183
-        $active_device = collect([$device, $location, $site]);
183
+        $active_device = collect([ $device, $location, $site ]);
184 184
         
185
-        return collect([$active_device, $devices, $locations, $sites]);
185
+        return collect([ $active_device, $devices, $locations, $sites ]);
186 186
     }
187 187
     
188 188
     /**
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
             return response()->json("Device is currently in use.", 403);
204 204
         
205 205
         //1 = open, 2 = close, 3 = lock
206
-        switch($request->command)
206
+        switch ($request->command)
207 207
         {
208 208
             case 1:
209 209
                 $device->cover_command = 'open';
@@ -239,12 +239,12 @@  discard block
 block discarded – undo
239 239
             
240 240
             //Check if the current time is during the open schedule or not
241 241
             if (($time_now > $open_time) && ($time_now < $close_time))
242
-                $command =  'open';
242
+                $command = 'open';
243 243
             else
244
-                $command =  'close';
244
+                $command = 'close';
245 245
         }
246 246
         else
247
-            $command =  'lock';
247
+            $command = 'lock';
248 248
         
249 249
         return $command;
250 250
     }
Please login to merge, or discard this patch.
app/DataTables/ActivityLogDataTable.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,24 +16,24 @@  discard block
 block discarded – undo
16 16
     public function dataTable($query)
17 17
     {
18 18
         return datatables($query)
19
-            ->editColumn('causer_id', function ($activity) {
19
+            ->editColumn('causer_id', function($activity) {
20 20
                 if ($activity->causer_id) {
21
-                    return '<a href="/' . ($activity->causer_type == "App\User" ? 'user' : 'device') . '/' . $activity->causer_id . '">' . $activity->causer->name . '</a>';
21
+                    return '<a href="/'.($activity->causer_type == "App\User" ? 'user' : 'device').'/'.$activity->causer_id.'">'.$activity->causer->name.'</a>';
22 22
                 } else {
23 23
                     return 'Application';
24 24
                 }
25 25
             })
26
-            ->editColumn('subject_id', function ($activity) {
26
+            ->editColumn('subject_id', function($activity) {
27 27
                 if ($activity->subject_id) {
28
-                    return '<a href="/' . ($activity->subject_type == "App\User" ? 'user' : 'device') . '/' . $activity->subject_id . '">' . $activity->subject->name . '</a>';
28
+                    return '<a href="/'.($activity->subject_type == "App\User" ? 'user' : 'device').'/'.$activity->subject_id.'">'.$activity->subject->name.'</a>';
29 29
                 } else {
30 30
                     return 'None';
31 31
                 }
32 32
             })
33
-            ->editColumn('properties', function ($activity) {
33
+            ->editColumn('properties', function($activity) {
34 34
                 return $activity->properties;
35 35
             })
36
-            ->rawColumns(['causer_id', 'subject_id', 'properties']);
36
+            ->rawColumns([ 'causer_id', 'subject_id', 'properties' ]);
37 37
     }
38 38
 
39 39
     /**
@@ -106,6 +106,6 @@  discard block
 block discarded – undo
106 106
      */
107 107
     protected function filename()
108 108
     {
109
-        return 'activitylog_' . time();
109
+        return 'activitylog_'.time();
110 110
     }
111 111
 }
Please login to merge, or discard this patch.