Completed
Pull Request — master (#78)
by Brandon
02:00
created
app/Device.php 1 patch
Braces   +10 added lines, -8 removed lines patch added patch discarded remove patch
@@ -75,8 +75,9 @@  discard block
 block discarded – undo
75 75
         $time = new Carbon($value, 'UTC');
76 76
         
77 77
         //If the user is logged in then use there preferred timezone
78
-        if (Auth::check())
79
-            $time = $time->setTimezone(Auth::user()->timezone);
78
+        if (Auth::check()) {
79
+                    $time = $time->setTimezone(Auth::user()->timezone);
80
+        }
80 81
 
81 82
         return $time->format('H:i');
82 83
     }
@@ -94,8 +95,9 @@  discard block
 block discarded – undo
94 95
         $time = new Carbon($value, 'UTC');
95 96
     
96 97
         //If the user is logged in then use there preferred timezone
97
-        if (Auth::check())
98
-            $time = $time->setTimezone(Auth::user()->timezone);
98
+        if (Auth::check()) {
99
+                    $time = $time->setTimezone(Auth::user()->timezone);
100
+        }
99 101
         
100 102
         return $time->format('H:i');
101 103
     }
@@ -115,9 +117,9 @@  discard block
 block discarded – undo
115 117
         {
116 118
             $time = new Carbon($value, Auth::user()->timezone);
117 119
             $time = $time->setTimezone('UTC');
120
+        } else {
121
+                    $time = new Carbon($value, 'UTC');
118 122
         }
119
-        else
120
-            $time = new Carbon($value, 'UTC');
121 123
         
122 124
         $this->attributes['open_time'] = $time;
123 125
     }
@@ -137,9 +139,9 @@  discard block
 block discarded – undo
137 139
         {
138 140
             $time = new Carbon($value, Auth::user()->timezone);
139 141
             $time = $time->setTimezone('UTC');
142
+        } else {
143
+                    $time = new Carbon($value, 'UTC');
140 144
         }
141
-        else
142
-            $time = new Carbon($value, 'UTC');
143 145
         
144 146
         $this->attributes['close_time'] = $time;
145 147
     }
Please login to merge, or discard this patch.
app/Http/Controllers/DeviceController.php 1 patch
Braces   +17 added lines, -18 removed lines patch added patch discarded remove patch
@@ -84,8 +84,7 @@  discard block
 block discarded – undo
84 84
             $sites->prepend($location->site);
85 85
             //Add the current location to the front of the collection of locations
86 86
             $locations->prepend($location);
87
-        }
88
-        else
87
+        } else
89 88
         {
90 89
             //Set locations to null since there is no site or location attached to the selected device
91 90
             $locations = null;
@@ -93,10 +92,11 @@  discard block
 block discarded – undo
93 92
             $sites = Site::all();
94 93
         }
95 94
         
96
-        if (\Request::ajax())
97
-            return response()->json([ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
98
-        else
99
-            return view('device.edit', [ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
95
+        if (\Request::ajax()) {
96
+                    return response()->json([ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
97
+        } else {
98
+                    return view('device.edit', [ 'device' => $device, 'locations' => $locations, 'sites' => $sites ]);
99
+        }
100 100
     }
101 101
     
102 102
     /**
@@ -110,8 +110,9 @@  discard block
 block discarded – undo
110 110
     {
111 111
         $locations = Location::bySite($site_id)->select('id', 'name', 'site_id')->get();
112 112
         
113
-        if ($locations->isEmpty())
114
-            $locations = null;
113
+        if ($locations->isEmpty()) {
114
+                    $locations = null;
115
+        }
115 116
     
116 117
         return response()->json($locations);
117 118
     }
@@ -151,8 +152,7 @@  discard block
 block discarded – undo
151 152
             //Create a new site
152 153
             $siteName = $request->input('new_site_name');
153 154
             $site_id = Site::createSite($siteName)->id;
154
-        }
155
-        else
155
+        } else
156 156
         {
157 157
             $site_id = $request->input('site');
158 158
         }
@@ -166,8 +166,7 @@  discard block
 block discarded – undo
166 166
             //Create a new location
167 167
             $locationName = $request->input('new_location_name');
168 168
             $location_id = Location::createLocation($locationName, $site_id)->id;
169
-        }
170
-        else
169
+        } else
171 170
         {
172 171
             $location_id = $request->input('location');
173 172
         }
@@ -188,10 +187,11 @@  discard block
 block discarded – undo
188 187
         //Remove any unused sites or locations
189 188
         $this->RemoveUnusedSiteLoc();
190 189
     
191
-        if (\Request::ajax())
192
-            return response()->json("Success");
193
-        else
194
-            return redirect('device');
190
+        if (\Request::ajax()) {
191
+                    return response()->json("Success");
192
+        } else {
193
+                    return redirect('device');
194
+        }
195 195
     }
196 196
 
197 197
     /**
@@ -208,8 +208,7 @@  discard block
 block discarded – undo
208 208
         {
209 209
             //If the device was already deleted then permanently delete it
210 210
             Device::destroy($id);
211
-        }
212
-        else
211
+        } else
213 212
         {
214 213
             //Remove the location from the device
215 214
             $device->location_id = null;
Please login to merge, or discard this patch.
app/Http/Controllers/DashboardController.php 1 patch
Braces   +21 added lines, -17 removed lines patch added patch discarded remove patch
@@ -34,8 +34,7 @@  discard block
 block discarded – undo
34 34
             //Todo use the users preferred device
35 35
             //Get the first device that doesn't have a null location_id
36 36
             $device = Device::publicDashData()->where('location_id', '!=', 'null')->orderBy('id', 'ASC')->first();
37
-        }
38
-        catch(ModelNotFoundException $e)
37
+        } catch(ModelNotFoundException $e)
39 38
         {
40 39
             //If no device is found then redirect the user to the home page and display a message about registering a device
41 40
             return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -85,14 +84,15 @@  discard block
 block discarded – undo
85 84
         //Get the given device if it is still at the same location
86 85
         $device = Device::publicDashData()->where('location_id', '=', $request->location_id)->find($request->device_id);
87 86
         
88
-        if (empty($site))                 //Check if the site still exists
87
+        if (empty($site)) {
88
+            //Check if the site still exists
89 89
         {
90 90
             try
91 91
             {
92 92
                 //Get the first site and if no sites exist throw an error
93 93
                 $site = Site::select('id', 'name')->firstOrFail();
94
-            }
95
-            catch(ModelNotFoundException $e)
94
+        }
95
+            } catch(ModelNotFoundException $e)
96 96
             {
97 97
                 //If no device is found then redirect the user to the home page and display a message about registering a device
98 98
                 return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -102,19 +102,21 @@  discard block
 block discarded – undo
102 102
             $location = $site->locations()->select('id', 'name', 'site_id')->firstOrFail();
103 103
             //Get the first device from the location
104 104
             $device = $location->devices()->publicDashData()->firstOrFail();
105
-        }
106
-        else if (empty($location))        //Check if the location still exists
105
+        } else if (empty($location)) {
106
+            //Check if the location still exists
107 107
         {
108 108
             //Get the first location from the given site
109 109
             $location = $site->locations()->select('id', 'name', 'site_id')->firstOrFail();
110
+        }
110 111
             //Get the first device from the location
111 112
             $device = $location->devices()->publicDashData()->firstOrFail();
112
-        }
113
-        else if (empty($device))        //Check if the device still exists at the given location
113
+        } else if (empty($device)) {
114
+            //Check if the device still exists at the given location
114 115
         {
115 116
             //Get the first device from the location
116 117
             $device = $location->devices()->publicDashData()->firstOrFail();
117 118
         }
119
+        }
118 120
         
119 121
         $data = $this->dashData($site, $location, $device);
120 122
         
@@ -199,8 +201,9 @@  discard block
 block discarded – undo
199 201
         ])->validate();
200 202
         
201 203
         //Check that device isn't currently in use or has an error
202
-        if ($device->cover_status === 'opening' || $device->cover_status === 'closing' || $device->cover_status === 'error')
203
-            return response()->json("Device is currently in use.", 403);
204
+        if ($device->cover_status === 'opening' || $device->cover_status === 'closing' || $device->cover_status === 'error') {
205
+                    return response()->json("Device is currently in use.", 403);
206
+        }
204 207
         
205 208
         //1 = open, 2 = close, 3 = lock
206 209
         switch($request->command)
@@ -238,13 +241,14 @@  discard block
 block discarded – undo
238 241
             $time_now = Carbon::now(Auth::user()->timezone);
239 242
             
240 243
             //Check if the current time is during the open schedule or not
241
-            if (($time_now > $open_time) && ($time_now < $close_time))
242
-                $command =  'open';
243
-            else
244
-                $command =  'close';
244
+            if (($time_now > $open_time) && ($time_now < $close_time)) {
245
+                            $command =  'open';
246
+            } else {
247
+                            $command =  'close';
248
+            }
249
+        } else {
250
+                    $command =  'lock';
245 251
         }
246
-        else
247
-            $command =  'lock';
248 252
         
249 253
         return $command;
250 254
     }
Please login to merge, or discard this patch.