SensorDataTable::filename() - Code Metrics - Inspection of "Api sensors" - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#82)

by Brandon

created 2017-10-16 02:52 UTC

SensorDataTable::filename() A

↳ Parent: SensorDataTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace App\DataTables;

use Yajra\DataTables\Services\DataTable;
use App\Sensor;

class SensorDataTable extends DataTable
{
    /**
     * Build DataTable class.
     *
     * @return \Yajra\DataTables\Engines\BaseEngine
     */
    public function dataTable($query)
    {
        return datatables($query)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->editColumn('device_id', function ($sensor) {
                return '<a href="/device/' . $sensor->device_id . '">'. $sensor->device->name . '</a>';
            })
            ->editColumn('name', function ($sensor) {
                return '<a href="/sensor/' . $sensor->id . '">'. $sensor->name . '</a>';
            })
            ->addColumn('value', function ($sensor) {
                return $sensor->latestData->value;
            })
            ->addColumn('action', 'sensor.action')
            ->blacklist([ 'action', 'value'])
            ->rawColumns(['device_id', 'name', 'action']);
    }

    /**
     * Get the query object to be processed by dataTables.
     *
     * @return \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|\Illuminate\Support\Collection
     */
    public function query()
    {
        $query = Sensor::query();
        return $this->applyScopes($query);
    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\DataTables\Html\Builder
     */
    public function html()
    {
        return $this->builder()
            ->columns($this->getColumns())
            ->minifiedAjax()
            ->parameters($this->getBuilderParameters());
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns()

    {
        return [
            'id',
            [ 'name' => 'device_id', 'data' => 'device_id', 'title' => 'Device', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            'name',
            'type',
            'value',
            'action'
        ];
    }

    /**
     * Get builder parameters.
     *
     * @return array
     */
    protected function getBuilderParameters()

    {
        return [
            'dom'     => 'Bfrtip',
            'order'   => [ [ 0, 'desc' ] ],
            'buttons' => [
                'create',
                'export',
                'print',
                'reset',
                'reload',
            ],
            'paging' => true,
            'searching' => true,
            'info' => true,
            'searchDelay' => 500,
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'sensor_'.time();
    }
}


1		<?php
2
3		namespace App\DataTables;
4
5		use Yajra\DataTables\Services\DataTable;
6		use App\Sensor;
7
8		class SensorDataTable extends DataTable
9		{
10		/**
11		* Build DataTable class.
12		*
13		* @return \Yajra\DataTables\Engines\BaseEngine
14		*/
15		public function dataTable($query)
16		{
17		return datatables($query)
		1 ignored issue – show Bug introduced 2017-10-16 02:54 UTC by Report Bug Copy Issue Report The method `editColumn` does only exist in `Yajra\DataTables\DataTableAbstract`, but not in `Yajra\DataTables\DataTables`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
18		->editColumn('device_id', function ($sensor) {
19		return '<a href="/device/' . $sensor->device_id . '">'. $sensor->device->name . '</a>';
20		})
21		->editColumn('name', function ($sensor) {
22		return '<a href="/sensor/' . $sensor->id . '">'. $sensor->name . '</a>';
23		})
24		->addColumn('value', function ($sensor) {
25		return $sensor->latestData->value;
26		})
27		->addColumn('action', 'sensor.action')
28		->blacklist([ 'action', 'value'])
29		->rawColumns(['device_id', 'name', 'action']);
30		}
31
32		/**
33		* Get the query object to be processed by dataTables.
34		*
35		* @return \Illuminate\Database\Eloquent\Builder\|\Illuminate\Database\Query\Builder\|\Illuminate\Support\Collection
36		*/
37		public function query()
38		{
39		$query = Sensor::query();
40		return $this->applyScopes($query);
41		}
42
43		/**
44		* Optional method if you want to use html builder.
45		*
46		* @return \Yajra\DataTables\Html\Builder
47		*/
48		public function html()
49		{
50		return $this->builder()
51		->columns($this->getColumns())
52		->minifiedAjax()
53		->parameters($this->getBuilderParameters());
54		}
55
56		/**
57		* Get columns.
58		*
59		* @return array
60		*/
61	View Code Duplication	protected function getColumns()
		1 ignored issue – show Duplication introduced 2017-09-20 05:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		return [
64		'id',
65		[ 'name' => 'device_id', 'data' => 'device_id', 'title' => 'Device', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ],
66		'name',
67		'type',
68		'value',
69		'action'
70		];
71		}
72
73		/**
74		* Get builder parameters.
75		*
76		* @return array
77		*/
78	View Code Duplication	protected function getBuilderParameters()
		1 ignored issue – show Duplication introduced 2017-10-16 02:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79		{
80		return [
81		'dom' => 'Bfrtip',
82		'order' => [ [ 0, 'desc' ] ],
83		'buttons' => [
84		'create',
85		'export',
86		'print',
87		'reset',
88		'reload',
89		],
90		'paging' => true,
91		'searching' => true,
92		'info' => true,
93		'searchDelay' => 500,
94		];
95		}
96
97		/**
98		* Get filename for export.
99		*
100		* @return string
101		*/
102		protected function filename()
103		{
104		return 'sensor_'.time();
105		}
106		}
107

uidaho / smartsettia

Pull Request — master (#82)

SensorDataTable::filename() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like